| Message ID | 1470680843-28702-2-git-send-email-arbab@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Mon, Aug 08, 2016 at 01:27:20PM -0500, Reza Arbab wrote: > Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> > --- > .../bindings/powerpc/opal/hotplug-aperture.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt Acked-by: Rob Herring <robh@kernel.org>
On 09/08/16 04:27, Reza Arbab wrote: > Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> > --- > .../bindings/powerpc/opal/hotplug-aperture.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt > > diff --git a/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt b/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt > new file mode 100644 > index 0000000..b8dffaa > --- /dev/null > +++ b/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt > @@ -0,0 +1,26 @@ > +Designated hotplug memory > +------------------------- > + > +This binding describes a region of hotplug memory which is not present at boot, > +allowing its eventual NUMA associativity to be prespecified. > + > +Required properties: > + > +- compatible > + "ibm,hotplug-aperture" > + > +- reg > + base address and size of the region (standard definition) > + > +- ibm,associativity > + NUMA associativity (standard definition) > + > +Example: > + > +A 2 GiB aperture at 0x100000000, to be part of nid 3 when hotplugged: > + > + hotplug-memory@100000000 { > + compatible = "ibm,hotplug-aperture"; > + reg = <0x0 0x100000000 0x0 0x80000000>; > + ibm,associativity = <0x4 0x0 0x0 0x0 0x3>; > + }; > +Stewart and Alistair Looks good to me! Acked-by: Balbir Singh <bsingharora@gmail.com>
Balbir Singh <bsingharora@gmail.com> writes: > On 09/08/16 04:27, Reza Arbab wrote: >> Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> >> --- >> .../bindings/powerpc/opal/hotplug-aperture.txt | 26 ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt Forgive me for being absent on the whole discussion here, but is this an OPAL specific binding? If so, shouldn't the docs also appear in the skiboot tree?
On Thu, Aug 11, 2016 at 02:39:23PM +1000, Stewart Smith wrote: >Forgive me for being absent on the whole discussion here, but is this >an OPAL specific binding? If so, shouldn't the docs also appear in the >skiboot tree? Good question. I guess it's not necessarily OPAL-specific, even though OPAL may initially be the only implementor of the binding. Would it be more appropriate to move the file up a directory, directly under Documentation/devicetree/bindings/powerpc? I hesitated at that because the binding is tied to "ibm,associativity".
diff --git a/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt b/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt new file mode 100644 index 0000000..b8dffaa --- /dev/null +++ b/Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt @@ -0,0 +1,26 @@ +Designated hotplug memory +------------------------- + +This binding describes a region of hotplug memory which is not present at boot, +allowing its eventual NUMA associativity to be prespecified. + +Required properties: + +- compatible + "ibm,hotplug-aperture" + +- reg + base address and size of the region (standard definition) + +- ibm,associativity + NUMA associativity (standard definition) + +Example: + +A 2 GiB aperture at 0x100000000, to be part of nid 3 when hotplugged: + + hotplug-memory@100000000 { + compatible = "ibm,hotplug-aperture"; + reg = <0x0 0x100000000 0x0 0x80000000>; + ibm,associativity = <0x4 0x0 0x0 0x0 0x3>; + };
Signed-off-by: Reza Arbab <arbab@linux.vnet.ibm.com> --- .../bindings/powerpc/opal/hotplug-aperture.txt | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/powerpc/opal/hotplug-aperture.txt