| Message ID | 1470111037-18531-3-git-send-email-gwshan@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, 2016-08-02 at 14:10 +1000, Gavin Shan wrote: > The hub diag-data type is filled with big-endian data by OPAL call > opal_pci_get_hub_diag_data(). We need convert it to CPU-endian value > before using it. The issue is reported by sparse as pointed by Michael > Ellerman: > > gwshan@gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \ > arch/powerpc/platforms/powernv/eeh-powernv.o > : > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > > This converts hub diag-data type to CPU-endian before using it in > pnv_eeh_get_and_dump_hub_diag(). > > Fixes: 2a485ad7c88d ("powerpc/powernv: Drop PHB operation next_error()") > Cc: stable@vger.kernel.org # v4.1+ > Suggested-by: Michael Ellerman <mpe@ellerman.id.au> > Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com> > --- Reviewed-by: Russell Currey <ruscur@russell.cc>
On Tue, 2016-02-08 at 04:10:30 UTC, Gavin Shan wrote: > The hub diag-data type is filled with big-endian data by OPAL call > opal_pci_get_hub_diag_data(). We need convert it to CPU-endian value > before using it. The issue is reported by sparse as pointed by Michael > Ellerman: > > gwshan@gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \ > arch/powerpc/platforms/powernv/eeh-powernv.o > : > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ > warning: restricted __be16 degrades to integer > > This converts hub diag-data type to CPU-endian before using it in > pnv_eeh_get_and_dump_hub_diag(). > > Fixes: 2a485ad7c88d ("powerpc/powernv: Drop PHB operation next_error()") > Cc: stable@vger.kernel.org # v4.1+ > Suggested-by: Michael Ellerman <mpe@ellerman.id.au> > Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com> > Reviewed-by: Russell Currey <ruscur@russell.cc> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a7032132d7560a8434e1f54b71efd7 cheers
diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c index 75363d9..8fec7a3 100644 --- a/arch/powerpc/platforms/powernv/eeh-powernv.c +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c @@ -1306,7 +1306,7 @@ static void pnv_eeh_get_and_dump_hub_diag(struct pci_controller *hose) return; } - switch (data->type) { + switch (be16_to_cpu(data->type)) { case OPAL_P7IOC_DIAG_TYPE_RGC: pr_info("P7IOC diag-data for RGC\n\n"); pnv_eeh_dump_hub_diag_common(data);
The hub diag-data type is filled with big-endian data by OPAL call opal_pci_get_hub_diag_data(). We need convert it to CPU-endian value before using it. The issue is reported by sparse as pointed by Michael Ellerman: gwshan@gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \ arch/powerpc/platforms/powernv/eeh-powernv.o : arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ warning: restricted __be16 degrades to integer arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ warning: restricted __be16 degrades to integer arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ warning: restricted __be16 degrades to integer arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ warning: restricted __be16 degrades to integer arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \ warning: restricted __be16 degrades to integer This converts hub diag-data type to CPU-endian before using it in pnv_eeh_get_and_dump_hub_diag(). Fixes: 2a485ad7c88d ("powerpc/powernv: Drop PHB operation next_error()") Cc: stable@vger.kernel.org # v4.1+ Suggested-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com> --- arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)