From patchwork Tue Jun 7 17:38:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 631819 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rPQ706pdjz9t3n for ; Wed, 8 Jun 2016 07:43:40 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b=PqswbxmG; dkim-atps=neutral Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3rPQ705cNKzDqZf for ; Wed, 8 Jun 2016 07:43:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b=PqswbxmG; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rPJjj41jnzDq64 for ; Wed, 8 Jun 2016 03:39:53 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b=PqswbxmG; dkim-atps=neutral Received: by mail-wm0-f46.google.com with SMTP id k204so79272211wmk.0 for ; Tue, 07 Jun 2016 10:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/8ZzXkjRzjYqAtdY8JKqOrgJ3k9GVY0Mo3EUyEZQd3Y=; b=PqswbxmGRKM6BEI+kouiRpm4R/0KINACaS0F42xvzxLn2FJLOaOtG+kUQ2A5+GY6OT aBgc3TZ0iU0anFy7WjtniY/vb5abubaM73pRcWdgMfCMxcWSb4Q90Vi+vXkJWbhHjD97 9HKb0G7xxAZVbQKjIo0SuMTCS+ptkaqz1cbdk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/8ZzXkjRzjYqAtdY8JKqOrgJ3k9GVY0Mo3EUyEZQd3Y=; b=B99NG4/IZz3LUdUPX8wGotYNBRRqLzEEXNRj+1hZP6C3raMwZOREp7wESQTwyGg547 k3m0UgarZRaNh07FssttxNSoe87lm2TGrz+tcGf+6K1uiA9ACt9OvlU2PPC4Eb2+gbw5 eedxfgQmLvq6q1QBu1fePZtWvzXeIBx85whOcoCc41ldQhH1F28ffnlZYDjvulDqebvz Ats7pblxzM+z/tALKFYfgHYOwb7F27CI1bjeTbK1XmqH85KolTU5bXdrvlAJziAGLfqN pk7srKm/n+BhyQRqDUxwUxGfO6U42glYWL3NpC9KMM85HEt9JrtepSES3BbrEoH+hXTi Sp7w== X-Gm-Message-State: ALyK8tJnqb8qrEvz3pPkoITlWXmEssk3LH64YJ69bLTWpVBtkU3lYmVAoaTBgb0ItqiACwQa X-Received: by 10.194.121.202 with SMTP id lm10mr533897wjb.134.1465321131003; Tue, 07 Jun 2016 10:38:51 -0700 (PDT) Received: from localhost.localdomain (cpc84731-aztw28-2-0-cust112.18-1.cable.virginm.net. [82.37.67.113]) by smtp.gmail.com with ESMTPSA id h8sm1310031wjg.9.2016.06.07.10.38.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 07 Jun 2016 10:38:49 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, linus.walleij@linaro.org, dan.j.williams@intel.com, leoli@freescale.com, zw@zh-kernel.org, baohua@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, ldewangan@nvidia.com, jonathanh@nvidia.com, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com Subject: [PATCH 3/8] dmaengine: coh901318: Only calculate residue if txstate exists. Date: Tue, 7 Jun 2016 18:38:36 +0100 Message-Id: <1465321121-22238-4-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465321121-22238-1-git-send-email-peter.griffin@linaro.org> References: <1465321121-22238-1-git-send-email-peter.griffin@linaro.org> X-Mailman-Approved-At: Wed, 08 Jun 2016 07:37:26 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.griffin@linaro.org, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, lee.jones@linaro.org, linuxppc-dev@lists.ozlabs.org MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" There is no point in calculating the residue if there is no txstate to store the value. Signed-off-by: Peter Griffin Acked-by: Linus Walleij --- drivers/dma/coh901318.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c index c340ca9..c100616 100644 --- a/drivers/dma/coh901318.c +++ b/drivers/dma/coh901318.c @@ -2422,7 +2422,7 @@ coh901318_tx_status(struct dma_chan *chan, dma_cookie_t cookie, enum dma_status ret; ret = dma_cookie_status(chan, cookie, txstate); - if (ret == DMA_COMPLETE) + if (ret == DMA_COMPLETE || !txstate) return ret; dma_set_residue(txstate, coh901318_get_bytes_left(chan));