From patchwork Tue Mar 8 21:26:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 594351 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1BF24140328 for ; Wed, 9 Mar 2016 08:27:51 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b=VOVe63YS; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id EBB2D1A099D for ; Wed, 9 Mar 2016 08:27:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b=VOVe63YS; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id C6B861A005D for ; Wed, 9 Mar 2016 08:26:29 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b=VOVe63YS; dkim-atps=neutral Received: by mail-wm0-x22d.google.com with SMTP id l68so45403514wml.1 for ; Tue, 08 Mar 2016 13:26:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id; bh=Z2z1ByVdRTfiRn8CrBKv+RU3qeCkMoNwDxEhgm6MNSk=; b=VOVe63YSgMSEzbP64YyKJhE4ZaLF2bb6nHDZw9ta0g5X+OT7O3lchxUvFXLzpAibHA QuMhB9wji3bNG3TS/7yBqNAFaZw6w9D4NOBBrro3WudlsWUswRCJXwn/A3iMC+8TAsbB eiDo9bbetizlvG7GCVdbSq3KDjGIUineWp5iU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Z2z1ByVdRTfiRn8CrBKv+RU3qeCkMoNwDxEhgm6MNSk=; b=aLnwAny9/KFO6//IOsEqCJ4q5CU1VVkEvUSX29UNeplNG/F8xitheD5LLPo+3/7AUv PLPNk7N6UKAMLSyS4f8G7g3PeIoc4DhjTTW8mpTjg7A0onZTuzDZd9rX+D7+y8Xaim7s jZN6ErCSFg977DykQe4g4C3dKhlie+1yOV94dSwiYaX6+l7Zpb5ZgiA4PS/8CSljFzmw HwJS8TFAw+lWavpC0Dq5sk0UJy0y3K++QcmzHlrxT0O8Nu6GdC5TAAXy/wH/16Cvl344 Wa9YwTFUFJEHBbclx71dRjo6PmgF5T1Mda+LhAaKYzXPFArHzbkiyFs6oHhyXwynJSOj hHLQ== X-Gm-Message-State: AD7BkJIR4DtzYOnsQMoDquXLlnqfrL+zJSN1foY7qUYjYAlDSo6gACp1ROt2WyoescgWjg== X-Received: by 10.194.187.71 with SMTP id fq7mr29994869wjc.97.1457472385508; Tue, 08 Mar 2016 13:26:25 -0800 (PST) Received: from wildmoose.dk (lvps87-230-87-209.dedicated.hosteurope.de. [87.230.87.209]) by smtp.gmail.com with ESMTPSA id ka4sm4747311wjc.47.2016.03.08.13.26.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Mar 2016 13:26:24 -0800 (PST) From: Rasmus Villemoes To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Subject: [PATCH] powerpc/pseries: fix error return value in cmm_mem_going_offline Date: Tue, 8 Mar 2016 22:26:17 +0100 Message-Id: <1457472378-22274-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.4 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, Rasmus Villemoes , linux-kernel@vger.kernel.org MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" cmm_mem_going_offline is (only) called from cmm_memory_cb(), which sends the return value through notifier_from_errno(). The latter expects 0 or -errno (notifier_to_errno(notifier_from_errno(x)) is 0 for any x >= 0, so passing a positive value cannot make sense). Hence negate ENOMEM. Signed-off-by: Rasmus Villemoes --- arch/powerpc/platforms/pseries/cmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pseries/cmm.c b/arch/powerpc/platforms/pseries/cmm.c index fc44ad0475f8..66e7227469b8 100644 --- a/arch/powerpc/platforms/pseries/cmm.c +++ b/arch/powerpc/platforms/pseries/cmm.c @@ -574,7 +574,7 @@ static int cmm_mem_going_offline(void *arg) cmm_dbg("Failed to allocate memory for list " "management. Memory hotplug " "failed.\n"); - return ENOMEM; + return -ENOMEM; } memcpy(npa, pa_curr, PAGE_SIZE); if (pa_curr == cmm_page_list)