From patchwork Mon Feb 15 14:35:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 582975 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A5BB6140273 for ; Tue, 16 Feb 2016 01:48:53 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 89FF41A06DA for ; Tue, 16 Feb 2016 01:48:53 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 948871A034B for ; Tue, 16 Feb 2016 01:46:51 +1100 (AEDT) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2L00BCUF982A40@mailout4.w1.samsung.com> for linuxppc-dev@lists.ozlabs.org; Mon, 15 Feb 2016 14:36:44 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-e9-56c1e27c7f39 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 3C.F6.16778.C72E1C65; Mon, 15 Feb 2016 14:36:44 +0000 (GMT) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O2L005QPF94GF00@eusync3.samsung.com>; Mon, 15 Feb 2016 14:36:44 +0000 (GMT) From: Andrzej Hajda To: linux-kernel@vger.kernel.org Subject: [PATCH 7/7] usb: gadget: fsl_qe_udc: fix IS_ERR_VALUE usage Date: Mon, 15 Feb 2016 15:35:25 +0100 Message-id: <1455546925-22119-8-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> References: <1455546925-22119-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrALMWRmVeSWpSXmKPExsVy+t/xq7o1jw6GGZw5JGhxa905VouNM9az Whxre8Ju0bx4PZvFrwdCFpd3zWGzWLSsldni9/d/rBZrj9xld+D0+He4n8lj06pONo/9c9ew e5yfsZDRo2/LKkaPz5vkAtiiuGxSUnMyy1KL9O0SuDKufbvBXnCIveL8rl8sDYwb2boYOTgk BEwk3r2W7mLkBDLFJC7cWw8U5uIQEljKKLEYqA7CaWKS2L/gAxtIFZuApsTfzTfBbBEBBYnN vc9YQYqYBfYzSXxr6WYHmSos4CKx57cbSA2LgKpEy/ptzCA2r4CzxLUll9ghtslJnDw2mRWk nBOofMHeApCwEFDJ/t3bmCYw8i5gZFjFKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERJuX3Yw Lj5mdYhRgINRiYc34syBMCHWxLLiytxDjBIczEoivBanD4YJ8aYkVlalFuXHF5XmpBYfYpTm YFES5527632IkEB6YklqdmpqQWoRTJaJg1OqgTF3g6VlRY1x2feYxodiwq8fKwjbVBbsmB4s 3OOg/umW6a+rDyqurvyVei+Mzeha9LqXexZOsynT/Jvhn9r58W3F7BW+M7kXruHgW5vo2L73 +V9JuQC/14f+tPG2BKfP6tqvFC3GO+HZs8BnyX3L3bv83FoKlDqtuLIsFrvtSpG8xfH/6mvZ GiWW4oxEQy3mouJEAPch6BIzAgAA X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Andrzej Hajda , linuxppc-dev@lists.ozlabs.org, Marek Szyprowski MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" IS_ERR_VALUE macro should be used only with unsigned long type. Otherwise it can work incorrectly. The patch follows conclusion from discussion on LKML [1][2]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 Signed-off-by: Andrzej Hajda --- drivers/usb/gadget/udc/fsl_qe_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c index 53c0692..93d28cb 100644 --- a/drivers/usb/gadget/udc/fsl_qe_udc.c +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c @@ -2340,7 +2340,7 @@ static struct qe_udc *qe_udc_config(struct platform_device *ofdev) { struct qe_udc *udc; struct device_node *np = ofdev->dev.of_node; - unsigned int tmp_addr = 0; + unsigned long tmp_addr = 0; struct usb_device_para __iomem *usbpram; unsigned int i; u64 size;