From patchwork Sat Jul 18 20:08:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Wood X-Patchwork-Id: 497402 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D6897140B0E for ; Sun, 19 Jul 2015 06:15:00 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id B48E31A1D69 for ; Sun, 19 Jul 2015 06:15:00 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1on0130.outbound.protection.outlook.com [157.56.110.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 50AD91A0DF4 for ; Sun, 19 Jul 2015 06:09:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=none (message not signed) header.d=none; Received: from snotra.am.freescale.net (192.88.168.49) by CY1PR03MB1486.namprd03.prod.outlook.com (10.163.17.16) with Microsoft SMTP Server (TLS) id 15.1.213.14; Sat, 18 Jul 2015 20:09:17 +0000 From: Scott Wood To: Subject: [RFC PATCH 04/17] powerpc/fsl-corenet: Disable coreint if kexec is enabled Date: Sat, 18 Jul 2015 15:08:41 -0500 Message-ID: <1437250134-307-5-git-send-email-scottwood@freescale.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1437250134-307-1-git-send-email-scottwood@freescale.com> References: <1437250134-307-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 X-Originating-IP: [192.88.168.49] X-ClientProxiedBy: BY2PR21CA0002.namprd21.prod.outlook.com (25.162.74.140) To CY1PR03MB1486.namprd03.prod.outlook.com (25.163.17.16) X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB1486; 2:qHNmyeE3lv9iIOOBSWFNQLIYIjfRIxkOcNqi0W8wM8ChY5X4Do2yJS4lHDDpcutJ; 3:uc4OrSjSOXf2XSY0sLTf68Y8b4j2a64JwqHIsl4qZfjku0oiGeVlDAPPQrdzEWb+hNtnvHamfFzSzvgzmR7cPzieEcd1biUJ0btR6e3W62uhA9X/zfm/NpyBD+8zLmOpNvxN+OAw6dhvtSBurH4IKw==; 25:4LMAysKH10hj1LgKFI4EkqnmDL/ELUJHgrTgP9or8O14ToGWwtKn9QcySrdXH9nmV/4AjrzeFxg0zt8+HCQxG3RUnGIBRrWUyn8Exgj+M1e6zBsxuRtWABMrz7T5UqCqxtQ+rj192IbNdsgyRw1RuAFAQa17pPCrut9PX9FAPR4YV01fPvQOD8VMhVdxOkcfFU7xX0cRHzWpAst60gshzfLIbx1YGQWn4na27BeBbzeCNBhURa/EJo0KkAKG8/xnxrm6v7zL9rbrdySwXfuwOw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1486; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB1486; 20:2O1rCWZ16BR+pODJGS3Nw4DlF3MOgLG7sR9rbY3fBpihxpq1MQreGhB0OEuI9snI8xpJ9H7V0K1UOSgsPS/8byk3k1TEc52RM1Yz1mirqR5hfvsghAZnnFgkm1Y4TPQW0hspAeEsG2UZ86k9YzCf/dGRGhbHq6N0J8K602XPV0hLxwZpgAJ1+p3kp8Hq7QKb2GIKSQATtZ7DBE2X5pGTatbKIrxR7Bs2ItluNLEhs0PfcC03vV+kYnxbTUI27lpaqsGGnq2qGeI33B8bKD5P0Op75OaK8hU6rItA1NOh1YDBJ5hk+zqABgXLZmcoRDql095OfaDc1Ap500euegau/jmXqvS6WGJwvZqNmmktKIbc8ySWK5bB4015ABiyi29ic+xkHw43JT1zcn376GsMez6FqMT0z5vTT1DM1dq5e+IjFLirdMLXNVg2wCaQj0qTo1VzXGrPtRxHrLiTP3OLzK0F4rFjhSC1VbifScRN5tqgcqtF+hsVvilAufPc3h18; 4:vX5vK+YGZHz4S/Viw5ArJJo6BJ5f4dUm0LQ4zo0Z1RtPydB5YFaVOvfy8358kVEsW/aFvNkZ051xfjTdrhEwvKLetckoM912SLDFLnLlY2PhTfzh07jhrSiVwRlPJxPp+/bwWB5rVQFqLoWycHeYmXKGz2czQpJrDG6roHsvG7X2a72dbHPEoXz21VlhTnY2Swuv9m7X6CnPtMqfmtIApJojF1K+p2QcSQjoSQRP2DBv4oe0Qv+KlBd06Hkt4DGSUrB8k0HNT8iAYtUWKRxUo39ZCSJGtzE/4RbZUaN4B5I= CY1PR03MB1486: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:CY1PR03MB1486; BCL:0; PCL:0; RULEID:; SRVR:CY1PR03MB1486; X-Forefront-PRVS: 0641678E68 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(19580395003)(50466002)(19580405001)(229853001)(36756003)(46102003)(2351001)(42186005)(40100003)(87976001)(122386002)(33646002)(86362001)(62966003)(5001960100002)(5001920100001)(92566002)(2950100001)(110136002)(77096005)(107886002)(48376002)(77156002)(50986999)(76176999)(66066001)(47776003)(50226001)(5003940100001)(189998001)(217873001)(4001430100001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR03MB1486; H:snotra.am.freescale.net; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB1486; 23:MDgQWoXWVH9z+A1iSikBuETmFkSLdlV68SVjoM9cyxuK7+zq5VwBbXMgLqzq/mtokH132xEJjNnc3AoTNer/BMiw7PCJx/UZdLp52LkHH/ItRsV4phcG7rgkTdXdQkKvNnThwo2quiiA+x9+27GheJ6cmMZ9ZE3HIPEnKzr2oEYwLDEM0oZUfKJyB0BKYHxO8O9AD49mmStfal2W8Su4GiznH/lStydYo1mFV7ARNr4do/N11aOvmRPxtdeJnRTK6RifUXmgibIHrm3Ut7zknXYABHYj7xb97Z1osWt12hDjqfWsPyEFA80oOiEslw2e+oENaNZQ8DN4jM0JpIyzlyVu6LuwqPIcjzy9FQMmof/UzS886P9efJ86h2NogT+yk7STMuezyzcRQHq9YdrV+FAXUW8mb0l7ZF0GyjFhnMDvNE8x0Iwy+57Go5Lhqa8l8KZLYr06m2t9sJyxWtoPI0i+GidsD6ROHflylV2/uyjLjTYPvhVM1976mw9eVXZgfz3zBRG8usPIXcGPUoV+evzTre/90mDSKyIOvxhQFVhRPHmEo0ChOaUishfHS3+8fvlGpoc6/eqKC44Cq6X0N8CZO8odE72SvKzzXxez7o3uPCjqbD/C/w3oCVy3fvH66DkgOgntRAbDOvfWFLdE7Hf0TufwKCSrBnBCzNbH81zyrDp2iR3NtWjDfifpupUzPiXFXlAxCckMZwQDkni6AwHh7rFg44Ol/Gou2DPwPa7hS6Vq4IEunSm/NbgWxdrBYP3tFz7EOC7wpZyV4lRgH4Pfu/WWBl73pDXUaQ++e4E+Jdu9OBWOWVfg5hkd50iQJvKCV9XMJxwauyssbxgHPyQc9xWsSYHq6vfLRYS69eaFnVoOyzMoupsApkOYx8sz5q0wa66UlfCcYAqNSVdXyCXHwRTpZX9lM9nAOsvRNWg= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB1486; 5:7/mSzWRBt3c5CLBGPg9B8WEaieyR8mgjuwO4kPId+VLj2wcMyT6Urg74lhSM8kYRJsP94jn4sBdx+ka/pAkUAVaRQ6ZYmR/Cwm/uC7ce+en1DTAgJgJcsEbaPgMDEpUcLApTqlcv4PLkoDT6fnNqDw==; 24:CvMvfN+K0KVQmhTWY0OwKOHPbgPIcoHabhWpGkLu0XNPgMylDsM5Nix2cNomNbba0he1RDSGwmdDnLiXs45rK0X/aeBbMU9DuOEVoKMBhOY=; 20:v7pk/DLkrZPSg9gxNQMminj0dwEPOr3ApJZlQSAeiZcDF4uO1Vfgt4ibbsuLelR520qyN2fg75A1rwXro6dKrA== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2015 20:09:17.3398 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1486 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Wood , Tiejun Chen , kexec@lists.infradead.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Problems have been observed in coreint (EPR) mode if interrupts are left pending (due to the lack of device quiescence with kdump) after having tried to deliver to a CPU but unable to deliver due to MSR[EE] -- interrupts no longer get reliably delivered in the new kernel. I tried various ways of fixing it up inside the crash kernel itself, and none worked (including resetting the entire mpic). Masking all interrupts and issuing EOIs in the crashing kernel did help a lot of the time, but the behavior was not consistent. Thus, stick to standard IACK mode when kdump is a possibility. Signed-off-by: Scott Wood --- Supposedly there are similar problems with certain low power states -- the SDK disables coreint when CPU hotplug is enabled -- so disabling it for kexec as well doesn't seem like a big deal. --- arch/powerpc/platforms/85xx/corenet_generic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c index bd839dc..cddc9a2 100644 --- a/arch/powerpc/platforms/85xx/corenet_generic.c +++ b/arch/powerpc/platforms/85xx/corenet_generic.c @@ -212,7 +212,11 @@ define_machine(corenet_generic) { .pcibios_fixup_bus = fsl_pcibios_fixup_bus, .pcibios_fixup_phb = fsl_pcibios_fixup_phb, #endif +#ifdef CONFIG_KEXEC + .get_irq = mpic_get_irq, +#else .get_irq = mpic_get_coreint_irq, +#endif .restart = fsl_rstcr_restart, .calibrate_decr = generic_calibrate_decr, .progress = udbg_progress,