From patchwork Fri Jun 19 02:49:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Wood X-Patchwork-Id: 486558 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46F6A140271 for ; Fri, 19 Jun 2015 12:51:45 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 2BE8F1A18B0 for ; Fri, 19 Jun 2015 12:51:45 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0122.outbound.protection.outlook.com [207.46.100.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 602A91A0EF5 for ; Fri, 19 Jun 2015 12:49:39 +1000 (AEST) Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none; Received: from snotra.am.freescale.net (192.88.168.50) by BLUPR03MB1475.namprd03.prod.outlook.com (10.163.81.17) with Microsoft SMTP Server (TLS) id 15.1.190.14; Fri, 19 Jun 2015 02:49:31 +0000 From: Scott Wood To: Mike Turquette , Tang Yuantian Subject: [RFC PATCH 1/8] ARM: dts: ls1021a: Fix clockgen node Date: Thu, 18 Jun 2015 21:49:11 -0500 Message-ID: <1434682158-7243-2-git-send-email-scottwood@freescale.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1434682158-7243-1-git-send-email-scottwood@freescale.com> References: <1434682158-7243-1-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 X-Originating-IP: [192.88.168.50] X-ClientProxiedBy: BLUPR08CA0070.namprd08.prod.outlook.com (10.141.200.50) To BLUPR03MB1475.namprd03.prod.outlook.com (25.163.81.17) X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1475; 2:xxyogFrPOFH7wCqkmijHoaZgb3VuYt8WnBjDK+RtOEOXTx9CsL/E4dukKAEK7WTd; 2:sgMnfdReHFxSNB5HWwr2TJkg7O4a5ZTaMOe609IwvfopvznDQqBM5cgrTTVOStyCpNJw2S8SdR5KNLk5PtamEPZJIRmYiMB0jKbEa6sXVDFwqbwuqEbBh6kFSTHvqaoMnqKG+SZnzfNmJBHu2kZbjw==; 6:qffvwL+3QBc0Mp+j3qoq5UVx0g3wV9JPH7feohzPEk/SG3Z4zp8fCRTViVKeFXpjlyxNp94dD+R61m6S8G7sh4JtuCYN3asGixyFOKYKj6oADM3w8pQME9orvZ9UvzrEWD3aAU8e+mGpdGrrk4DsruroVHWFqI/CRlMB0Q9R6SWDNzZ2/4OCqKZ7rS2cfV6lexNkQ7FFup+PcxMkDMJEjr1yiBslSnEwrjE4ZjEuU7wYEi84b7B4ZDBAZzJpXWR1cYYJUKPmpB3QgeA2DXayVgGZIwxvsO1ruv1EH26xyRTpHgNwH+6MHRGgQ/KvzEhM4Cnn/P2hi+i6yNvxI6vlGksfPd7cun4BFd/3kmzXjrrRHprQP12nvZjM2ZizBLMpIIGSRwOrmebGCS6gB5UtfRARdePn1/OKBrnRz5C+FtWqruB6uoskzHhB9iKOOeY20VfMHtzTktRrnnOWE1psOtbzMFglAE1BXcaWFjTqtkhvUWwdLNZMkM87cEV86x9zLWfwgMoEvbV7F9hzLyTpWLl886mMWc1yBIUkeegh6FxQRmoelAcn+zT38AqfEjEwYoacyu2q1o3CwSvHWmIYnQjQHddj1LLJqwD9+lIepkg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1475; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BLUPR03MB1475; BCL:0; PCL:0; RULEID:; SRVR:BLUPR03MB1475; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1475; 3:hc59tvt3C8qTltEQ7YyHDW7bBMz7FNgp0BrYJe4J2OSMKvyvoh3WI8fE/WxPlRKFlyvA0HifAGHs6kRuZi0bcAJWR6E1R021hb9UTpGzYtndM4DxY3XOHKMq+dwF2a4yXzaxB/uIwbeCY6WryLScB45ETvbMqR5elX5Pr4YjWTFsUXXifX2GZc2jFRn/rlOixVEXpX8w0AWUHCmxzcIyxWzb4w7n0VWXqJxKHE92soSvRz4k+s3+JtTd+5x1aJW/zvgpBANoEFW9hcnz9OMeb78mpDHb6ZeB8dVr0OQR0ug= X-Forefront-PRVS: 0612E553B4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(575784001)(86362001)(77096005)(33646002)(76176999)(40100003)(87976001)(122386002)(36756003)(50466002)(189998001)(50986999)(50226001)(92566002)(48376002)(62966003)(77156002)(229853001)(42186005)(5001960100002)(19580395003)(2950100001)(46102003)(66066001)(19580405001)(47776003)(5001770100001)(4001450100001)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR03MB1475; H:snotra.am.freescale.net; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1475; 9:LGgaGawNuKQeABV1fnUxwPinYE1ppzavPKILTs2Ndele01czly7ofoW8a+MkGt/u5euuXm+pFvMYNE3sNi/FC6WobQVlIoW5cdRFva4E0sseW4Efevy7qaYzHLQxuGWoROBoLwUR2/d8VvqlrACbyBcfvsg7stYikF3XAD3JBwyIo0ZgM6EE2ToFXxvLBRdhUNLedza1+GGzkOguigsVApSJE/MBw4GhpyKPikkh0q/3RlvQPhVeBwjh9NM/l5FjxNRAx/GBGZnk3lam2L6FEQZqCQ601Zo6zI5tymB8Fsuo6V82NLI0IGhaZxHy1Qm+JzuSsRVIkr6ni3h/DwLbgH7h7jy1I3vdOgLumWLiFNud7P6rIt2EeJ6mVJB+F4oNk5XlRS+V5touM8lUSlgAogVw56R0LwnhYPLnunzf63sc/WKL0jIJCJKmMrXlD0QxwhjBJPp8AC5tstMdWdWp+KVTY8freiW/3BYod23DO3ulspO+4AOzCWC7oLT5F7hNDks6ZhtQgKGCHiDDPvnDq5Q//HPL9xBwOx/I5gBEwgy9KAp4lbLbpJV7Wa1KtJHg0ATNaLqCL6WYoLhfpsjMann5r0a+sGe/YNPCrKpirCl7TcFtjwdXegmjcuGMBzYU/ZXEDzXV7q/cvVDv/glYiDnb2iDc0+EYFrGI/RZRrsg/qBGgZbcHesFCQKh4q9yg/CTROs1lPTGHN/f2j9R8A1ZLQKhygZCTDkKZKMUSJfNqpd8D8Qam+Y9FmL2MXpJ1XtuJglLf1BNXJsd7KTntkOmig6D9/ICJDRkp6lGKZn92awOfjEGwLPEtDwUEmYofvwGLkk2mLbbf8Bpacx1Xag== X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1475; 3:zvWitiAZX+Ce3llOe2HGTcNFvHsUmzIxXXJEPhuCdpZwyW4wR5oF9JEpTNLGWVelhBvOIr7WHRw3stGj6klA7BhEeDVy2Rm9m2cqfCqeKbanUa6Ym3VcEMquetKgtYd04bOp6igUaPhWI0iIlGzTqQ==; 10:y5Sba+i46f2iipAtgTLL2dVzlWZ3L9ZbCvAl2dxRKQBN0w2WJrBU3f38REnHCCeiKfexOnzxIYbpgo8HHULtYYcVjDWP/bNjUE9ImSSVozw=; 6:oPceQW4/Hp9xfYtuFnOdSe2t2cy0qCcu+9KXpbJF+TSSfEdU9cWc2EvJc9bkn7WF X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2015 02:49:31.1658 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1475 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Liberman Igal-B31950 , Scott Wood , Jingchang Lu , Shawn Guo , linuxppc-dev@lists.ozlabs.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bucur Madalin-Cristian-B32716 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" The binding requires compatible and reg properties, but the ls1021a device tree does not contain them. This will break with subsequent clock driver changes. If required (it's not clear to me whether the ls1 code currently works at all -- I tried multi_v7_defconfig and it didn't boot, whereas I was able to boot an SDK kernel), backwards compatibility can be retained with a device tree fixup. LS1021A also deviates from existing QorIQ clockgen practice by making the sysclk node be a fixed-clock node rather than the U-Boot compatibility hack of having a clock-frequency property in the clockgen node itself, and a fsl,qoriq-sysclk-... node that exports the clock. While this is not a violation of the existing binding, the upcoming rework of the clock driver requires that a driver for the clockgen node itself be able to find the input clock. Thus, a clocks property is added to reference the sysclk node. Signed-off-by: Scott Wood Cc: Jingchang Lu Cc: Shawn Guo --- arch/arm/boot/dts/ls1021a.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index c70bb27..a0a1c51 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -146,9 +146,12 @@ }; clockgen: clocking@1ee1000 { + compatible = "fsl,ls201a-clockgen"; #address-cells = <1>; #size-cells = <1>; + reg = <0 0x1ee1000 0x10000>; ranges = <0x0 0x0 0x1ee1000 0x10000>; + clocks = <&sysclk>; sysclk: sysclk { compatible = "fixed-clock";