From patchwork Fri Feb 27 05:30:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yanjiang.jin@windriver.com X-Patchwork-Id: 444240 X-Patchwork-Delegate: michael@ellerman.id.au Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C40A11400F1 for ; Fri, 27 Feb 2015 21:42:49 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 9352B1A075A for ; Fri, 27 Feb 2015 21:42:49 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org X-Greylist: delayed 9413 seconds by postgrey-1.35 at bilbo; Fri, 27 Feb 2015 19:07:37 AEDT Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 7D9941A006F for ; Fri, 27 Feb 2015 19:07:37 +1100 (AEDT) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.9/8.14.5) with ESMTP id t1R5UaeO022967 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 26 Feb 2015 21:30:37 -0800 (PST) Received: from localhost.localdomain (128.224.153.42) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.174.1; Thu, 26 Feb 2015 21:30:36 -0800 From: To: Subject: [PATCH] ppc: mm: free memory after creating kmem cache Date: Fri, 27 Feb 2015 13:30:34 +0800 Message-ID: <1425015034-26419-1-git-send-email-yanjiang.jin@windriver.com> X-Mailer: git-send-email 1.7.0.5 MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 27 Feb 2015 21:41:54 +1100 Cc: jinyanjiang@gmail.com, linuxppc-dev@lists.ozlabs.org, yanjiang.jin@windriver.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Yanjiang Jin kmem_cache_create()->kmem_cache_create_memcg()->kstrdup() allocates new space and copy name's content, so it is safe to free name memory after calling kmem_cache_create(). Else kmemleak would report the below warning: unreferenced object 0xc0000000f9002160 (size 16): comm "swapper/0", pid 0, jiffies 4294892296 (age 1386.640s) hex dump (first 16 bytes): 70 67 74 61 62 6c 65 2d 32 5e 39 00 de ad be ef pgtable-2^9..... backtrace: [] .kvasprintf+0x5c/0xa0 [] .kasprintf+0x2c/0x50 [] .pgtable_cache_add+0xac/0x100 [] .pgtable_cache_init+0x24/0x80 [] .start_kernel+0x228/0x4c8 [] .start_here_common+0x24/0x90 Signed-off-by: Yanjiang Jin --- arch/powerpc/mm/init_64.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c index a90b9c4..fe0631f 100644 --- a/arch/powerpc/mm/init_64.c +++ b/arch/powerpc/mm/init_64.c @@ -129,6 +129,7 @@ void pgtable_cache_add(unsigned shift, void (*ctor)(void *)) align = max_t(unsigned long, align, minalign); name = kasprintf(GFP_KERNEL, "pgtable-2^%d", shift); new = kmem_cache_create(name, table_size, align, 0, ctor); + kfree(name); pgtable_cache[shift - 1] = new; pr_debug("Allocated pgtable cache for order %d\n", shift); }