From patchwork Wed Jan 14 13:51:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 428972 X-Patchwork-Delegate: michael@ellerman.id.au Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8883C140285 for ; Thu, 15 Jan 2015 01:05:08 +1100 (AEDT) Received: from ozlabs.org (ozlabs.org [103.22.144.67]) by lists.ozlabs.org (Postfix) with ESMTP id 762A91A0E0F for ; Thu, 15 Jan 2015 01:05:08 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org X-Greylist: delayed 750 seconds by postgrey-1.35 at bilbo; Thu, 15 Jan 2015 01:04:32 AEDT Received: from winston.telenet-ops.be (winston.telenet-ops.be [195.130.137.75]) by lists.ozlabs.org (Postfix) with ESMTP id 69DF61A0C78 for ; Thu, 15 Jan 2015 01:04:32 +1100 (AEDT) Received: from andre.telenet-ops.be (andre.telenet-ops.be [195.130.132.53]) by winston.telenet-ops.be (Postfix) with ESMTP id 98FE71BE0F7 for ; Wed, 14 Jan 2015 14:51:59 +0100 (CET) Received: from ayla.of.borg ([84.193.93.87]) by andre.telenet-ops.be with bizsmtp id fprw1p00l1t5w8s01prwZA; Wed, 14 Jan 2015 14:51:58 +0100 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.82) (envelope-from ) id 1YBOMW-000377-MG; Wed, 14 Jan 2015 14:51:56 +0100 Received: from geert by ramsan with local (Exim 4.82) (envelope-from ) id 1YBOMa-0001dd-He; Wed, 14 Jan 2015 14:52:00 +0100 From: Geert Uytterhoeven To: Benjamin Herrenschmidt , Bryan Wu , Richard Purdie , Jingoo Han , Lee Jones Subject: [PATCH 1/3] powerpc/pmac: Fix DT refcount imbalance in pmac_pic_probe_oldstyle Date: Wed, 14 Jan 2015 14:51:57 +0100 Message-Id: <1421243519-6257-2-git-send-email-geert+renesas@glider.be> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421243519-6257-1-git-send-email-geert+renesas@glider.be> References: <1421243519-6257-1-git-send-email-geert+renesas@glider.be> Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" of_find_node_by_name() calls of_node_put() on its "from" parameter, which must not be done on "master", as it's still in use, and will be released manually later. This may cause a zero kref refcount. Use of_get_child_by_name() instead to fix this. Signed-off-by: Geert Uytterhoeven Cc: linuxppc-dev@lists.ozlabs.org --- Compile-tested only --- arch/powerpc/platforms/powermac/pic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c index 4c24bf60d39d2834..90ada1209c118902 100644 --- a/arch/powerpc/platforms/powermac/pic.c +++ b/arch/powerpc/platforms/powermac/pic.c @@ -321,7 +321,7 @@ static void __init pmac_pic_probe_oldstyle(void) max_irqs = max_real_irqs = 64; /* We might have a second cascaded heathrow */ - slave = of_find_node_by_name(master, "mac-io"); + slave = of_get_child_by_name(master, "mac-io"); /* Check ordering of master & slave */ if (of_device_is_compatible(master, "gatwick")) {