From patchwork Fri Nov 14 05:51:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hao X-Patchwork-Id: 410706 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 16D731400E7 for ; Fri, 14 Nov 2014 16:52:11 +1100 (AEDT) Received: from ozlabs.org (ozlabs.org [103.22.144.67]) by lists.ozlabs.org (Postfix) with ESMTP id 012BB1A2020 for ; Fri, 14 Nov 2014 16:52:11 +1100 (AEDT) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id AE0661A0023 for ; Fri, 14 Nov 2014 16:51:39 +1100 (AEDT) Received: by mail-pa0-f47.google.com with SMTP id kx10so16861039pab.20 for ; Thu, 13 Nov 2014 21:51:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=sPYG2/0e2WbyiRiUsZT572QUR6zwlpg9ooyI/USi7b4=; b=mppLIBKd1yuUnZ2t8bxFbLFvWDTaIn+RIwrUyRc4xJc1tOr21PThN3VDqBGPkpHZWy XQUnWaqGPeKWQumOlnBcM9vccv7dsAn5u78OVZyuh21ZL9v+t1EZTDs7duOxVRe/vj/H 6qahutS3uU755YY9I0GC1rsquhfhKBgCMrEPNtijCbUchgMJUU5SYmtR9yfRDaw3398u myAV2+IdV8vjubm1j/6AdeyDridkb0qDwahlh5DCorRrcUrXAyRzVadY+Qom/ZsoIaJl K7bWkL5KkVY4t3h2xQUBw0/SApK+LFd/pbDmUvCjCtymWyPy9OyP9NIwbXRDOMDY4Ocp 1u7g== X-Received: by 10.70.11.227 with SMTP id t3mr7978588pdb.4.1415944297378; Thu, 13 Nov 2014 21:51:37 -0800 (PST) Received: from pek-khao-d1.corp.ad.wrs.com ([106.120.101.38]) by mx.google.com with ESMTPSA id lb9sm8758811pbc.22.2014.11.13.21.51.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2014 21:51:36 -0800 (PST) From: Kevin Hao To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH] powerpc/fsl_msi: mark the msi cascade handler IRQF_NO_THREAD Date: Fri, 14 Nov 2014 13:51:22 +0800 Message-Id: <1415944282-1827-1-git-send-email-haokexin@gmail.com> X-Mailer: git-send-email 1.9.3 Cc: Scott Wood , Laurentiu Tudor X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" The commit 543c043cbae7 ("powerpc/fsl_msi: change the irq handler from chained to normal") changes the msi cascade handler from chained to normal. Since cascade handler must run in hard interrupt context, this will cause kernel panic if we force threading of all the interrupt handler via kernel command parameter 'threadirqs'. So mark the irq handler IRQF_NO_THREAD explicitly. Signed-off-by: Kevin Hao --- arch/powerpc/sysdev/fsl_msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c index a5a6c24577fe..5997c5378c84 100644 --- a/arch/powerpc/sysdev/fsl_msi.c +++ b/arch/powerpc/sysdev/fsl_msi.c @@ -360,7 +360,7 @@ static int fsl_msi_setup_hwirq(struct fsl_msi *msi, struct platform_device *dev, cascade_data->virq = virt_msir; msi->cascade_array[irq_index] = cascade_data; - ret = request_irq(virt_msir, fsl_msi_cascade, 0, + ret = request_irq(virt_msir, fsl_msi_cascade, IRQF_NO_THREAD, "fsl-msi-cascade", cascade_data); if (ret) { dev_err(&dev->dev, "failed to request_irq(%d), ret = %d\n",