| Message ID | 1389074690-21654-1-git-send-email-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Jan 7, 2014 at 4:04 AM, Alexander Shiyan <shc_work@mail.ru> wrote: > sound/soc/fsl/fsl_ssi.c: In function 'fsl_ssi_probe': > sound/soc/fsl/fsl_ssi.c:1180:6: warning: format '%d' expects argument > of type 'int', but argument 3 has type 'long int' [-Wformat=] > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> I have sent the same fix as well as I haven't seen your patch before I submitted mine. It is usually a good idea to specify in the commit log what was the commit that caused the warning. Regards, Fabio Estevam
On Tue, Jan 07, 2014 at 08:08:14AM -0200, Fabio Estevam wrote: > I have sent the same fix as well as I haven't seen your patch before I > submitted mine. I saw Fabio's patch first too.
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 3d74477a..c9d567c 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1192,7 +1192,7 @@ static int fsl_ssi_probe(struct platform_device *pdev) */ ssi_private->baudclk = devm_clk_get(&pdev->dev, "baud"); if (IS_ERR(ssi_private->baudclk)) - dev_warn(&pdev->dev, "could not get baud clock: %d\n", + dev_warn(&pdev->dev, "could not get baud clock: %ld\n", PTR_ERR(ssi_private->baudclk)); else clk_prepare_enable(ssi_private->baudclk);
sound/soc/fsl/fsl_ssi.c: In function 'fsl_ssi_probe': sound/soc/fsl/fsl_ssi.c:1180:6: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=] Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- sound/soc/fsl/fsl_ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)