From patchwork Mon Aug 5 09:13:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michel_D=C3=A4nzer?= X-Patchwork-Id: 264619 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 62D702C01FA for ; Mon, 5 Aug 2013 19:14:00 +1000 (EST) Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by ozlabs.org (Postfix) with ESMTP id 22CEA2C0091 for ; Mon, 5 Aug 2013 19:13:33 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by darkcity.gna.ch (Postfix) with ESMTP id EB67F5E066A; Mon, 5 Aug 2013 11:13:28 +0200 (CEST) X-Virus-Scanned: amavisd-new at gna.ch Received: from mail.gna.ch ([127.0.0.1]) by localhost (darkcity.gna.ch [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NzxLOzec7tZC; Mon, 5 Aug 2013 11:13:18 +0200 (CEST) Received: from thor (77-56-77-139.dclient.hispeed.ch [77.56.77.139]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by darkcity.gna.ch (Postfix) with ESMTPSA id 3EC685E0668; Mon, 5 Aug 2013 11:13:15 +0200 (CEST) Received: from daenzer by thor with local (Exim 4.80) (envelope-from ) id 1V6Gqn-0003I9-Pk; Mon, 05 Aug 2013 11:13:13 +0200 Message-ID: <1375693993.3852.143.camel@thor.local> Subject: Re: therm_pm72 units, interface From: Michel =?ISO-8859-1?Q?D=E4nzer?= To: Benjamin Herrenschmidt Date: Mon, 05 Aug 2013 11:13:13 +0200 In-Reply-To: <1375477360.15999.19.camel@pasglop> References: <1345066616.11751.2.camel@pasglop> <1358465885.2782.24.camel@pasglop> <20130719174300.GL14385@blackmetal.musicnaut.iki.fi> <1374275809.19894.562.camel@pasglop> <20130720203346.GM14385@blackmetal.musicnaut.iki.fi> <1375437816.3852.12.camel@thor.local> <1375447861.15999.1.camel@pasglop> <1375454871.3852.27.camel@thor.local> <20130802155818.GB29933@blackmetal.musicnaut.iki.fi> <1375462346.3852.42.camel@thor.local> <1375477360.15999.19.camel@pasglop> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAIAAADYYG7QAAAAA3NCSVQICAjb4U/gAAAQ4UlEQVRYw0VYWY9l51Vda+/vDHequjV1V5fbdsdud+wMNiQIEieAYggJQrwliChP/IBESCABApQXXiJ44AmFIZEQYcggBGRQgjMY2xkd20k7HuKxbcfd7u6qHurWveeec75vbx6+28l9qLp16+ieffa39tprLX73ew8KBXDSAVKcWH0AgHSSbolUuKuKm4vQ3QQ0wN2a+XJ+NE9uRVnUdTUYDEIRVMQ8CSUlFwUlOJwE+PMvFwnmPSW4g4SBhAeSABwgKJKvzbUALgLx5MIAJ8XgrqQ7xNH3/aWLl5954kevvPBCc3QkdADVoJ5u75w8fcddb3rzeG3swUUpJNwgN54QQgIQwoWBIBTJXATu4PcfedgJAQknkevLP8QBirsRoIi7CSkA3Pcv75/9waMvP/3D5tq12WIe+1grh1VdlMFFomPt+M1vvffdb777LWVdCggCAoqamWh+XiEEBEgKUzKnBEFwp9Dh5KpXLkIzqNLhQgcUcAGc7hDz9NTZZx7/1gMTn+2UaaZelVKURRmqqtRQlp07VEo7evbb35hdu/qOX393XVUE4TRzQX5qBeCrgyGdqmIGQAIAuELgjnxQgIDuvjptIQA3cxVNbg898K1nvvPAHbtTdOzatD4opoOiVK/KqirCaG2tKAoIowYtBq+/9sKDX0v3/dZ9RV1mlFJUAIcLxQAyAA6SLiIOUoQkSXchVxB2CEE6kHjjOUTEzO7/yjeefOjrp09MfDlLbaveB/ggYKA6VJaqhdtQdTocbw5H00F1961746uvPvx/30YyIUXy10Io7hAIQaEIFBRSCAoAuBEkHM4MZlLoIAWg5LY6Hnv8iR8/dP/p3fV+dhTnjS1btn3hzuR0c0AJ9QRLlmLhKBIk9Xfffitfe+aJs0/lOijiyDAlmPFOAHSTDPN8i DcKz5cpV sAWkoA4cP1o8ZXPfvbOvc14dGjLpZvDEgyanO6WzFK02EdLbpF9L9FosUyusfuVN9721IPfnDetO+EQkVwboZ7fkNRVhZLrzFMPSi4PP4MTCYo7vvbV+7fKmJpl6jrvk7VL7yM9OY1mcFif3JLQ3dxSsj6qQQUlvKL+6pmT337gwVVfcoucFBfJhESCuTUilAzgPJue+0XNv+Fw2LLtHnv4wa3JMHVdamOKfXIz693M3eAONxB0gUtMPRziroBCy1AVQW675ZbFT19q+w7IOCIodBFAREGKKKmihYDMaMr9IMUBd88VOkjKk2efRHsId3dz85Rg0dxgluhQUSFDCFrKDTiyKItStSrLIoSgGkRu354899RPCM1sTRdQHPl0BBBVctWtTFueSYoE84f5aneeffTRSVWbJbNkZpZSSp7MALo53OEUwJKZ0V3EUZeDajQejqflcCK5oL29nz7/PJCYh0aYMU0q4KICKEkxc+bVkSszECREqHSniKX0ysvn6ko9JYtmqTXv4UZ3i527OZmsB93czCNJKUqGUFQD1cpNybIsquM7W4eXX0/moIArlhFSKCIETOjIayWzZ54rSl4P7g4ICJqnZj4HxLqUkrnRzd2TuxuDOftlI4bYWWz6fhm7tusttrF3Q9u3Zn2Qoq7LqixGVbloGt5gEiFBdySuGJJCBgedEFlxMwCH5ZWVd5AQImyathfQIhCVZuZQws3MRWgulszFk6WUYqY7F9IjEothUBVLvarEaFy9QNLdQQeVcMBBFRH8fM4dkhG3+ptwuouDh/NFtOTu5m5mMLeU4ACSqGpwkjS49QTFpNSqDIVqIJUCcyy7pcPdMiYUcIeBVAmkk06lCkI+LHcnhRQn3V2EbuYramDqY7/s+hhFacnhdDfANJiaejIpClV4b4qyLqqyqkMRosElpC6xTaFPTdPBPKW0khQiApqbM/csn6OEn00WKHl3qKzaQ5BAij1h0ZMZWA gdbdelSL rXpU8qVWpMLEMJaFHWRV0b5ErTXbt+cH02h6fdvd0zRQmwj6ltlpmVCQepouaWqQiAQEP+F0TcXTOLi5tBiKxbihBABKWoGcPBvH3h/EHTxmgmkOPrg73p+JbN6fGqLJRSVbO2fe788+cuHrxw6UpKNl5bv3XvxFEf33p6T8xm164DRirFyXzTgiKEOOmwAHehAFCVjDJCiEQRcwc9xv74iROXFwdtTC/tX3n14j7cN0b1KGhK6fJi+dPrzROvHdxxfGNvOlo/6g7n8xcuHMySF2W1vTWZbmyyKr75g8d/cvHy+YOj3UUHz9J0tbvyATqzXNYAwgCVzISA0EGRwKzZkL7+ib87oX7txOn/+tZ3blmrd2p9w86kc57bn80W3bgI4zJR5aFXDw6fe70K5zTUd2xNNoZ6bv/SwjZ39/buuXm6vrXTDQstll/8ny/3DO99z6+IBDhE1AmHK0lRAAGrasA8+S5ZLJklkkfX5xcffmy+UcybdjocnNoebxR45vx+43KFcXO8VoTUDaxKthWxaGVrNFm63jnlYS1b1WRr+5atjZ0fP/n0+9+3c9OZWzfHo2m6vJdaoYCCGwSQ2VVUYRZWVGSmmr0HeMN/iEo7ayx5n+zEZOhmGwNtZ804lJuheNO4VtG2nx/2YkTTx3v3pu+9+64fXpzdfPP46Nr+PadOHNs5dfLmWyf3vBF+tDms9djOD2Yv3Bx7B4Kou2eSkczQ7tQQJA8XBciKLGPNQJr72rHtYjpp0tF6Odoc1l27qArubY/VfTQoDHZ9Xo47jx4Xi+7EbsH5/Hfe/uZnrl+9/bZNeDeuYqX9eDguq+3YxrW6Zruc3nOPqDqcsrrdyljkQXOHavFzYCFLFYqIiBR19YZ3v6vrenc7sTa80sThKKwPdH1SBvFAjCtZr8Nh47tVMQ4F4KdP3nRwMD99y6ntnd2yqFPbVtRRPST1/MX9O+9+G/aOU1aTT8mNCKD6yousTip rICeFEKy MgZB66z1vC0V1tOyqINPx+JWr/aJ3oUqKjMktvn61uXJtecfWNGhApC3iL9928pGnzy2OOkT3ZRvItomP/vjcg2dffst976EGkCICERFB3goiuQuBK02WF9dKOgoJg6g4bPPUyUlZvd4vTxB7kwqj8vpiefHKoo+W+j6ajUR/8dj6qAoErAhHzeLtd5y5vZm/ePnalXnbmPcv7++eOHbvPW/e3LhUHdtBXucU95Q1qQgMriLuHkiVrKhX2htZ0WZQiXJ999h0bf3FiwtDELSwtFUXLMWTxb7vu9g0XXAS0EokyKKZe4LNmjcd32EV6rre2pwOpkPUoYEmQVhNuGfKdhAOFRrFzYWkrXSIUERE6STgMFF1Z1nXv/7hPxhUdetwA+jwpMIqyGRQF0ShxfraqKpLDVKWhYtX6zvHdo9ffPEJj8u6KENQp6W+r/ZuFQaI4mfLC8x+zKFmiSri8NURZu39M5+vOR4Qh9z5a/fe93sfWiT2EHclWQhGw3I8KqN7VWoISdgLXYqCVR0qmW6uzR2vPvtji42KUEMX4/TkLdQsgtywet3Qm06quwupq5ETcYg7KJohZu4QEVGR8Bvv/+1T97w9EhZEhGUR1kaD2byJzoNF99z5w/3Dtuvb2DV1XXbN9SdeuDDYPnUwm13ZvxAtQtgVo/XphlDhTopAQMlGi5CsCAGIqzL3KacNupJzcMiKwYWUtcnaO+57bx8KA0BWg/ooxoN5bCAxBA5HvdSY7KSquLpsvvvi61cMcbRe7p7aP7zWdR2I4vjNogSNKzVPAAYacn4BZnVk5lDJ8tDzhQpD9q0qGekCkG8488ZivLlMSIAU+srVw0WhUaUIOhrodK0ajEbXW5y/cDASr4f1YDIcH9+dg4nJgDScEgTVfZUjuAgABx1w0ewVJfuerLCD0gkDBSKrMSPd8zIJQTd2tlu3nj6PfQJGtdZBx5VsBWxarK9e3jE/WQ+Hi6ObatsZcVjB y7CwuJCQ ilpECaoqqJbdq6uAvpJr6mAQFSaHkqBlYeCeFa+56w3la4a//fjHFy8+3QFL9858PCjaeXPhwrWjpq807G5Ox7PD2+utg6vXXnrsLL/av/Odd22d2vVi0GpZ1NullFmX3vDvArc82lmIZJcahGoSSXVCaO5Z2at5gmiyJEE8pm9+4xuf//znf/fuPQcWMc37SIiRO9PhWPoRdNpzfbTWnN/fvWn8C+96H0K/+YbRhfnRZDTRciAbe3mINcdg+TZcOUEnnQ6IkcHMszgzT8zJEGirCAZwofl8Mf+nf/yU0NWjptQmNH1kSgLWI6mrQdHrgPV0bTRd37rpzJmdk1vr28VRatdEytFY1jZlOAadDssbIbeKFEhyV1k5D8ICqEKYW/bzoMPd6Up6SqKFe/yHv//kc889PxHE2BfwWbSqNSWGdA0qoagnw3ptKuvjYmd9OYlhnS1SVQ62yzKMhmmyA5IQZyLFDCri5lTaKum4Mfb55CwHkRA43KAQz5GpiLs9+oNHP/eZz8W+u9YsZ4vWE2CYL1u49waTUBZS1QWFEdqhEC26GKMJNBRFdf1o8Wcf+/hsNltRn6W8KigkAwmKgBChAaToR/7wj7jyFyDFYdRspUH4lf2Dj37ko/uXL8W+7y0FTzujUhR974WIkNCiLosilCFUZV0X9WA8GpdlpWUZqmI0qT/zpa//5/3f+eHZpy+cvzCajLe2t8ifR2fM4ppiWZMRAUKBO1y1cO/pcGfs4z9/6p8e+NrX9g+uXLx0uU/R3Dzh3JXFzZujtcmwQVp2PcsikG1PuonEvk8p+qK1oQcxqSl9133+qw+2XfvkE0++duHg3//jv7e2Nn7p7W/74Ic/cNebzjhcyGROWE6IzBFyikjRZL2QIprMvvTFL3zyHz7VxzYl6/su5x4OO+z9tSvz4aiaDMuj2aISSeqi7rFTXTMD3QpBKZiUoRZ5+Pvfvz5bWLTr1w8m02NdTK++cv7Sp Sv3f/2Bu +++6/c/9IF3vPtdVV0QSO4KcXiwlFTVk4lmt8p/+/SnP/mPn4opdV2fUkwe3SzHLga8etgca/pj0/Hm1sbi6mxcRorS03BUhOCVaqU2FPPYxSg/eubZSSlXlwmxn82uDieb7bKZzWdVGn7/kbNnzz512+nTH/rwB99z371VXUcqYMHNI+yHj3z3K1/+39GwSo4vffGLTdu1fRdjTDGCbnYjBXK/PLeXLs2H9WBnOtw4td5cOwxFWaggxWIyLMehje2Vo6vbw2Pi6fVLV+uqNGshaXZ4MFjfVq1iarq2CyEk92efe/lv/voTn/vsF/74Tz9y111nSA2f/pd//eb997/08mvNcpH6hcOA4EDOVZO1pDt89YI7+OyluUgYVtX62vro5LA5nIdRbZMq1brUuL6xuXvTyXE5OvuTp4+aJcHkJimmrl8eHRpAwLyPTk3edi0Rn3+x+4s//6u//NifvPWtd+rzz796+eBa1/du0VIf+xhj6ykC4jRHMour9BG+0kvCwyYt2+7EzsZ0czslmnUbmxvbx3Z3Nrd2t4/VRd3G+O3Hzr547qf7h83BoiVA5XA0bRZzZ3AIGcwsizEnLaazTzzznt98l9bVQOgxdU5xS33qzTylZN4TVAkp9Vni3khtoFIk2MFRdzjvN0eD8cba4eHcGSbj8aCszdk2yz76Q9979PLB5deuzWZdDwIS6uG076NZ1KKAKCGgrFhQ1ZJtbW+phCKH9zAC5ta7mbmZJbecS7ibZb9yI8jOKZPPW7x08WqAp4QY0+bGtlKuH82t96Nm+cjjjzfN/MXLh52tAph6OK3qsu/asqwo4sx+i1AJImVVDMbr/w/Q9qYPnQtQagAAAABJRU5ErkJggg== X-Mailer: Evolution 3.8.2-1.0 Mime-Version: 1.0 Cc: Ben Hutchings , linuxppc-dev X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sam, 2013-08-03 at 07:02 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2013-08-02 at 18:52 +0200, Michel Dänzer wrote: > > > Thanks for the suggestion. The same windfarm modules were loaded in both > > cases, but i2c_powermac wasn't loaded with the newer kernels. Loading it > > manually fixes the problem. > > > > How is i2c_powermac supposed to get loaded with current kernels? > > It's a platform driver, but it's missing a module device-table > > Can you try this completely untested patch ? > > diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c > index 8dc90da..5af5153 100644 > --- a/drivers/i2c/busses/i2c-powermac.c > +++ b/drivers/i2c/busses/i2c-powermac.c > @@ -458,9 +458,15 @@ static int i2c_powermac_probe(struct platform_device *dev) > return rc; > } > > +static const struct platform_device_id i2c_powermac_id = { > + .name = "i2c-powermac" > +}; > +MODULE_DEVICE_TABLE(platform, i2c_powermac_id); > + > static struct platform_driver i2c_powermac_driver = { > .probe = i2c_powermac_probe, > .remove = i2c_powermac_remove, > + .id_table = *i2c_powermac_id, This fails to build: CC [M] drivers/i2c/busses/i2c-powermac.o drivers/i2c/busses/i2c-powermac.c:469:14: error: invalid type argument of unary ‘*’ (have ‘const struct platform_device_id’) make[1]: *** [drivers/i2c/busses/i2c-powermac.o] Error 1 The version below builds, but the module still doesn't get loaded automagically (unless I'm missing some command I need to run between copying the new module to /lib/modules/$(uname -r)/ and rebooting?). Looking at other drivers in drivers/i2c/busses/, maybe i2c_powermac_driver.driver needs an of_match_table entry? .bus = &platform_bus_type, @@ -468,5 +478,3 @@ static struct platform_driver i2c_powermac_driver = { }; module_platform_driver(i2c_powermac_driver); - -MODULE_ALIAS("platform:i2c-powermac"); diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c index 8dc90da..74066fc 100644 --- a/drivers/i2c/busses/i2c-powermac.c +++ b/drivers/i2c/busses/i2c-powermac.c @@ -458,9 +458,19 @@ static int i2c_powermac_probe(struct platform_device *dev) return rc; } +static const struct platform_device_id i2c_powermac_id[] = { + { + .name = "i2c-powermac" + }, { + /* sentinel */ + } +}; +MODULE_DEVICE_TABLE(platform, i2c_powermac_id); + static struct platform_driver i2c_powermac_driver = { .probe = i2c_powermac_probe, .remove = i2c_powermac_remove, + .id_table = i2c_powermac_id, .driver = { .name = "i2c-powermac",