| Message ID | 1355914716-19469-1-git-send-email-grant.likely@secretlab.ca (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On 12/19/2012 03:58 AM, Grant Likely wrote: > Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" > renamed of_find_matching_node() to of_find_matching_node_and_match() and > created a new static inline of_find_matching_node() wrapper around the > new name. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. Oops. The patch is obviously correct, Reviewed-by: Stephen Warren <swarren@nvidia.com> I guess none of the ARM defconfigs enable any module that uses this, since I have built all of them multiple times recently:-(
diff --git a/drivers/of/base.c b/drivers/of/base.c index db8d211..2390ddb 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -629,7 +629,7 @@ struct device_node *of_find_matching_node_and_match(struct device_node *from, read_unlock(&devtree_lock); return np; } -EXPORT_SYMBOL(of_find_matching_node); +EXPORT_SYMBOL(of_find_matching_node_and_match); /** * of_modalias_node - Lookup appropriate modalias for a device node
Commit 50c8af4cf9, "of: introduce for_each_matching_node_and_match()" renamed of_find_matching_node() to of_find_matching_node_and_match() and created a new static inline of_find_matching_node() wrapper around the new name. However, the change neglected to change the EXPORT_SYMBOL() reference causing build errors for modules. This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC Efika build with the mpc52xx_uart driver being built as a module. Reported-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Grant Likely <grant.likely@secretlab.ca> Cc: Stephen Warren <swarren@nvidia.com> Cc: Rob Herring <rob.herring@calxeda.com> Cc: Anatolij Gustschin <agust@denx.de> --- I'll push this patch out to my tree ASAP. drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)