Message ID | 1323289096-13599-1-git-send-email-jslaby@suse.cz (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Kumar Gala |
Headers | show |
On Wed, Dec 07, 2011 at 09:18:16PM +0100, Jiri Slaby wrote: > When spi_fsl_espi is chosen to be built as a module, there is a build > error because we test only CONFIG_SPI_FSL_ESPI in declaration of > struct mpc8xxx_spi in drivers/spi/spi_fsl_lib.h. Also some called > functions are not exported. > > So we forbid CONFIG_SPI_FSL_ESPI to be tristate here. > > The error looks like: > drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_bufs': > drivers/spi/spi_fsl_espi.c:232: error: 'struct mpc8xxx_spi' has no member named 'len' > ... > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Acked-by: Kumar Gala <galak@kernel.crashing.org> > Cc: Grant Likely <grant.likely@secretlab.ca> > --- > Maybe Grant is back already? I just picked it up in the for-linus branch I am preparing while Grant is away.
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 9c90a7a..3d292be 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -198,7 +198,7 @@ config SPI_FSL_LIB depends on FSL_SOC config SPI_FSL_SPI - tristate "Freescale SPI controller" + bool "Freescale SPI controller" depends on FSL_SOC select SPI_FSL_LIB help @@ -207,7 +207,7 @@ config SPI_FSL_SPI MPC8569 uses the controller in QE mode, MPC8610 in cpu mode. config SPI_FSL_ESPI - tristate "Freescale eSPI controller" + bool "Freescale eSPI controller" depends on FSL_SOC select SPI_FSL_LIB help