From patchwork Sat Nov 12 23:50:30 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 125371 X-Patchwork-Delegate: galak@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 1B72CB74BF for ; Sun, 13 Nov 2011 10:50:55 +1100 (EST) Received: from smtp-out3.tiscali.nl (smtp-out3.tiscali.nl [195.241.79.178]) by ozlabs.org (Postfix) with ESMTP id 2DA61B71E2 for ; Sun, 13 Nov 2011 10:50:45 +1100 (EST) Received: from [212.123.169.34] (helo=[192.168.1.100]) by smtp-out3.tiscali.nl with esmtp (Exim) (envelope-from ) id 1RPNLN-0002sT-Kd; Sun, 13 Nov 2011 00:50:41 +0100 Subject: [PATCH] powerpc/p3060qds: Fix select of 'MPC8xxx_GPIO' From: Paul Bolle To: Shengzhou Liu , Wolfram Sang Date: Sun, 13 Nov 2011 00:50:30 +0100 Message-ID: <1321141830.20271.22.camel@x61.thuisdomein> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Cc: Anatolij Gustschin , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org The driver for the Freescale P3060 QDS got added by commit 96cc017c5b ("[...] Add support for P3060QDS board"). Its Kconfig entry selects MPC8xxx_GPIO. But at the time that driver got added MPC8xxx_GPIO was already renamed to GPIO_MPC8XXX, by commit c68308dd50c ("gpio: move mpc8xxx/512x gpio driver to drivers/gpio"). So make this driver select GPIO_MPC8XXX. Signed-off-by: Paul Bolle Acked-by: Wolfram Sang --- 0) Bravely untested: I haven't got the hardware nor the PPC toolchain needed to build this. And it seems this needs (build) testing anyhow. 1) Sent to the people who wrote the two patches mentioned in the commit explanation and CC'd the non-authors who signed-off these patches. 2) The config tools do not complain about selects that cannot be met because they concern a Kconfig symbol that doesn't even exist. Shouldn't they be made to complain in that case? arch/powerpc/platforms/85xx/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 45023e2..d7946be 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig @@ -203,7 +203,7 @@ config P3060_QDS select PPC_E500MC select PHYS_64BIT select SWIOTLB - select MPC8xxx_GPIO + select GPIO_MPC8XXX select HAS_RAPIDIO select PPC_EPAPR_HV_PIC help