From patchwork Tue Nov 24 16:48:31 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Tyser X-Patchwork-Id: 39209 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 33CD010085B for ; Wed, 25 Nov 2009 03:48:58 +1100 (EST) Received: by ozlabs.org (Postfix) id 85E25B6F05; Wed, 25 Nov 2009 03:48:43 +1100 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from xes-mad.com (xes-mad.com [216.165.139.218]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F228B1007D3 for ; Wed, 25 Nov 2009 03:48:42 +1100 (EST) Received: from [10.52.0.62] (petert.xes-mad.com [10.52.0.62]) by xes-mad.com (8.13.8/8.13.8) with ESMTP id nAOGmWIt008095; Tue, 24 Nov 2009 10:48:32 -0600 Subject: Re: [PATCH 2/3] powerpc: Add support for creating FIT uImages From: Peter Tyser To: Stefano Babic In-Reply-To: <4B0BB654.9030604@denx.de> References: <4B0BB654.9030604@denx.de> Date: Tue, 24 Nov 2009 10:48:31 -0600 Message-ID: <1259081311.23828.5372.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-Virus-Scanned: ClamAV 0.94.2/10063/Mon Nov 23 23:14:37 2009 on mail.xes-mad.com X-Virus-Status: Clean X-Spam-Status: No, score=-6.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, XES_TECH_LINUX autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mail.xes-mad.com Cc: linuxppc-dev , linux-kbuild@vger.kernel.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Hi Stefano, Thanks for trying the patches out. On Tue, 2009-11-24 at 11:32 +0100, Stefano Babic wrote: > Peter Tyser > +uboot.fit) > > + rm -f "$ofile" > > + ${MKITS} -A ppc -C gzip -a $membase -e $membase -v $version \ > > + -d "$srctree/$dtb" -k "$srctree/$vmz" -o "$object/uImage.its" > > + ${MKIMAGE} -f "$object/uImage.its" "$ofile" > > Hi, > > I have tested your patches against last mkimage utility provided with > u-boot. The utility requires to pass the type of the image (flat_dt), > even if this is not mentioned in the help output. Without the image type > parameter, no image is generated, and no error is reported. > It should be: > > ${MKIMAGE} -f "$object/uImage.its" - T flat_dt "$ofile" Argh, I'm seeing the same behavior with the latest mkimage source too. It looks like there was a regression in the mkimage utility - the "-T" option shouldn't be necessary to create a FIT image. I'll send a patch to U-Boot to fix this behavior. > I have tried to get an image for the lite5200b board, because I have the > possibility to test the result on the target. However, dtc fails to > compile the its generated by your script (Version: DTC 1.2.0-g0ef21055, > cloned from jdt). I did my testing using the dtc in the linux kernel source (scripts/dtc/dtc, version 1.2.0) and version 1.2.0-rc1. I see the same error as you when using version 1.2.0-g0ef21055. > DTC: dts->dtb on file "arch/powerpc/boot/uImage.its" > Error: arch/powerpc/boot/uImage.its 1:0 syntax error > > Do you test in different conditions ? Applying the following change should resolve the dtc syntax error. I'll wait a few more days for feedback then resubmit with the dts syntax fix Thanks for testing, Peter diff --git a/scripts/mkits.sh b/scripts/mkits.sh index 88411dd..75edc27 100755 --- a/scripts/mkits.sh +++ b/scripts/mkits.sh @@ -64,7 +64,9 @@ ENTRY_ADDR=`echo $ENTRY_ADDR | sed 's/0x//'` RAMFS_ADDR=`echo $RAMFS_ADDR | sed 's/0x//'` # Create a default, fully populated DTS file -DATA="/ { +DATA="/dts-v1/; + +/ { description = \"Linux kernel ${VERSION}\"; #address-cells = <1>;