From patchwork Thu Oct 15 06:41:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vishnu Suresh X-Patchwork-Id: 36066 X-Patchwork-Delegate: galak@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bilbo.ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 295D6B7DCC for ; Thu, 15 Oct 2009 17:49:00 +1100 (EST) Received: by ozlabs.org (Postfix) id 32DF6B7B76; Thu, 15 Oct 2009 17:48:53 +1100 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from az33egw02.freescale.net (az33egw02.freescale.net [192.88.158.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "az33egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id B8BA0B7B68 for ; Thu, 15 Oct 2009 17:48:52 +1100 (EST) Received: from az33smr01.freescale.net (az33smr01.freescale.net [10.64.34.199]) by az33egw02.freescale.net (8.14.3/az33egw02) with ESMTP id n9F6fBBZ011427; Wed, 14 Oct 2009 23:41:15 -0700 (MST) Received: from lc1105.zin33.ap.freescale.net (lc1105.zin33.ap.freescale.net [10.232.3.105]) by az33smr01.freescale.net (8.13.1/8.13.0) with ESMTP id n9F6hfCl000320; Thu, 15 Oct 2009 01:43:42 -0500 (CDT) Received: by lc1105.zin33.ap.freescale.net (Postfix, from userid 4688) id 083C328061; Thu, 15 Oct 2009 12:11:09 +0530 (IST) From: Vishnu Suresh To: linuxppc-dev@ozlabs.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, herbert@gondor.apana.org.au, dan.j.williams@intel.com Subject: [PATCH v0 1/2] DMA: fsldma: Disable DMA_INTERRUPT when Async_tx enabled Date: Thu, 15 Oct 2009 12:11:05 +0530 Message-Id: <1255588866-4133-1-git-send-email-Vishnu@freescale.com> X-Mailer: git-send-email 1.6.4.2 X-Brightmail-Tracker: AAAAAQAAAWE= Cc: Vishnu Suresh X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org This patch disables the use of DMA_INTERRUPT capability with Async_tx The fsldma produces a null transfer with DMA_INTERRUPT capability when used with Async_tx. When RAID devices queue a transaction via Async_tx, this results in a hang. Signed-off-by: Vishnu Suresh --- drivers/dma/fsldma.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 296f9e7..66d9b39 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1200,7 +1200,13 @@ static int __devinit of_fsl_dma_probe(struct of_device *dev, - fdev->reg.start + 1); dma_cap_set(DMA_MEMCPY, fdev->common.cap_mask); +#ifndef CONFIG_ASYNC_CORE + /* + * The DMA_INTERRUPT async_tx is a NULL transfer, which will + * triger a PE interrupt. + */ dma_cap_set(DMA_INTERRUPT, fdev->common.cap_mask); +#endif dma_cap_set(DMA_SLAVE, fdev->common.cap_mask); fdev->common.device_alloc_chan_resources = fsl_dma_alloc_chan_resources; fdev->common.device_free_chan_resources = fsl_dma_free_chan_resources;