From patchwork Mon Oct 20 23:13:38 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 5155 X-Patchwork-Delegate: benh@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 8F64CDDF32 for ; Tue, 21 Oct 2008 10:13:59 +1100 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C6CC4DDDF3 for ; Tue, 21 Oct 2008 10:13:45 +1100 (EST) Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id m9KNDesC005030 for ; Mon, 20 Oct 2008 18:13:41 -0500 Subject: [Fwd: [PATCH] fix WARN() for PPC] From: Benjamin Herrenschmidt To: linuxppc-dev list Date: Tue, 21 Oct 2008 10:13:38 +1100 Message-Id: <1224544418.7654.182.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org -------- Forwarded Message -------- From: Arjan van de Ven To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, johannes@sipsolutions.net, davem@davemloft.net, Benjamin Herrenschmidt Subject: [PATCH] fix WARN() for PPC Date: Mon, 20 Oct 2008 14:50:56 -0700 From: Arjan van de Ven Date: Mon, 20 Oct 2008 14:41:03 -0700 Subject: [PATCH] fix WARN() for PPC powerpc doesn't use the generic WARN_ON infrastructure. The newly introduced WARN() as a result didn't print the message, this patch adds the printk for this specific case. Signed-off-by: Arjan van de Ven --- include/asm-generic/bug.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h index 0f6dabd..12c07c1 100644 --- a/include/asm-generic/bug.h +++ b/include/asm-generic/bug.h @@ -41,7 +41,7 @@ extern void warn_slowpath(const char *file, const int line, #define __WARN() warn_on_slowpath(__FILE__, __LINE__) #define __WARN_printf(arg...) warn_slowpath(__FILE__, __LINE__, arg) #else -#define __WARN_printf(arg...) __WARN() +#define __WARN_printf(arg...) do { printk(arg); __WARN(); } while (0) #endif #ifndef WARN_ON