From patchwork Wed Jul 10 23:00:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 1959056 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=XWIf/dRa; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WKCzz6vPsz1xqr for ; Thu, 11 Jul 2024 09:02:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=XWIf/dRa; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WKCzx6ccWz3cDT for ; Thu, 11 Jul 2024 09:02:21 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.a=rsa-sha256 header.s=selector2 header.b=XWIf/dRa; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=permerror (SPF Permanent Error: Void lookup limit of 2 exceeded) smtp.mailfrom=nxp.com (client-ip=2a01:111:f403:c200::4; helo=duzpr83cu001.outbound.protection.outlook.com; envelope-from=vladimir.oltean@nxp.com; receiver=lists.ozlabs.org) Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazlp170130004.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WKCzg2dW0z3bvP for ; Thu, 11 Jul 2024 09:02:05 +1000 (AEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mwP1bcCFIuZghxwAUUb09y3FHN3AOFz7mGyKyLzakdws04vV4jmRwPDcozSp7dNr6Kg0SYR0MbGd+kMMuMnf8Ez1xWakPDxamOfc3T5xb2fTwPEmMoXtrg9BWn97Ui+beWbXmp3To3ujVr47/2hPyQOIDLSeD50lVTcfZnanQaVd22NrxdZCBfaoGdjoUXp7ZDHCGbuhiffYzNJLo42V2pdX/zNgIo2VRpUCznGXhFyLpRS13HaJ2JRAeSsvAti4pjWRbYXg2AwFy+RQb0zxFg6+EOUi4pCLX/ywdBB0shEdU78vKdBPP/DjWQodwV6NfgTha+khtFTK3wTxaO6bhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pk+GJCK6kik4BdwnnzD7CLokkHR91RIg/sSyr6Oq4j0=; b=fX1U8LYY70Y9atIKLBm9O5rTm8374TSc6uoPLgBuhjgqNRKqV0ihK8tLdotghRfFLuSXT4hb7zZTXxqmpRIoO+VbK3ssMnglh95kulvtGYEEXkkZgqSGHNn5RxwNXlIzHoNAWP66NGs+xF72XG/XAWNcbcl8n3dUj/YbRpiFSXwn1aJmP6s+zr5I7qnSvU/JocwQ/PI/8hyurt3Ays+U9ZkU71CUKPOGWvNOjjJMhCup48afSPuG6+vKtv04DylydPIibVC87Ov1C3h9LZUQkWd8/VCwuT+WsW1f3SZwGcaUtIaFMAqh/Un0M5Q7sCW2WRdoxDyPIHmSG24Zsx0pQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pk+GJCK6kik4BdwnnzD7CLokkHR91RIg/sSyr6Oq4j0=; b=XWIf/dRazsDXCUCeRAwCQLXJqbWNbu/6rNz2I3wlZkO9UdhlT1W2/IxvP3xmX0sEWPtIyfj5/Pyu5HbxXy/MkFqvlQ4Iwo84P/ni0O//tQHYTFhUDOLk9bhVaod9/OGLuT65Zqz/lCdfcwNKwUyeoXcR3PJFiTRB4E7ERsJUkJk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB7PR04MB4555.eurprd04.prod.outlook.com (2603:10a6:5:33::26) by AM8PR04MB7425.eurprd04.prod.outlook.com (2603:10a6:20b:1d6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.20; Wed, 10 Jul 2024 23:01:34 +0000 Received: from DB7PR04MB4555.eurprd04.prod.outlook.com ([fe80::86ff:def:c14a:a72a]) by DB7PR04MB4555.eurprd04.prod.outlook.com ([fe80::86ff:def:c14a:a72a%4]) with mapi id 15.20.7741.017; Wed, 10 Jul 2024 23:01:33 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Subject: [PATCH net-next 0/5] Eliminate CONFIG_NR_CPUS dependency in dpaa-eth and enable COMPILE_TEST in fsl_qbman Date: Thu, 11 Jul 2024 02:00:20 +0300 Message-Id: <20240710230025.46487-1-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: VI1PR0102CA0100.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::41) To DB7PR04MB4555.eurprd04.prod.outlook.com (2603:10a6:5:33::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR04MB4555:EE_|AM8PR04MB7425:EE_ X-MS-Office365-Filtering-Correlation-Id: 901dfb6b-5294-4d83-560f-08dca1343dfb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: 6ciq3V3POKUb5L1Art1C2bPHWWr9HPQ8Is1oLu60h4gpP96Fz/BShPEqxbeRkSHPpHopX1/xDtZJNe4CyktKPLsxOuEd3AlzZfzG56OF7Olrk5rQ4DJJFG6NJB5F+7afsUoCnJwDmGAOUxIrLU/thQfrP3V0jQwWGrtMSNPtl6LMtKB2fFRHd8X4LLh46bfOSiW1OH9QZJUPIwkaX3h6sP0m2mo0UfjhrDWY/+kyDh6I8pu/GEkG9qhNjs8tW+87L8OTaafktzWLaiF5+AGW/e8gqj+8oraVnK6b0DY+wZ/0foapoUdHvs6kgOo7cTRn2MLLXqkw7SV29iRUubeJUwk3uG7Uu0sG4HwchzVFNXx4nyvcpRBn59qYhwH1hTZ95DmHT53R83r25COGhZwu4fgIdH1TKcPbgAmqtv0vdd5kBD+Su/3t3IF9OyqLPyokLrrlSl3zI6AGBccJObE6ys1X/XtLlo4yFz95RV7vZebjpM0EEvv9W94Qti0z1JixiuMtBHJgfyBGDgpTa6RU0Hff2/oj0YM/MkQ0FCwTSw3PD35+s4tJJZCL/gw3QJ+CbpfwcRomcv9w+po3ctNYpR29sm5avbmunvZiMKlBvB28L61JRDZqHoz0e/VYw8yHE2fXwrTibqCLkFkZwaC0WvO+64TjR7+abTNFa1+eFQ3ISKfq05h0FycqSFzR+UIiqIYxNLzBYgwOjbCPLWuB+YmzUlCyr9wLqCI2kM0ypfp7yqUwnPYIfQoigfVrsfV0i+/liUzsSpVChhIf+u774BMRg/4lq3U/c0NUT51UY1VcC2IPYwGBJx0LwRWsnYM+AWAaas1Ou8t+3XBxZU5/RK0f3ZeAvFO3KjMx5urCSUSBj+oVG6WK8KxVwiEwXLX6/uStu9AvcN74U9iZbGftQLIvLNmgQ6ZHaHC/e767cGotr6+hOIvIMGSK30zAIsB+kHDzIAWNb8WxA52/dUc0r+gc19C3+sWNkWi7kAvMIrfLAds1woKGv3WGi5ZoAQ/PoYTl6oYx8Ei0rltBmwI5ohrfewMW+nGC6Ri5yJ/M17AfujL1C2MJmgpphreDFfyahILSWni0nJkqDk0eWUNoqWuxsn1RtQZJJL+E3YTvjICkKas3I7hOlORnlJumh1lBgbEDkPe5TN8I8uU2is+LIWIbMzC5/6zU943DkgE6PpY83G8SH+DUYuTo6EAaJ+rEXhUTXon6AsLBz1cFWP7u6oTSmMPvYRV2pzcKouBsufuqrhnjH5nIjxyLYU478fVEEXool1rdTjV6aei05meSiEranDZ7SjVmfzzMvqvLhRp9mjC+VMWjtu5XIIeu3I4qbTayOdkneSG67XS6ppSgQ8GraKR6FBTQUlxuMUhINk0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR04MB4555.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: P6p99Ch5Zp4vFPclauYAfcn3O8qHMxpiRMahPBpoWfplQy8WrDFZIdKgZuGh13eyuPnLIMB5UPBsc6LYbwPwE361vbRgJcrbvzqoRTf+qm/K5bMeNihxRFW1/HUEY4SEaoW+/0jy77e339LhcgtlhbtTeVS9OPjSTFB/xsKrHHZdTplnIs4t9lVeEJGiZFMSGnmYzPm+8Azf4uZDg+z85HgbT90LfhsMaFBCJwIfdIRsTe/3yQaI5O89thOYZg/7zh+5jgeTTS4yqPlI+n5K3B68sLHcLPLNR5C8lx4hSjdv70IsfadD4dJM9lI3natC7zhFUv0ZaLOO/LejhvvaCusE/o50D7H4+lzIBvPKdm3kRPcjDTFt356U9f42kQoOwR0Q3AKkFMmJ7s8/GAMUl9erGvXO2+TyRDLHhmBY1MNl2w0PGHoNlgXTNIOwtKvd2NDJZ0Gl4uNP37Pi71jZFV+NZGUw+7kxtd4zluOpO/H64LJMre4FYTKxWqhgHpNtTjeRka+rBh5FsDzgHkywSHb1uuR8bWX6lxq0RSVciN0k/s3ZMQN1A8nUXro13ULwB9GKd+9WxW7VLVMkUP0F2iGwYlcv2xcwnOp9xqAGqkEosDCS3trYFBp3r2EyOpFLWllGScSydFRogZ4EL3KV41xFKMWRFlwtNoEU+SXxJHUc4Q0ZKr+4CG8KsNAWsa9phFqazXm4nu6NMEn7g00lk2VvCKYfud9FgesZ9a9ejU7b3t/5HC7GA+0u1RVsJmYpBP0CHk3fLv1fNRpNxEwHZuagghDZMCY7LAztLef6C1LGbicOrnNfv28c1EQ0+xQ3aHieFouPIueCWBqxPjrTPAitz2ooXQjA65YmM0HGZ51E8X4ZTiriqt4GFywxdA0pzuot2cV7Or9fuCRef/6n6fqVtdU5//f/4KPK9Y368CQCtsU5xkc+ZGdE01+b3ii+oLUAQwEg7NJAT4i+ESDwfd8QqeEH0XeewUm78KYNHiYYKCXWB9tHIUnSQpdjj7iRl4ATBRItxRTgow5H9I0/yBblrf4snERzP0CbwX/LjlZ4mIMTBbzinnKncHibupE23Z60ayf1sUQOopbpzASrt6T7g0HwZe9cR5mPbVqaIBgo+KnsqorIz9Vdx98tY4UqaiaC2v6sJkJeYXH3Z8H79l2I7F77eETiTSoBGTqOOSjOoBvVfpckmzUETIBWlg83qZvHlQacsZM5RxtZRcxVgqbpecxmGFG+bEf89DBz+q73HPg9rAT+8OnjGymMDnX4fIJrrm2iB86NTxUjNIw3XaE2amw2vVg4dzev5Ef90+TtRXXagywVbZ+P6Upv4BhgV/+D5p2g9erk4j0TRQg8mgOkQ/d7TFD2y31VrZbO529ikqp8DOO11UyZ/h5RFSoes3CzYj7cHFZ+XtVR0EXK5Bpzv9D6+Hs/+0aNBQEvaHvH8IUhxX93XWhYA+0VGCc9+6b2gULaIVXZ7be5+qzgWnY5Oxdl5M2gLIiR0YJjdQ8LDQOsqZ3oloe/XBToXr9/zANR/OVIJZKBdjK9jCuL3+yy4b6WvRqd7ZrvsIK4LyE8xBXlCbrsy3mKmi/m6ssNDUPtCoWlHuInjVuYH8QdWw== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 901dfb6b-5294-4d83-560f-08dca1343dfb X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB4555.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2024 23:01:33.1722 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FqIttbvSmA6/bAAHOXzAl9GfP60OcO2+02/IYfc7uRkTc7MXRT3cwdgcDlwsAzDDF4TMm0p4TE4KOlGSO2HZUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7425 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Madalin Bucur , linux-kernel@vger.kernel.org, Eric Dumazet , Breno Leitao , Jakub Kicinski , Paolo Abeni , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" Breno's previous attempt at enabling COMPILE_TEST for the fsl_qbman driver (now included here as patch 5/5) triggered compilation warnings for large CONFIG_NR_CPUS values: https://lore.kernel.org/all/202406261920.l5pzM1rj-lkp@intel.com/ Patch 1/5 switches two NR_CPUS arrays in the dpaa-eth driver to dynamic allocation to avoid that warning. There is more NR_CPUS usage in the fsl-qbman driver, but that looks relatively harmless and I couldn't find a good reason to change it. I noticed, while testing, that the driver doesn't actually work properly with high CONFIG_NR_CPUS values, and patch 2/5 addresses that. During code analysis, I have identified two places which treat conditions that can never happen. Patches 4/5 and 5/5 simplify the probing code - dpaa_fq_setup() - just a little bit. Finally we have at 5/5 the patch that triggered all of this. There is an okay from Herbert to take it via netdev, despite it being on soc/qbman: https://lore.kernel.org/all/Zns%2FeVVBc7pdv0yM@gondor.apana.org.au/ Breno Leitao (1): soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST Vladimir Oltean (4): net: dpaa: avoid on-stack arrays of NR_CPUS elements net: dpaa: eliminate NR_CPUS dependency in egress_fqs[] and conf_fqs[] net: dpaa: stop ignoring TX queues past the number of CPUs net: dpaa: no need to make sure all CPUs receive a corresponding Tx queue .../net/ethernet/freescale/dpaa/dpaa_eth.c | 72 +++++++++++-------- .../net/ethernet/freescale/dpaa/dpaa_eth.h | 20 ++++-- .../ethernet/freescale/dpaa/dpaa_ethtool.c | 10 ++- drivers/soc/fsl/qbman/Kconfig | 2 +- 4 files changed, 65 insertions(+), 39 deletions(-) Acked-by: Madalin Bucur