| Message ID | 20240412092047.455483-1-sshegde@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | powerpc/pseries: Fixes for lparstat boot reports | expand |
On 4/12/24 2:50 PM, Shrikanth Hegde wrote: > Currently lparstat reports which shows since LPAR boot are wrong for > some fields. There is a need for storing the PIC(Pool Idle Count) at > boot for accurate reporting. PATCH 1 Does that. > > While there, it was noticed that hcall return value is long and both > h_get_ppp and h_get_mpp could set the uninitialized values if the hcall > fails. PATCH 2 does that. > > v1 -> v2: > - Nathan pointed out the issues surrounding the h_pic call. Addressed > those. > - Added a pr_debug if h_pic fails during lparcfg_init > - If h_pic fails while reading lparcfg, related files are not exported. > - Added failure checks for h_get_mpp, h_get_ppp calls as well. > > v1: https://lore.kernel.org/all/20240405101340.149171-1-sshegde@linux.ibm.com/ > > Shrikanth Hegde (2): > powerpc/pseries: Add pool idle time at LPAR boot > powerpc/pseries: Add fail related checks for h_get_mpp and h_get_ppp > > arch/powerpc/include/asm/hvcall.h | 2 +- > arch/powerpc/platforms/pseries/lpar.c | 6 ++-- > arch/powerpc/platforms/pseries/lparcfg.c | 45 +++++++++++++++++------- > 3 files changed, 37 insertions(+), 16 deletions(-) > > -- > 2.39.3 > Ping. Michael, Nathan, Naveen Any comments on these patches?
Shrikanth Hegde <sshegde@linux.ibm.com> writes: > On 4/12/24 2:50 PM, Shrikanth Hegde wrote: >> Currently lparstat reports which shows since LPAR boot are wrong for >> some fields. There is a need for storing the PIC(Pool Idle Count) at >> boot for accurate reporting. PATCH 1 Does that. >> >> While there, it was noticed that hcall return value is long and both >> h_get_ppp and h_get_mpp could set the uninitialized values if the hcall >> fails. PATCH 2 does that. >> >> v1 -> v2: >> - Nathan pointed out the issues surrounding the h_pic call. Addressed >> those. >> - Added a pr_debug if h_pic fails during lparcfg_init >> - If h_pic fails while reading lparcfg, related files are not exported. >> - Added failure checks for h_get_mpp, h_get_ppp calls as well. >> >> v1: https://lore.kernel.org/all/20240405101340.149171-1-sshegde@linux.ibm.com/ >> >> Shrikanth Hegde (2): >> powerpc/pseries: Add pool idle time at LPAR boot >> powerpc/pseries: Add fail related checks for h_get_mpp and h_get_ppp >> >> arch/powerpc/include/asm/hvcall.h | 2 +- >> arch/powerpc/platforms/pseries/lpar.c | 6 ++-- >> arch/powerpc/platforms/pseries/lparcfg.c | 45 +++++++++++++++++------- >> 3 files changed, 37 insertions(+), 16 deletions(-) >> >> -- >> 2.39.3 >> > > Ping. > > Michael, Nathan, Naveen > Any comments on these patches? Looks fine. I have it in next-test, will probably go into next tomorrow. cheers
On Fri, 12 Apr 2024 14:50:45 +0530, Shrikanth Hegde wrote: > Currently lparstat reports which shows since LPAR boot are wrong for > some fields. There is a need for storing the PIC(Pool Idle Count) at > boot for accurate reporting. PATCH 1 Does that. > > While there, it was noticed that hcall return value is long and both > h_get_ppp and h_get_mpp could set the uninitialized values if the hcall > fails. PATCH 2 does that. > > [...] Applied to powerpc/next. [1/2] powerpc/pseries: Add pool idle time at LPAR boot https://git.kernel.org/powerpc/c/9c74ecfd0fc46e2eaf92c1b6169cc0c8a87f1dc2 [2/2] powerpc/pseries: Add failure related checks for h_get_mpp and h_get_ppp https://git.kernel.org/powerpc/c/6d4341638516bf97b9a34947e0bd95035a8230a5 cheers