From patchwork Sat Oct 13 04:53:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Rowand X-Patchwork-Id: 983439 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42XCBf48yjz9s3Z for ; Sat, 13 Oct 2018 15:58:02 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jOVwl1L+"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42XCBf2CkdzF3V7 for ; Sat, 13 Oct 2018 15:58:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jOVwl1L+"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::542; helo=mail-pg1-x542.google.com; envelope-from=frowand.list@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jOVwl1L+"; dkim-atps=neutral Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42XC7G3XwSzF3Kn for ; Sat, 13 Oct 2018 15:55:06 +1100 (AEDT) Received: by mail-pg1-x542.google.com with SMTP id g12-v6so6752715pgs.1 for ; Fri, 12 Oct 2018 21:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=c+T5WeyUd4YTdCOVh2FHvd2NJyZ8yxwwZN2BSmF6eIw=; b=jOVwl1L+HlLHzaOlhJd8EqxIpsMdEIesOmN9vmuILr/qcNGDbAin4zrxyN9GbIBJyA IuJ3IYmbBPo4NhwX3NZYQrajYxVAMARvb0zE+2rrq1UK8dDBPgcnIXGa026HuCAH1XgO OshrpRdezShbBhERAUBlU8+bM3F7i81P7X4m0xBm3QnooeZIG86xdP6wpexpGSpTXHDR JwBzPVtQS1LDP6s60WvS9LEL3HlRfXpCaqDiFDbs9iPxtEIxRohb/bgNhFch4h1aT3IF 515QxBPmnNgp7tlPRWrUJ1p/+nNWKVlxVjX2EEgxFq0bIkyBAygnXCg392lk/JLZbWMq QrVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=c+T5WeyUd4YTdCOVh2FHvd2NJyZ8yxwwZN2BSmF6eIw=; b=l+xVbKiO5Riaaqr+0Er5X3TM2ZopMwJFaLLODpRF+uw6tAegQYO7ulyfl4WEPQhjkW IvEIZJWm/DUey+NkJ40UeLJMq0Dx79fLO5/ufELLs2ELV1CDzwzYIYzTc1sdm0xb9dN+ c8Dz+a2Jj5pUNwdagkEHAYeJJ+dOb+nNizQT7fx0weO7QoBj7hRh8P8ZkMtguv3c20Tw vFcuXBFP9ur3wWGS0bRvawAduDI7fGhiyuMS4Baq26UYw7+rqllyGIjQ7GdTjjIuU8sQ dMhvXB9Q6IdO/GCW5k8+p4i9f0SQqiG/Dlq8oDewxhT2kju2UgOjQOrm90pgwQLh/6sU DynQ== X-Gm-Message-State: ABuFfojHzL2y1HX0NGv6aDhhLsE+zDPeUy8bKc62csZMfUyC/pSaKb+J X1OSftEOboBWsbJkHDVvaJA= X-Google-Smtp-Source: ACcGV63JSpKjokCTQ+cFSRF0UHh244sEb/YZE7KiG3NOgBi+ZixBy6mxYQztL50mEcsPJNIUdtEFEw== X-Received: by 2002:a62:3047:: with SMTP id w68-v6mr8886318pfw.19.1539406504497; Fri, 12 Oct 2018 21:55:04 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id h87-v6sm6959462pfj.78.2018.10.12.21.55.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 12 Oct 2018 21:55:03 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Subject: [PATCH v2 00/18] of: overlay: validation checks, subsequent fixes Date: Fri, 12 Oct 2018 21:53:20 -0700 Message-Id: <1539406418-18162-1-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Frank Rowand Add checks to (1) overlay apply process and (2) memory freeing triggered by overlay release. The checks are intended to detect possible memory leaks and invalid overlays. The checks revealed bugs in existing code. Fixed the bugs. While fixing bugs, noted other issues, which are fixed in separate patches. ***** Powerpc folks: I was not able to test the patches that ***** directly impact Powerpc systems that use dynamic ***** devicetree. Please review that code carefully and ***** test. The specific patches are: 03/16, 04/16, 07/16 FPGA folks: I made the validation checks that should result in an invalid live devicetree report "ERROR" and cause the overlay apply to fail. I made the memory leak validation tests report "WARNING" and allow the overlay apply to complete successfully. Please let me know if you encounter the warnings. There are at least two paths forward to deal with the cases that trigger the warning: (1) change the warning to an error and fail the overlay apply, or (2) find a way to detect the potential memory leaks and free the memory appropriately. ALL people: The validations do _not_ address another major concern I have with releasing overlays, which is use after free errors. Changes since v1: - move patch 16/16 to 17/18 - move patch 15/16 to 18/18 - new patch 15/18 - new patch 16/18 - 05/18: add_changeset_node() header comment: incorrect comment for @target - 18/18: add same fix for of_parse_phandle_with_args() - 18/18: add same fix for of_parse_phandle_with_args_map() Frank Rowand (18): of: overlay: add tests to validate kfrees from overlay removal of: overlay: add missing of_node_put() after add new node to changeset of: overlay: add missing of_node_get() in __of_attach_node_sysfs powerpc/pseries: add of_node_put() in dlpar_detach_node() of: overlay: use prop add changeset entry for property in new nodes of: overlay: do not duplicate properties from overlay for new nodes of: dynamic: change type of of_{at,de}tach_node() to void of: overlay: reorder fields in struct fragment of: overlay: validate overlay properties #address-cells and #size-cells of: overlay: make all pr_debug() and pr_err() messages unique of: overlay: test case of two fragments adding same node of: overlay: check prevents multiple fragments add or delete same node of: overlay: check prevents multiple fragments touching same property of: unittest: remove unused of_unittest_apply_overlay() argument of: overlay: set node fields from properties when add new overlay node of: unittest: allow base devicetree to have symbol metadata of: unittest: find overlays[] entry by name instead of index of: unittest: initialize args before calling of_*parse_*() arch/powerpc/platforms/pseries/dlpar.c | 15 +- arch/powerpc/platforms/pseries/reconfig.c | 6 +- drivers/of/dynamic.c | 68 +++-- drivers/of/kobj.c | 4 +- drivers/of/overlay.c | 298 ++++++++++++++++----- drivers/of/unittest-data/Makefile | 2 + .../of/unittest-data/overlay_bad_add_dup_node.dts | 28 ++ .../of/unittest-data/overlay_bad_add_dup_prop.dts | 24 ++ drivers/of/unittest-data/overlay_base.dts | 1 + drivers/of/unittest.c | 96 +++++-- include/linux/of.h | 19 +- 11 files changed, 439 insertions(+), 122 deletions(-) create mode 100644 drivers/of/unittest-data/overlay_bad_add_dup_node.dts create mode 100644 drivers/of/unittest-data/overlay_bad_add_dup_prop.dts