From patchwork Wed May 30 09:20:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Guo X-Patchwork-Id: 922649 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40wlWX33jkz9s08 for ; Wed, 30 May 2018 19:23:20 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="glooT7f0"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40wlWX1MDrzDrJr for ; Wed, 30 May 2018 19:23:20 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="glooT7f0"; dkim-atps=neutral X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c00::243; helo=mail-pf0-x243.google.com; envelope-from=wei.guo.simon@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="glooT7f0"; dkim-atps=neutral Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40wlTJ4mp4zDr5J for ; Wed, 30 May 2018 19:21:24 +1000 (AEST) Received: by mail-pf0-x243.google.com with SMTP id e9-v6so8720795pfi.4 for ; Wed, 30 May 2018 02:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ynZaVUe8R7UZrcnCJTR6gUafZMp33OWOt1k+4gnvi7A=; b=glooT7f0nyBveCBhNVbk60aMW1jyD3ekxnH6ISPEdxAbD2Z6AzHhO1GWdwLIHSXUrW oNf5FR+QRIs1m7Sxv4ssL5PxEFqBWR4wzchmo4ca86XXzWbIwmVYVO+q+EDp8Ah8YvsX UHz7LZgyvLEOo5WeD0ONblgmthWmSxAUCvScwYM1TkJ1oC5ZsiKau82tu9tjFv9oP0zw tq4MYz7+Aoz7kLs7sV7bZQ+oPLMa6+qRXKMLRhrn704a3tnCNi1iprPZ4lKXsnxywDSJ aMJqJKDWwP93qrvCLn9UAFqvht7wyZ82LY/D3CY+dDOQowQXyKY+4pRLPbCGVQJqrOL/ KEUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ynZaVUe8R7UZrcnCJTR6gUafZMp33OWOt1k+4gnvi7A=; b=mBG5iGASMW+94wdrRfZIVLVqsZtGTXnvvq/VI9MLVGEdSnKA6ZPEAx83nySZzziR5A KDXnzDd90M0UIPgDKUSErv2uVQsOdmqP1vXTKp40Z8AVUj79amrWrP/KyrJSN7fqoSaZ myrC/emip+/Jmw5FnPxedE8Qpr/VJXgrDzn1MbskKWw9Oc33qpr1go6R1YeJ1BCRz+t6 jyBvSSdgYNFhoBdODLR6VzczXZXsWDOv0+A5FcDf0fdXISMKVEePWn08Q1QOq78cWhmf d1/LNnt1if6mZFHDAVHAapGU4eix7G7v8I0n/L6JmT46FhGkta8/CqxZHcfu1P85nbM2 JYCg== X-Gm-Message-State: ALKqPwdaf5SwulPPhJmEdfZBZpmDOWLwgPkMMGi5i2cq+peVgfamwX2A UhZYdAMosXET6oaJIhNCwMDB5Q== X-Google-Smtp-Source: ADUXVKLAW2rjDFq4nXXxAvKYZlo8wggoJomD4LOaKSVUpdquoIMM/sRSjcyNGPWyt/7R6T/tTsa1/A== X-Received: by 2002:a65:608c:: with SMTP id t12-v6mr1576244pgu.182.1527672082452; Wed, 30 May 2018 02:21:22 -0700 (PDT) Received: from simonLocalRHEL7.cn.ibm.com ([112.73.0.88]) by smtp.gmail.com with ESMTPSA id 73-v6sm78806842pfo.153.2018.05.30.02.21.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 May 2018 02:21:21 -0700 (PDT) From: wei.guo.simon@gmail.com To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH v7 0/5] powerpc/64: memcmp() optimization Date: Wed, 30 May 2018 17:20:58 +0800 Message-Id: <1527672063-6953-1-git-send-email-wei.guo.simon@gmail.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Naveen N. Rao" , Simon Guo , Cyril Bur Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Simon Guo There is some room to optimize memcmp() in powerpc 64 bits version for following 2 cases: (1) Even src/dst addresses are not aligned with 8 bytes at the beginning, memcmp() can align them and go with .Llong comparision mode without fallback to .Lshort comparision mode do compare buffer byte by byte. (2) VMX instructions can be used to speed up for large size comparision, currently the threshold is set for 4K bytes. Notes the VMX instructions will lead to VMX regs save/load penalty. This patch set includes a patch to add a 32 bytes pre-checking to minimize the penalty. It did the similar with glibc commit dec4a7105e (powerpc: Improve memcmp performance for POWER8). Thanks Cyril Bur's information. This patch set also updates memcmp selftest case to make it compiled and incorporate large size comparison case. v6 -> v7: - add vcmpequd/vcmpequdb .long macro - add CPU_FTR pair so that Power7 won't invoke Altivec instrs. - rework some instructions for higher performance or more readable. v5 -> v6: - correct some comments/commit messsage. - rename VMX_OPS_THRES to VMX_THRESH v4 -> v5: - Expand 32 bytes prechk to src/dst different offset case, and remove KSM specific label/comment. v3 -> v4: - Add 32 bytes pre-checking before using VMX instructions. v2 -> v3: - add optimization for src/dst with different offset against 8 bytes boundary. - renamed some label names. - reworked some comments from Cyril Bur, such as fill the pipeline, and use VMX when size == 4K. - fix a bug of enter/exit_vmx_ops pairness issue. And revised test case to test whether enter/exit_vmx_ops are paired. v1 -> v2: - update 8bytes unaligned bytes comparison method. - fix a VMX comparision bug. - enhanced the original memcmp() selftest. - add powerpc/64 to subject/commit message. Simon Guo (5): powerpc/64: Align bytes before fall back to .Lshort in powerpc64 memcmp() powerpc: add vcmpequd/vcmpequb ppc instruction macro powerpc/64: enhance memcmp() with VMX instruction for long bytes comparision powerpc/64: add 32 bytes prechecking before using VMX optimization on memcmp() powerpc:selftest update memcmp_64 selftest for VMX implementation arch/powerpc/include/asm/asm-prototypes.h | 4 +- arch/powerpc/include/asm/ppc-opcode.h | 11 + arch/powerpc/lib/copypage_power7.S | 4 +- arch/powerpc/lib/memcmp_64.S | 412 ++++++++++++++++++++- arch/powerpc/lib/memcpy_power7.S | 6 +- arch/powerpc/lib/vmx-helper.c | 4 +- .../selftests/powerpc/copyloops/asm/ppc_asm.h | 4 +- .../selftests/powerpc/stringloops/asm/ppc-opcode.h | 39 ++ .../selftests/powerpc/stringloops/asm/ppc_asm.h | 24 ++ .../testing/selftests/powerpc/stringloops/memcmp.c | 98 +++-- 10 files changed, 566 insertions(+), 40 deletions(-) create mode 100644 tools/testing/selftests/powerpc/stringloops/asm/ppc-opcode.h