Message ID | 20250104141430.115031-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers | show |
Series | memory: tegra20-emc: Drop redundant platform_get_irq() error printk | expand |
On Sat, 04 Jan 2025 15:14:30 +0100, Krzysztof Kozlowski wrote: > platform_get_irq() already prints error message, so duplicating it is > redundant. The message about "need of updating DT" makes no sense, > because this code was there since beginning. > > Applied, thanks! [1/1] memory: tegra20-emc: Drop redundant platform_get_irq() error printk https://git.kernel.org/krzk/linux-mem-ctrl/c/2f76a890fd2c636c640af1387b333aeb0cf69c75 Best regards,
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c index 7193f848d17e..ed094cc3c108 100644 --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -1191,10 +1191,8 @@ static int tegra_emc_probe(struct platform_device *pdev) int irq, err; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "please update your device tree\n"); + if (irq < 0) return irq; - } emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL); if (!emc)
platform_get_irq() already prints error message, so duplicating it is redundant. The message about "need of updating DT" makes no sense, because this code was there since beginning. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/memory/tegra/tegra20-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)