mbox series

[0/5] Add I2C support for Tegra264

Message ID 20250108110620.86900-1-kkartik@nvidia.com
Headers show
Series Add I2C support for Tegra264 | expand

Message

Kartik Rajput Jan. 8, 2025, 11:06 a.m. UTC 
Following series of patches add support for Tegra264 and High Speed (HS)
Mode in i2c-tegra.c driver.

Akhil R (3):
  i2c: tegra: Add HS mode support
  i2c: tegra: Add Tegra264 support
  i2c: tegra: Add support for SW Mutex register

Kartik Rajput (2):
  dt-bindings: i2c: nvidia,tegra20-i2c: Document Tegra264 I2C
  i2c: tegra: Do not configure DMA if not supported

 .../bindings/i2c/nvidia,tegra20-i2c.yaml      |   6 +
 drivers/i2c/busses/i2c-tegra.c                | 179 ++++++++++++++++--
 2 files changed, 170 insertions(+), 15 deletions(-)

Comments

Thierry Reding Jan. 9, 2025, 10:37 a.m. UTC | #1 
On Wed, Jan 08, 2025 at 04:36:15PM +0530, Kartik Rajput wrote:
> Following series of patches add support for Tegra264 and High Speed (HS)
> Mode in i2c-tegra.c driver.
> 
> Akhil R (3):
>   i2c: tegra: Add HS mode support
>   i2c: tegra: Add Tegra264 support
>   i2c: tegra: Add support for SW Mutex register
> 
> Kartik Rajput (2):
>   dt-bindings: i2c: nvidia,tegra20-i2c: Document Tegra264 I2C
>   i2c: tegra: Do not configure DMA if not supported

It'd probably make sense to restructure this series a little bit. It's
customary to have the DT patch first. It would then make more sense to
add preparatory patches and then follow those up by the Tegra264 support
patches, so something like this:

	dt-bindings: i2c: nvidia,tegra20-i2c: Document Tegra264 I2C
	i2c: tegra: Do not configure DMA if not supported
	i2c: tegra: Add HS mode support
	i2c: tegra: Add support for SW Mutex register
	i2c: tegra: Add Tegra264 support

Thierry
Kartik Rajput Jan. 15, 2025, 11:44 a.m. UTC | #2 
On Thu, 2025-01-09 at 11:37 +0100, Thierry Reding wrote:
> On Wed, Jan 08, 2025 at 04:36:15PM +0530, Kartik Rajput wrote:
> > Following series of patches add support for Tegra264 and High Speed
> > (HS)
> > Mode in i2c-tegra.c driver.
> > 
> > Akhil R (3):
> >   i2c: tegra: Add HS mode support
> >   i2c: tegra: Add Tegra264 support
> >   i2c: tegra: Add support for SW Mutex register
> > 
> > Kartik Rajput (2):
> >   dt-bindings: i2c: nvidia,tegra20-i2c: Document Tegra264 I2C
> >   i2c: tegra: Do not configure DMA if not supported
> 
> It'd probably make sense to restructure this series a little bit.
> It's
> customary to have the DT patch first. It would then make more sense
> to
> add preparatory patches and then follow those up by the Tegra264
> support
> patches, so something like this:
> 
>         dt-bindings: i2c: nvidia,tegra20-i2c: Document Tegra264 I2C
>         i2c: tegra: Do not configure DMA if not supported
>         i2c: tegra: Add HS mode support
>         i2c: tegra: Add support for SW Mutex register
>         i2c: tegra: Add Tegra264 support
> 
> Thierry

Thanks for reviewing the patches in this series Thierry!
I will re-arrange this and post a new patch set for review.

Thanks & Regards,
Kartik