| Message ID | 20241129153546.63584-8-antoniu.miclaus@analog.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Add support for AD485x DAS Family | expand |
On 11/29/24 9:35 AM, Antoniu Miclaus wrote: > Add devicetree bindings for ad485x family. > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > changes in v7: > - add adc channels support What is the reason for this change? In a previous version of this series, you explained that we didn't want to specify diff-channels in the DT because there was a use case to use channels as both single-ended and differential at runtime. So I am surprised to see this being added now. > +patternProperties: > + "^channel(@[0-7])?$": > + $ref: adc.yaml > + type: object > + description: Represents the channels which are connected to the ADC. > + > + properties: > + reg: > + description: The channel number in single-ended mode. > + minimum: 0 > + maximum: 7 > + > + diff-channels: true > + > + required: > + - reg > + > + additionalProperties: false > +
-- Antoniu Miclăuş > -----Original Message----- > From: David Lechner <dlechner@baylibre.com> > Sent: Thursday, December 5, 2024 2:46 AM > To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; jic23@kernel.org; > robh@kernel.org; conor+dt@kernel.org; linux-iio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > pwm@vger.kernel.org > Cc: Conor Dooley <conor.dooley@microchip.com> > Subject: Re: [PATCH v7 7/8] dt-bindings: iio: adc: add ad4851 > > [External] > > On 11/29/24 9:35 AM, Antoniu Miclaus wrote: > > Add devicetree bindings for ad485x family. > > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > > --- > > changes in v7: > > - add adc channels support > > What is the reason for this change? In a previous version of this series, > you explained that we didn't want to specify diff-channels in the DT > because there was a use case to use channels as both single-ended and > differential at runtime. So I am surprised to see this being added now. > We had a discussion and we decided to go for the dt approach for specifying the channels configuration, even though in the first place we wanted to avoid this. Overall it makes more sense. > > +patternProperties: > > + "^channel(@[0-7])?$": > > + $ref: adc.yaml > > + type: object > > + description: Represents the channels which are connected to the ADC. > > + > > + properties: > > + reg: > > + description: The channel number in single-ended mode. > > + minimum: 0 > > + maximum: 7 > > + > > + diff-channels: true > > + > > + required: > > + - reg > > + > > + additionalProperties: false > > +
On 12/9/24 8:02 AM, Miclaus, Antoniu wrote: > > > -- > Antoniu Miclăuş > >> -----Original Message----- >> From: David Lechner <dlechner@baylibre.com> >> Sent: Thursday, December 5, 2024 2:46 AM >> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; jic23@kernel.org; >> robh@kernel.org; conor+dt@kernel.org; linux-iio@vger.kernel.org; >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> pwm@vger.kernel.org >> Cc: Conor Dooley <conor.dooley@microchip.com> >> Subject: Re: [PATCH v7 7/8] dt-bindings: iio: adc: add ad4851 >> >> [External] >> >> On 11/29/24 9:35 AM, Antoniu Miclaus wrote: >>> Add devicetree bindings for ad485x family. >>> >>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> >>> --- >>> changes in v7: >>> - add adc channels support >> >> What is the reason for this change? In a previous version of this series, >> you explained that we didn't want to specify diff-channels in the DT >> because there was a use case to use channels as both single-ended and >> differential at runtime. So I am surprised to see this being added now. >> > We had a discussion and we decided to go for the dt approach for specifying > the channels configuration, even though in the first place we wanted to avoid this. > Overall it makes more sense. OK, in that case we will also want to make use of the standard "bipolar" property from adc.yaml as well since the chip differentiates between unipolar and bipolar inputs. Also, might want to drop Conor's review tag and give an explanation in the next revision since adding these channel properties is a bit of a big change compared to the version he reviewed. > >>> +patternProperties: >>> + "^channel(@[0-7])?$": >>> + $ref: adc.yaml >>> + type: object >>> + description: Represents the channels which are connected to the ADC. >>> + >>> + properties: >>> + reg: >>> + description: The channel number in single-ended mode. >>> + minimum: 0 >>> + maximum: 7 >>> + >>> + diff-channels: true >>> + >>> + required: >>> + - reg >>> + >>> + additionalProperties: false >>> +
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml new file mode 100644 index 000000000000..57e5222dee71 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4851.yaml @@ -0,0 +1,139 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright 2024 Analog Devices Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/adi,ad4851.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD485X family + +maintainers: + - Sergiu Cuciurean <sergiu.cuciurean@analog.com> + - Dragos Bogdan <dragos.bogdan@analog.com> + - Antoniu Miclaus <antoniu.miclaus@analog.com> + +description: | + Analog Devices AD485X fully buffered, 8-channel simultaneous sampling, + 16/20-bit, 1 MSPS data acquisition system (DAS) with differential, wide + common-mode range inputs. + + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4855.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4856.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4857.pdf + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4858.pdf + +$ref: /schemas/spi/spi-peripheral-props.yaml# + +properties: + compatible: + enum: + - adi,ad4851 + - adi,ad4852 + - adi,ad4853 + - adi,ad4854 + - adi,ad4855 + - adi,ad4856 + - adi,ad4857 + - adi,ad4858 + - adi,ad4858i + + reg: + maxItems: 1 + + vcc-supply: true + + vee-supply: true + + vdd-supply: true + + vddh-supply: true + + vddl-supply: true + + vio-supply: true + + vrefbuf-supply: true + + vrefio-supply: true + + pwms: + description: PWM connected to the CNV pin. + maxItems: 1 + + io-backends: + maxItems: 1 + + pd-gpios: + maxItems: 1 + + spi-max-frequency: + maximum: 25000000 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + +patternProperties: + "^channel(@[0-7])?$": + $ref: adc.yaml + type: object + description: Represents the channels which are connected to the ADC. + + properties: + reg: + description: The channel number in single-ended mode. + minimum: 0 + maximum: 7 + + diff-channels: true + + required: + - reg + + additionalProperties: false + +required: + - compatible + - reg + - vcc-supply + - vee-supply + - vdd-supply + - vio-supply + - pwms + +unevaluatedProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + adc@0{ + #address-cells = <1>; + #size-cells = <0>; + compatible = "adi,ad4858"; + reg = <0>; + spi-max-frequency = <10000000>; + vcc-supply = <&vcc>; + vdd-supply = <&vdd>; + vee-supply = <&vee>; + vddh-supply = <&vddh>; + vddl-supply = <&vddl>; + vio-supply = <&vio>; + pwms = <&pwm_gen 0 0>; + io-backends = <&iio_backend>; + + channel@0 { + reg = <0>; + diff-channels = <0 8>; + }; + + channel@1 { + reg = <1>; + }; + }; + }; +...