Message ID | 20241112090924.287056-1-luoyifan@cmss.chinamobile.com |
---|---|
State | New |
Headers | show |
Series | tools: PCI: Fix several incorrect format specifiers | expand |
On Tue, Nov 12, 2024 at 05:09:24PM +0800, Luo Yifan wrote: > Make a minor change to eliminate static checker warnings. Fix several > incorrect format specifiers that misused signed and unsigned versions. > > Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > tools/pci/pcitest.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c > index 470258009..7b530d838 100644 > --- a/tools/pci/pcitest.c > +++ b/tools/pci/pcitest.c > @@ -95,7 +95,7 @@ static int run_test(struct pci_test *test) > > if (test->msinum > 0 && test->msinum <= 32) { > ret = ioctl(fd, PCITEST_MSI, test->msinum); > - fprintf(stdout, "MSI%d:\t\t", test->msinum); > + fprintf(stdout, "MSI%u:\t\t", test->msinum); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > @@ -104,7 +104,7 @@ static int run_test(struct pci_test *test) > > if (test->msixnum > 0 && test->msixnum <= 2048) { > ret = ioctl(fd, PCITEST_MSIX, test->msixnum); > - fprintf(stdout, "MSI-X%d:\t\t", test->msixnum); > + fprintf(stdout, "MSI-X%u:\t\t", test->msixnum); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > @@ -116,7 +116,7 @@ static int run_test(struct pci_test *test) > if (test->use_dma) > param.flags = PCITEST_FLAGS_USE_DMA; > ret = ioctl(fd, PCITEST_WRITE, ¶m); > - fprintf(stdout, "WRITE (%7ld bytes):\t\t", test->size); > + fprintf(stdout, "WRITE (%7lu bytes):\t\t", test->size); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > @@ -128,7 +128,7 @@ static int run_test(struct pci_test *test) > if (test->use_dma) > param.flags = PCITEST_FLAGS_USE_DMA; > ret = ioctl(fd, PCITEST_READ, ¶m); > - fprintf(stdout, "READ (%7ld bytes):\t\t", test->size); > + fprintf(stdout, "READ (%7lu bytes):\t\t", test->size); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > @@ -140,7 +140,7 @@ static int run_test(struct pci_test *test) > if (test->use_dma) > param.flags = PCITEST_FLAGS_USE_DMA; > ret = ioctl(fd, PCITEST_COPY, ¶m); > - fprintf(stdout, "COPY (%7ld bytes):\t\t", test->size); > + fprintf(stdout, "COPY (%7lu bytes):\t\t", test->size); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > -- > 2.27.0 > > >
On Tue, Nov 12, 2024 at 05:09:24PM +0800, Luo Yifan wrote: > Make a minor change to eliminate static checker warnings. Fix several > incorrect format specifiers that misused signed and unsigned versions. > > Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com> Applied with Mani's reviewed-by to pci/misc for v6.13, thanks! > --- > tools/pci/pcitest.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c > index 470258009..7b530d838 100644 > --- a/tools/pci/pcitest.c > +++ b/tools/pci/pcitest.c > @@ -95,7 +95,7 @@ static int run_test(struct pci_test *test) > > if (test->msinum > 0 && test->msinum <= 32) { > ret = ioctl(fd, PCITEST_MSI, test->msinum); > - fprintf(stdout, "MSI%d:\t\t", test->msinum); > + fprintf(stdout, "MSI%u:\t\t", test->msinum); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > @@ -104,7 +104,7 @@ static int run_test(struct pci_test *test) > > if (test->msixnum > 0 && test->msixnum <= 2048) { > ret = ioctl(fd, PCITEST_MSIX, test->msixnum); > - fprintf(stdout, "MSI-X%d:\t\t", test->msixnum); > + fprintf(stdout, "MSI-X%u:\t\t", test->msixnum); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > @@ -116,7 +116,7 @@ static int run_test(struct pci_test *test) > if (test->use_dma) > param.flags = PCITEST_FLAGS_USE_DMA; > ret = ioctl(fd, PCITEST_WRITE, ¶m); > - fprintf(stdout, "WRITE (%7ld bytes):\t\t", test->size); > + fprintf(stdout, "WRITE (%7lu bytes):\t\t", test->size); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > @@ -128,7 +128,7 @@ static int run_test(struct pci_test *test) > if (test->use_dma) > param.flags = PCITEST_FLAGS_USE_DMA; > ret = ioctl(fd, PCITEST_READ, ¶m); > - fprintf(stdout, "READ (%7ld bytes):\t\t", test->size); > + fprintf(stdout, "READ (%7lu bytes):\t\t", test->size); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > @@ -140,7 +140,7 @@ static int run_test(struct pci_test *test) > if (test->use_dma) > param.flags = PCITEST_FLAGS_USE_DMA; > ret = ioctl(fd, PCITEST_COPY, ¶m); > - fprintf(stdout, "COPY (%7ld bytes):\t\t", test->size); > + fprintf(stdout, "COPY (%7lu bytes):\t\t", test->size); > if (ret < 0) > fprintf(stdout, "TEST FAILED\n"); > else > -- > 2.27.0 > > >
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c index 470258009..7b530d838 100644 --- a/tools/pci/pcitest.c +++ b/tools/pci/pcitest.c @@ -95,7 +95,7 @@ static int run_test(struct pci_test *test) if (test->msinum > 0 && test->msinum <= 32) { ret = ioctl(fd, PCITEST_MSI, test->msinum); - fprintf(stdout, "MSI%d:\t\t", test->msinum); + fprintf(stdout, "MSI%u:\t\t", test->msinum); if (ret < 0) fprintf(stdout, "TEST FAILED\n"); else @@ -104,7 +104,7 @@ static int run_test(struct pci_test *test) if (test->msixnum > 0 && test->msixnum <= 2048) { ret = ioctl(fd, PCITEST_MSIX, test->msixnum); - fprintf(stdout, "MSI-X%d:\t\t", test->msixnum); + fprintf(stdout, "MSI-X%u:\t\t", test->msixnum); if (ret < 0) fprintf(stdout, "TEST FAILED\n"); else @@ -116,7 +116,7 @@ static int run_test(struct pci_test *test) if (test->use_dma) param.flags = PCITEST_FLAGS_USE_DMA; ret = ioctl(fd, PCITEST_WRITE, ¶m); - fprintf(stdout, "WRITE (%7ld bytes):\t\t", test->size); + fprintf(stdout, "WRITE (%7lu bytes):\t\t", test->size); if (ret < 0) fprintf(stdout, "TEST FAILED\n"); else @@ -128,7 +128,7 @@ static int run_test(struct pci_test *test) if (test->use_dma) param.flags = PCITEST_FLAGS_USE_DMA; ret = ioctl(fd, PCITEST_READ, ¶m); - fprintf(stdout, "READ (%7ld bytes):\t\t", test->size); + fprintf(stdout, "READ (%7lu bytes):\t\t", test->size); if (ret < 0) fprintf(stdout, "TEST FAILED\n"); else @@ -140,7 +140,7 @@ static int run_test(struct pci_test *test) if (test->use_dma) param.flags = PCITEST_FLAGS_USE_DMA; ret = ioctl(fd, PCITEST_COPY, ¶m); - fprintf(stdout, "COPY (%7ld bytes):\t\t", test->size); + fprintf(stdout, "COPY (%7lu bytes):\t\t", test->size); if (ret < 0) fprintf(stdout, "TEST FAILED\n"); else
Make a minor change to eliminate static checker warnings. Fix several incorrect format specifiers that misused signed and unsigned versions. Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com> --- tools/pci/pcitest.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)