Message ID | 1732577084-2122-2-git-send-email-nunodasneves@linux.microsoft.com |
---|---|
State | New |
Headers | show |
Series | Introduce new headers for Hyper-V | expand |
On Mon, Nov 25, 2024 at 03:24:40PM -0800, Nuno Das Neves wrote: > This definition is in the wrong file; it is part of the TLFS doc. > > Acked-by: Wei Liu <wei.liu@kernel.org> > Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com> > Reviewed-by: Michael Kelley <mhklinux@outlook.com> > Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com> One comment about the ordering of the tags. It is better to organize them in the following order: Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com> Acked-by: Wei Liu <wei.liu@kernel.org> Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com> Reviewed-by: Michael Kelley <mhklinux@outlook.com> I've made the change for you while applying the patch. Thanks, Wei.
On 12/8/2024 4:07 PM, Wei Liu wrote: > On Mon, Nov 25, 2024 at 03:24:40PM -0800, Nuno Das Neves wrote: >> This definition is in the wrong file; it is part of the TLFS doc. >> >> Acked-by: Wei Liu <wei.liu@kernel.org> >> Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com> >> Reviewed-by: Michael Kelley <mhklinux@outlook.com> >> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com> > > One comment about the ordering of the tags. It is better to organize > them in the following order: > > Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com> > Acked-by: Wei Liu <wei.liu@kernel.org> > Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com> > Reviewed-by: Michael Kelley <mhklinux@outlook.com> > > I've made the change for you while applying the patch. > Thank you, noted for next time. > Thanks, > Wei.
diff --git a/include/asm-generic/hyperv-tlfs.h b/include/asm-generic/hyperv-tlfs.h index 814207e7c37f..52274c9aefef 100644 --- a/include/asm-generic/hyperv-tlfs.h +++ b/include/asm-generic/hyperv-tlfs.h @@ -871,4 +871,13 @@ struct hv_mmio_write_input { u8 data[HV_HYPERCALL_MMIO_MAX_DATA_LENGTH]; } __packed; +/* Define connection identifier type. */ +union hv_connection_id { + u32 asu32; + struct { + u32 id:24; + u32 reserved:8; + } u; +}; + #endif diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 22c22fb91042..d0893ec488ae 100644 --- a/include/linux/hyperv.h +++ b/include/linux/hyperv.h @@ -768,15 +768,6 @@ struct vmbus_close_msg { struct vmbus_channel_close_channel msg; }; -/* Define connection identifier type. */ -union hv_connection_id { - u32 asu32; - struct { - u32 id:24; - u32 reserved:8; - } u; -}; - enum vmbus_device_type { HV_IDE = 0, HV_SCSI,