| Message ID | 20241202-mb85rs128ty-v1-2-a660b6490dc8@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Fujitsu MB85RS128TY | expand |
On 02.12.2024 17:35:21, Jonas Rebmann wrote: > Add a compatible string to support Fujitsu MB85RS128TY. > > Signed-off-by: Jonas Rebmann <jre@pengutronix.de> > --- > Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml > index 0ff32bd00bf6aee279fa78c624d8d47c6162f7f1..973f06b665dbbcb9ea1090418eb18fbe2285acef 100644 > --- a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml > +++ b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml > @@ -18,6 +18,7 @@ properties: > compatible: > items: ^^^^^ I think you need to change to "oneOf" > - const: microchip,48l640 > + - const: fujitsu,mb85rs128ty > > reg: > maxItems: 1 regards, Marc
On Mon, 02 Dec 2024 17:35:21 +0100, Jonas Rebmann wrote: > Add a compatible string to support Fujitsu MB85RS128TY. > > Signed-off-by: Jonas Rebmann <jre@pengutronix.de> > --- > Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.example.dtb: eeram@0: compatible: ['microchip,48l640'] is too short from schema $id: http://devicetree.org/schemas/mtd/microchip,mchp48l640.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.example.dtb: eeram@0: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/mtd/microchip,mchp48l640.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241202-mb85rs128ty-v1-2-a660b6490dc8@pengutronix.de The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Dec 02, 2024 at 05:53:18PM +0100, Marc Kleine-Budde wrote: > On 02.12.2024 17:35:21, Jonas Rebmann wrote: > > Add a compatible string to support Fujitsu MB85RS128TY. > > > > Signed-off-by: Jonas Rebmann <jre@pengutronix.de> > > --- > > Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml > > index 0ff32bd00bf6aee279fa78c624d8d47c6162f7f1..973f06b665dbbcb9ea1090418eb18fbe2285acef 100644 > > --- a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml > > +++ b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml > > @@ -18,6 +18,7 @@ properties: > > compatible: > > items: > ^^^^^ > I think you need to change to "oneOf" "enum" rather than oneOf plus const entries. > > > - const: microchip,48l640 > > + - const: fujitsu,mb85rs128ty > > > > reg: > > maxItems: 1 > > regards, > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung Nürnberg | Phone: +49-5121-206917-129 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
diff --git a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml index 0ff32bd00bf6aee279fa78c624d8d47c6162f7f1..973f06b665dbbcb9ea1090418eb18fbe2285acef 100644 --- a/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml +++ b/Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml @@ -18,6 +18,7 @@ properties: compatible: items: - const: microchip,48l640 + - const: fujitsu,mb85rs128ty reg: maxItems: 1
Add a compatible string to support Fujitsu MB85RS128TY. Signed-off-by: Jonas Rebmann <jre@pengutronix.de> --- Documentation/devicetree/bindings/mtd/microchip,mchp48l640.yaml | 1 + 1 file changed, 1 insertion(+)