From patchwork Thu Nov 7 13:47:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Folkesson X-Patchwork-Id: 2008025 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ljon41PO; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=foxgK0hA; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xkk0t165Dz1xyb for ; Fri, 8 Nov 2024 00:47:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pB+lCClpETuSTNYB52D3Z/A+dyEc7Q902q6qmdSg/48=; b=ljon41POgj5glM 2KhZZpzY3MiOCWzqM3DDAAFlrZyh1cx+XSGb29Xu8ywKZ5zAku4PEvpEs6YR5kj4F/Z8wJREh5mWT NmkAYLULrjJGtXbkRtlDDqh4/13HkmUP+7i1ab+OrEvGfy2RANAZ2VMAXc+3aF1ouWZ3VkZQhE6wW kd0ksCuJupz5gjt6sv3lxHSFv4yR16z37rAJC9Z9tnAxW7KakbVvdFNi4gI4Dqmh7r7BLMx/oAT4M YizFk5dKWv83cVCR6WEGKsC3Zx0w263/5HqgZKXAzdX+5BaShiJ6Glo97N5bYLzA2gCjXaHRKNrzf mOK2kiITFx2yBIAXUJDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t92rM-00000007ARi-2ASd; Thu, 07 Nov 2024 13:47:40 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t92rI-00000007APm-2mFE for linux-mtd@lists.infradead.org; Thu, 07 Nov 2024 13:47:37 +0000 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2fc968b3545so9068221fa.2 for ; Thu, 07 Nov 2024 05:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730987255; x=1731592055; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=smTKmYgVjf2tZh/nJwAXDtC0KskLoU7un/mwCANgBrg=; b=foxgK0hAhnszGdSBDHtA4PaUWop4xZr4vB5aBeaZLgeAl2NiaAlCsOXQuiv29NQ7o4 yyFa/gKHMH+9/f4LoR00yEEyjyc0nFvKYsG+sp11vSvF774/aG3TgnTZ9JlnQ+yYC0+d IYh0WMJO4BY34zdpkSGRbQrFikkZs7e6H+nABOx35qgLfqItNeAOdenINeQs4Eynznn9 iQlRS9lf8p4tfYiJpq6RRBNLrx14vcgp/nLbFNBZ+UU+Lx+j7mvBD11wKfdqYVWX7Q2v zp6C+B+L54m4U+FwFyo+EQDw4T5I3hfWVXIQNHWSVpXw7O99Viq2Wnbodk4xTj/9clQD P7SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730987255; x=1731592055; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=smTKmYgVjf2tZh/nJwAXDtC0KskLoU7un/mwCANgBrg=; b=krLIIkbXLjCKc3B5IsPmKiSHkkZNjPSeNYQTYEcSLzlYr21Y+PuWFrjVQ7vpXm/mO8 K7OInS9WTAUpoNyldotYYtSPcDnFC+t/ZIJ1htwnHEi9ibSoIwL71FGuoFHeYIqXo4/X qv8GkqmB7NokjsolZkWUj28Dpv43f/Pgz0b7rdZdEYmICHDgdeA60GBcecI0aPo801s3 5VLzTkp/KFGyS9nRl0i6gNGGfMHBk+/dXAV7PaFqcIexEnqK8D3AbxsdbLf6W1gKjt8I COikNCXMrAPOqrrE0R5ySINnJEfxEE8PZzB5t1jxX3eU8gZX+tpkcn82B/8ydX+Uh8Ls KYWQ== X-Gm-Message-State: AOJu0Yy4FAankSwyqvjMsYyBLFRdSgerqns3x66Tm/DpaaQ/HdMVNJdI 5si0cqm/QSJuYW7JUCwiXKpN680vejAua5+XzeuHLD9Rm9mfO94G X-Google-Smtp-Source: AGHT+IFhbSo5pXZ6+Sbeo6H9y9g5iMqsCOoUVCmNbcBaUywv9O9gtHsU2QUKclCRiOp0TTaJsxBQSw== X-Received: by 2002:a05:651c:2226:b0:2fb:8de8:7f9e with SMTP id 38308e7fff4ca-2ff1e889520mr330911fa.1.1730987254965; Thu, 07 Nov 2024 05:47:34 -0800 (PST) Received: from [192.168.1.11] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ff179d80f5sm2276591fa.105.2024.11.07.05.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 05:47:33 -0800 (PST) From: Marcus Folkesson Date: Thu, 07 Nov 2024 14:47:07 +0100 Subject: [PATCH v7 1/2] mtd: nand: davinci: add support for on-die ECC engine type MIME-Version: 1.0 Message-Id: <20241107-ondie-v7-1-98829fc8a958@gmail.com> References: <20241107-ondie-v7-0-98829fc8a958@gmail.com> In-Reply-To: <20241107-ondie-v7-0-98829fc8a958@gmail.com> To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Marcus Folkesson X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1761; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=aEezSAYRZux5sp8R/V/BZi69L/f49HVcP44j8wR1Vf8=; b=owEBbQKS/ZANAwAIAYiATm9ZXVIyAcsmYgBnLMTomdUX6qyJCp5iC5mJbbMGc/zZt+dO48AXd cJzzvAvBlOJAjMEAAEIAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCZyzE6AAKCRCIgE5vWV1S MrR3D/sFuhOd8C3qeA1eeAPtI5jyaqZ501Z7Jvnijo/eKG2sexB2doGkM5mDbHfmanCYTEaX6R6 OfVO03LCSAqElMilqYG8q0o8hfo2Ad/dmDg58tjrKCAqaEsiElMjdr5FpI7Q782s3XnbZ8vq5Ih 6SlzQwyMLQxeJMVlaIUVYnm6gh5X4y37NHABs7Kr+IpbpppUdcHjyxc6gUOZQFopGA65uQIaDZy X4gc0yO8d+qxyRTpnZkNcZoLz3TyyakL3ikVLYXkxjryeLYF9p7bO95vXytU4Zi1SLNyyJ6hCdW KV1rItkX1Id4+3HyqWrEii90BIw/CzoVoCOUSMHxSc//BKihZgFznpbLuJXHCWh/afTzBvMuH6B Z8zp+knjRwbcfgU5vpkiDSvMTLrM1xKL2wvmwcy2P+mJiAYDYo8VMJBUOPV8eHAmMQwM9KBXhge NhhyD5hRC8Nlq03Kju7D+IMnB+M3P+9I3CNrh5BxS0W5pkaMyIiJDcZ5mbfTEGa+D1RtHq+X8xe dLHMUdHHBpe2F/fZ7jMJ1/PW5iuq1xyqyb5yGHDfcLVTBycTD9UEojc5drZlHyyz50YMs9Ueoe5 W+FW0e5ZT7WXTNHG5u5TP6RZHRkpsdfAzg/6OHTridZcPbUi5i6hkUE8mID/0j2Y9UGbVQI/u8+ 7qd1Wm3wWJnLchQ== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241107_054736_717943_F1F11DC4 X-CRM114-Status: GOOD ( 14.31 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Some chips, e.g. Micron MT29F1G08ABBFAH4, has a mandatory on-die ECC. Add "on-die" as ECC engine type in order to be compatible with those. Signed-off-by: Marcus Folkesson --- drivers/mtd/nand/raw/davinci_nand.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:22b listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [marcus.folkesson(at)gmail.com] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Some chips, e.g. Micron MT29F1G08ABBFAH4, has a mandatory on-die ECC. Add "on-die" as ECC engine type in order to be compatible with those. Signed-off-by: Marcus Folkesson --- drivers/mtd/nand/raw/davinci_nand.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c index 392678143a36b20b42c1827eee8203dc2e41889a..79e768d337ae12f6e8d7f21f1acd4e259f4f3020 100644 --- a/drivers/mtd/nand/raw/davinci_nand.c +++ b/drivers/mtd/nand/raw/davinci_nand.c @@ -66,6 +66,7 @@ struct davinci_nand_pdata { /* none == NAND_ECC_ENGINE_TYPE_NONE (strongly *not* advised!!) * soft == NAND_ECC_ENGINE_TYPE_SOFT + * on-die == NAND_ECC_ENGINE_TYPE_ON_DIE * else == NAND_ECC_ENGINE_TYPE_ON_HOST, according to ecc_bits * * All DaVinci-family chips support 1-bit hardware ECC. @@ -524,6 +525,8 @@ static struct davinci_nand_pdata pdata->engine_type = NAND_ECC_ENGINE_TYPE_SOFT; if (!strncmp("hw", mode, 2)) pdata->engine_type = NAND_ECC_ENGINE_TYPE_ON_HOST; + if (!strncmp("on-die", mode, 6)) + pdata->engine_type = NAND_ECC_ENGINE_TYPE_ON_DIE; } if (!of_property_read_u32(pdev->dev.of_node, "ti,davinci-ecc-bits", &prop)) @@ -580,6 +583,7 @@ static int davinci_nand_attach_chip(struct nand_chip *chip) switch (chip->ecc.engine_type) { case NAND_ECC_ENGINE_TYPE_NONE: + case NAND_ECC_ENGINE_TYPE_ON_DIE: pdata->ecc_bits = 0; break; case NAND_ECC_ENGINE_TYPE_SOFT: @@ -914,4 +918,3 @@ module_platform_driver(nand_davinci_driver); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Texas Instruments"); MODULE_DESCRIPTION("Davinci NAND flash driver"); -