diff mbox series

[v1,1/1] mtd: rawnand: Remove unused of_gpio.h inclusion

Message ID 20230615164210.25515-1-andriy.shevchenko@linux.intel.com
State New
Delegated to: Miquel Raynal
Headers show
Series [v1,1/1] mtd: rawnand: Remove unused of_gpio.h inclusion | expand

Commit Message

Andy Shevchenko June 15, 2023, 4:42 p.m. UTC 
The of_gpio.h is not and shouldn't be used in the drivers. Remove it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mtd/nand/raw/nand_base.c | 1 -
 drivers/mtd/nand/raw/xway_nand.c | 1 -
 2 files changed, 2 deletions(-)

Comments

Martin Blumenstingl June 15, 2023, 10:10 p.m. UTC | #1 
On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Andy Shevchenko July 10, 2023, 10 a.m. UTC | #2 
On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:
> On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Thank you!

Can it be applied now?
Andy Shevchenko Oct. 6, 2023, 3:14 p.m. UTC | #3 
+Cc: GPIO maintainers

On Mon, Jul 10, 2023 at 01:00:51PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:
> > On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> Thank you!
> 
> Can it be applied now?

So, this is still not applied, does it mean we need to go via GPIO tree
with it?
Miquel Raynal Oct. 6, 2023, 3:41 p.m. UTC | #4 
Hi Andy,

andriy.shevchenko@linux.intel.com wrote on Fri, 6 Oct 2023 18:14:24
+0300:

> +Cc: GPIO maintainers
> 
> On Mon, Jul 10, 2023 at 01:00:51PM +0300, Andy Shevchenko wrote:
> > On Fri, Jun 16, 2023 at 12:10:52AM +0200, Martin Blumenstingl wrote:  
> > > On Thu, Jun 15, 2023 at 6:42 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:  
> > > >
> > > > The of_gpio.h is not and shouldn't be used in the drivers. Remove it.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>  
> > > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>  
> > 
> > Thank you!
> > 
> > Can it be applied now?  
> 
> So, this is still not applied, does it mean we need to go via GPIO tree
> with it?

I remember your ping and also answering it, but I cannot find it. Let
me look into this. In any case, apologies for that.

Thanks,
Miquèl
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index a6af521832aa..132e3bee8f5a 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -42,7 +42,6 @@ 
 #include <linux/io.h>
 #include <linux/mtd/partitions.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/gpio/consumer.h>
 
 #include "internals.h"
diff --git a/drivers/mtd/nand/raw/xway_nand.c b/drivers/mtd/nand/raw/xway_nand.c
index 6b1e2a2bba15..5a19b6b314b4 100644
--- a/drivers/mtd/nand/raw/xway_nand.c
+++ b/drivers/mtd/nand/raw/xway_nand.c
@@ -6,7 +6,6 @@ 
  */
 
 #include <linux/mtd/rawnand.h>
-#include <linux/of_gpio.h>
 #include <linux/of_platform.h>
 
 #include <lantiq_soc.h>