| Message ID | ca23d30e-7444-4490-a7f2-7020e8cf6fb9@omp.ru |
|---|---|
| State | New |
| Headers | show |
| Series | libata: get rid of (almost) all printk() calls | expand |
Hello! Oops, stray char after "of" in the subject... :-/ MBR, Sergey
On 11/8/24 21:16, Sergey Shtylyov wrote: > The ACard AHCI PCI device driver still calls printk(KERN_INFO, ...) in its > probe() method -- convert it to calling dev_info(), also somewhat rewording > the message itself... > > This helpfully fixes the following complaint from scripts/checkpatch.pl: > > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then > dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... > > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > > --- > drivers/ata/acard-ahci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c > index 547f56341705..0e16e64d1c5d 100644 > --- a/drivers/ata/acard-ahci.c > +++ b/drivers/ata/acard-ahci.c > @@ -415,7 +415,7 @@ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id > if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss) > host->flags |= ATA_HOST_PARALLEL_SCAN; > else > - printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n"); > + dev_info(&pdev->dev, "AHCI SSS flag set, parallel bus scan disabled\n"); > > for (i = 0; i < host->n_ports; i++) { > struct ata_port *ap = host->ports[i]; Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c index 547f56341705..0e16e64d1c5d 100644 --- a/drivers/ata/acard-ahci.c +++ b/drivers/ata/acard-ahci.c @@ -415,7 +415,7 @@ static int acard_ahci_init_one(struct pci_dev *pdev, const struct pci_device_id if (!(hpriv->cap & HOST_CAP_SSS) || ahci_ignore_sss) host->flags |= ATA_HOST_PARALLEL_SCAN; else - printk(KERN_INFO "ahci: SSS flag set, parallel bus scan disabled\n"); + dev_info(&pdev->dev, "AHCI SSS flag set, parallel bus scan disabled\n"); for (i = 0; i < host->n_ports; i++) { struct ata_port *ap = host->ports[i];
The ACard AHCI PCI device driver still calls printk(KERN_INFO, ...) in its probe() method -- convert it to calling dev_info(), also somewhat rewording the message itself... This helpfully fixes the following complaint from scripts/checkpatch.pl: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> --- drivers/ata/acard-ahci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)