From patchwork Wed Oct 16 13:18:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 1998056 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Or6Jb+Y+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:4601:e00::3; helo=am.mirrors.kernel.org; envelope-from=linux-ide+bounces-2443-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XTBQT21dwz1xth for ; Thu, 17 Oct 2024 00:19:45 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 19B091F24996 for ; Wed, 16 Oct 2024 13:19:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 834D420B20A; Wed, 16 Oct 2024 13:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Or6Jb+Y+" X-Original-To: linux-ide@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06B7020B208; Wed, 16 Oct 2024 13:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729084732; cv=none; b=So13ArxUyEmf7dgXzYU39WXNYhMrWO5E56E7n5+ClH8xjZ0ei2GQJwij4tSK2vfGL/ydRrmO21O8QS4v/OTIinYRyzv35+QRXWWNVxdnSAiFTzFlBWA1SoOIHZdtjtAEmZNn1vgZPTjukxQTyQQKHdkEI+uJHQV0+PK/z2d92+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729084732; c=relaxed/simple; bh=P2cJ3FrKw3YLzdNPSkhG/vqF3ynZpX9KZsrBVG+D0ZU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uBUD4ApGXiOnuux+J3GV6uSMn6FfI3DXwq7AX3XwNtEXXDbbT1suZogIuorP/TgogcmCskTbxN8rswGji4N3+Qkok8MHBgNCqrSA80B4t1SkH0dxrK1tDERXE0StukQ0zD5aeIUJIfhyx623tal/VsHSb3HzK8wfGXvpdwLQkbw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Or6Jb+Y+; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729084732; x=1760620732; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=P2cJ3FrKw3YLzdNPSkhG/vqF3ynZpX9KZsrBVG+D0ZU=; b=Or6Jb+Y+V86P+LK3PyBJl4JD4+dxQVFKVG3Idm/Hp61VmC7ZTh3zQ4S7 Ghj4QcbQbGIStKiF5R+SWRewPLuUusQpLC2vMKYvhkI+15WeRBqzKea0Q HOdbPMAWAGLyiZ3vqVHPEKYHTFPl1LDT53Pzwfklg02LWciHyiN6/YKUl T4yUXmiyJHOTa49NuXHUp52x3L8pB0dsJrTYy12exsCGvax90FZmhYwK3 r0asVphspU57/M3z/egqFj71OXXnn4LKenMIovmU1yKgN6mDB1PIRTAok bw6GvNjMxPdd9JomUtBeT5TugCyEFN01dXtnQevlYxwImznONgdncmUf0 Q==; X-CSE-ConnectionGUID: BwFvVJRHQVyd2ef6c4e8ig== X-CSE-MsgGUID: 7QP8N/MyRd+aEBONh/6A9A== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="51069921" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="51069921" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2024 06:18:51 -0700 X-CSE-ConnectionGUID: CMGgOgEdSBeLHWiax18p3g== X-CSE-MsgGUID: Xy7uRwpFRjaXlCW1A9CL1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,208,1725346800"; d="scan'208";a="82188313" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa003.fm.intel.com with ESMTP; 16 Oct 2024 06:18:49 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id D5A5C165; Wed, 16 Oct 2024 16:18:47 +0300 (EEST) From: Andy Shevchenko To: Niklas Cassel , Damien Le Moal , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v1 1/1] ata: libata-scsi: Refactor scsi_6_lba_len() with use of get_unaligned_be24() Date: Wed, 16 Oct 2024 16:18:44 +0300 Message-ID: <20241016131845.898632-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac Precedence: bulk X-Mailing-List: linux-ide@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Refactor scsi_6_lba_len() with use of get_unaligned_be24() to make it consistent with other similar helper implementations. Signed-off-by: Andy Shevchenko Reviewed-by: Damien Le Moal --- drivers/ata/libata-scsi.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index f915e3df57a9..4cef824cbafa 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1334,17 +1334,8 @@ static unsigned int ata_scsi_flush_xlat(struct ata_queued_cmd *qc) */ static void scsi_6_lba_len(const u8 *cdb, u64 *plba, u32 *plen) { - u64 lba = 0; - u32 len; - - lba |= ((u64)(cdb[1] & 0x1f)) << 16; - lba |= ((u64)cdb[2]) << 8; - lba |= ((u64)cdb[3]); - - len = cdb[4]; - - *plba = lba; - *plen = len; + *plba = get_unaligned_be24(&cdb[1]) & 0x1fffff; + *plen = cdb[4]; } /**