From patchwork Wed Sep 20 22:31:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajat Jain X-Patchwork-Id: 816537 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="GdfSLPvM"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xyDyX6KS2z9sBZ for ; Thu, 21 Sep 2017 08:32:36 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbdITWcI (ORCPT ); Wed, 20 Sep 2017 18:32:08 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:55047 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbdITWcH (ORCPT ); Wed, 20 Sep 2017 18:32:07 -0400 Received: by mail-pf0-f176.google.com with SMTP id d187so2226320pfg.11 for ; Wed, 20 Sep 2017 15:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HQh9Gz/eJFBZH43xZboGEEARfEEHvYhLW5huw3a8Lro=; b=GdfSLPvMmCNymtk+gLy50Jh1BmZAezZ8I/ftUuWnUgpzQZhboX2I4/ABDzU/WfPuL3 yDZZLK4Q81dwoDI6cJoVykwkJY/oPO5/qucT9iSwkwsLP1UlXHcBMraE/mMyDNJa5EWj ZyLSVQ9ZTB5+PtSsHJRvvjuwLJztq4l8Oi9R9PMam9VWPgzz2vSYI9EJ2C/QqGg7Tn5s jjlaGClMc/OJd6jyrj1LBwZ0Oi0VRm/rtT7jCnkzgTrLsx49S8ps/+XqJv9htoVwUIBD B//BxILF+tWTDhuuWm6ukS+P6hQPJqAijNfOZWXcfQlEstIBXviZc5884EvhZg45IthX /PZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HQh9Gz/eJFBZH43xZboGEEARfEEHvYhLW5huw3a8Lro=; b=ffzBBqoZNDzJdywtSQA/0E7hKLcVYnSR7vf0+PYkswvkuVVGRN3hLWxeYlTBFC1TPd kBliLUHrQlGrmJzxMINfsI/uN55Rsg8LS0K6DcvcMBvcjEeEEOW1xEitlgUl2eyUt20b 0p9HPra9ommO2p4u1aPmUbTjAML1jUisMrpFy9H5TXbHAmF4++cAxDOTd6kytNhxmdip dSZbAOLPIXDZJHKtDOlhVjsUXUAYkv8xfmD/tafLwBXpwEYrvX1rHYioq9/MFKK3zVPT BT99Btg/ea0gUHAXQlQan0J52ymZKs/ZpRO+THLBAcmBtsyvownSJNCdd82hm9u5bBI9 RGaw== X-Gm-Message-State: AHPjjUh7YNdbRwJD36MxZ6Qn/BMbshMpk9W8uZlEPqKxoMOdC9IyHEXK xpFqHRJO9/vau6+30bOONmzqmg== X-Google-Smtp-Source: AOwi7QBKS/Wmyy5Ubc4DMBnpEG7fBu2+6Nxtz2XZHMljl9N0GyHYRBoymNynnWAQCa224eSPuahSWA== X-Received: by 10.101.69.8 with SMTP id n8mr3615920pgq.167.1505946726604; Wed, 20 Sep 2017 15:32:06 -0700 (PDT) Received: from rajat.mtv.corp.google.com ([172.22.112.48]) by smtp.gmail.com with ESMTPSA id k78sm10871733pfb.157.2017.09.20.15.32.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Sep 2017 15:32:05 -0700 (PDT) From: Rajat Jain To: Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , "Wysocki, Rafael J" , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Len Brown , furquan@google.com, rajatxjain@gmail.com Cc: Rajat Jain Subject: [PATCH 1/2] i2c: designware: switch to suspend_late/resume_early Date: Wed, 20 Sep 2017 15:31:51 -0700 Message-Id: <20170920223152.100641-1-rajatja@google.com> X-Mailer: git-send-email 2.14.1.821.g8fa685d3b7-goog Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Ref: https://lkml.org/lkml/2017/9/19/649 The bus controllers should suspend the bus operations only after all of the devices on the bus have suspended their device completely. Since the i2c_client drivers could be talking to their devices in their suspend_late() calls, lets ensure that the bus is alive by that time. Thus moving the controller suspend logic to suspend_late(). Signed-off-by: Rajat Jain Tested-by: Rajat Jain --- drivers/i2c/busses/i2c-designware-platdrv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 0e65b97842b4..66dd7f844c40 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -468,7 +468,7 @@ static int dw_i2c_plat_suspend(struct device *dev) static const struct dev_pm_ops dw_i2c_dev_pm_ops = { .prepare = dw_i2c_plat_prepare, .complete = dw_i2c_plat_complete, - SET_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) + SET_LATE_SYSTEM_SLEEP_PM_OPS(dw_i2c_plat_suspend, dw_i2c_plat_resume) SET_RUNTIME_PM_OPS(dw_i2c_plat_runtime_suspend, dw_i2c_plat_resume, NULL)