mbox series

[v11,0/2] i2c: octeon: Add block-mode r/w

Message ID 20250120023327.2347863-1-aryan.srivastava@alliedtelesis.co.nz
Headers show
Series i2c: octeon: Add block-mode r/w | expand

Message

Aryan Srivastava Jan. 20, 2025, 2:33 a.m. UTC
Add support for block mode read/write operations on
Thunderx chips.

-Refactor common code for i2c transactions.
-Add block mode transaction functionality.

Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
---
Changes in v2:
- comment style and formatting.

Changes in v3:
- comment style and formatting.

Changes in v4:
- Refactoring common code.
- Additional comments.

Changes in v5:
- Further refactoring.
- Split refactoring into separate patch in series.
- Add more comments + details to comments.

Changes in v6:
- Reword/reformat commit messages

Changes in v7:
- Fix typo in commit message.
- Remove usage of r/w and hlc abbreviations from commits.

Changes in v8:
- Updated refactor commit msg with more information.
- Rebased patch

Changes in v9:
- Rebased patch against i2c-host

Changes in v10:
- Fixed unitialised variable

Changes in v10:
- Rebased patch against i2c-host

Aryan Srivastava (2):
  i2c: octeon: refactor common i2c operations
  i2c: octeon: Add block-mode i2c operations

 drivers/i2c/busses/i2c-octeon-core.c     | 241 +++++++++++++++++++----
 drivers/i2c/busses/i2c-octeon-core.h     |  13 +-
 drivers/i2c/busses/i2c-thunderx-pcidrv.c |   3 +
 3 files changed, 213 insertions(+), 44 deletions(-)

Comments

Andi Shyti Feb. 13, 2025, 10:19 p.m. UTC | #1
Hi Aryan,

> Aryan Srivastava (2):
>   i2c: octeon: refactor common i2c operations
>   i2c: octeon: Add block-mode i2c operations

merged to i2c/i2c-host.

Andi
Wolfram Sang Feb. 14, 2025, 9:10 a.m. UTC | #2
On Thu, Feb 13, 2025 at 11:19:19PM +0100, Andi Shyti wrote:
> Hi Aryan,
> 
> > Aryan Srivastava (2):
> >   i2c: octeon: refactor common i2c operations
> >   i2c: octeon: Add block-mode i2c operations
> 
> merged to i2c/i2c-host.

Andy had comments to v10.
Andi Shyti Feb. 14, 2025, 1:50 p.m. UTC | #3
On Fri, Feb 14, 2025 at 10:10:27AM +0100, Wolfram Sang wrote:
> On Thu, Feb 13, 2025 at 11:19:19PM +0100, Andi Shyti wrote:
> > Hi Aryan,
> > 
> > > Aryan Srivastava (2):
> > >   i2c: octeon: refactor common i2c operations
> > >   i2c: octeon: Add block-mode i2c operations
> > 
> > merged to i2c/i2c-host.
> 
> Andy had comments to v10.

Actually I had this patch applied locally in my branch from
before my disappearance and pushed it last night.

I will check those comments and revert if necessary.

Andi
Andi Shyti Feb. 18, 2025, 10:04 p.m. UTC | #4
Hi Aryan,

> Aryan Srivastava (2):
>   i2c: octeon: refactor common i2c operations
>   i2c: octeon: Add block-mode i2c operations

I'm going to keep the first patch and remove the second patch.
Please follow Andy's suggestions and resend the second patch,
please.

Andi