diff mbox series

[v3,20/25] ASoC: dt-bindings: renesas,rz-ssi: Document the Renesas RZ/G3S SoC

Message ID 20241113133540.2005850-21-claudiu.beznea.uj@bp.renesas.com
State New
Headers show
Series Add audio support for the Renesas RZ/G3S SoC | expand

Commit Message

Claudiu Beznea Nov. 13, 2024, 1:35 p.m. UTC 
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

The SSI IP variant present on the Renesas RZ/G3S SoC is similar to the
one found on the Renesas RZ/G2{UL, L, LC} SoCs. Add documentation for
it.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---

Changes in v3:
- none

Changes in v2:
- collected tags

 Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven Dec. 9, 2024, 2:24 p.m. UTC | #1 
Hi Claudiu,

On Wed, Nov 13, 2024 at 2:36 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> The SSI IP variant present on the Renesas RZ/G3S SoC is similar to the
> one found on the Renesas RZ/G2{UL, L, LC} SoCs. Add documentation for
> it.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> @@ -19,6 +19,7 @@ properties:
>            - renesas,r9a07g043-ssi  # RZ/G2UL and RZ/Five
>            - renesas,r9a07g044-ssi  # RZ/G2{L,LC}
>            - renesas,r9a07g054-ssi  # RZ/V2L
> +          - renesas,r9a08g045-ssi  # RZ/G3S
>        - const: renesas,rz-ssi

This part is fine.

The section about the dmas properties also needs an update, as the
documented MID/RID values do not apply to RZ/G3S.  I recommend just
dropping the list of values.  People should look them up in the
hardware documentation.

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven Dec. 9, 2024, 2:36 p.m. UTC | #2 
On Mon, Dec 9, 2024 at 3:24 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Nov 13, 2024 at 2:36 PM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >
> > The SSI IP variant present on the Renesas RZ/G3S SoC is similar to the
> > one found on the Renesas RZ/G2{UL, L, LC} SoCs. Add documentation for
> > it.
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > @@ -19,6 +19,7 @@ properties:
> >            - renesas,r9a07g043-ssi  # RZ/G2UL and RZ/Five
> >            - renesas,r9a07g044-ssi  # RZ/G2{L,LC}
> >            - renesas,r9a07g054-ssi  # RZ/V2L
> > +          - renesas,r9a08g045-ssi  # RZ/G3S
> >        - const: renesas,rz-ssi
>
> This part is fine.
>
> The section about the dmas properties also needs an update, as the
> documented MID/RID values do not apply to RZ/G3S.  I recommend just
> dropping the list of values.  People should look them up in the
> hardware documentation.

Actually the whole dma description can be dropped, as its format
is duplicated from, and dictated by .../dma/renesas,rz-dmac.yaml.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
index f4610eaed1e1..cab615f79ee4 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
@@ -19,6 +19,7 @@  properties:
           - renesas,r9a07g043-ssi  # RZ/G2UL and RZ/Five
           - renesas,r9a07g044-ssi  # RZ/G2{L,LC}
           - renesas,r9a07g054-ssi  # RZ/V2L
+          - renesas,r9a08g045-ssi  # RZ/G3S
       - const: renesas,rz-ssi
 
   reg: