diff mbox series

tools: gpio: Fix several incorrect format specifiers

Message ID 20241113021458.291252-1-luoyifan@cmss.chinamobile.com
State New
Headers show
Series tools: gpio: Fix several incorrect format specifiers | expand

Commit Message

Luo Yifan Nov. 13, 2024, 2:14 a.m. UTC 
Make a minor change to eliminate static checker warnings. The variable
lines[] is unsigned, so the correct format specifier should be %u
instead of %d.

Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
---
 tools/gpio/gpio-event-mon.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Bartosz Golaszewski Nov. 13, 2024, 3:31 p.m. UTC | #1 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 13 Nov 2024 10:14:58 +0800, Luo Yifan wrote:
> Make a minor change to eliminate static checker warnings. The variable
> lines[] is unsigned, so the correct format specifier should be %u
> instead of %d.
> 
> 

Applied, thanks!

[1/1] tools: gpio: Fix several incorrect format specifiers
      commit: b6621b1d4b1d0459ba6b49c0bc498c352ac115ab

Best regards,
diff mbox series

Patch

diff --git a/tools/gpio/gpio-event-mon.c b/tools/gpio/gpio-event-mon.c
index 5dee2b98a..b70813b0b 100644
--- a/tools/gpio/gpio-event-mon.c
+++ b/tools/gpio/gpio-event-mon.c
@@ -69,14 +69,14 @@  int monitor_device(const char *device_name,
 	}
 
 	if (num_lines == 1) {
-		fprintf(stdout, "Monitoring line %d on %s\n", lines[0], device_name);
+		fprintf(stdout, "Monitoring line %u on %s\n", lines[0], device_name);
 		fprintf(stdout, "Initial line value: %d\n",
 			gpiotools_test_bit(values.bits, 0));
 	} else {
-		fprintf(stdout, "Monitoring lines %d", lines[0]);
+		fprintf(stdout, "Monitoring lines %u", lines[0]);
 		for (i = 1; i < num_lines - 1; i++)
-			fprintf(stdout, ", %d", lines[i]);
-		fprintf(stdout, " and %d on %s\n", lines[i], device_name);
+			fprintf(stdout, ", %u", lines[i]);
+		fprintf(stdout, " and %u on %s\n", lines[i], device_name);
 		fprintf(stdout, "Initial line values: %d",
 			gpiotools_test_bit(values.bits, 0));
 		for (i = 1; i < num_lines - 1; i++)