| Message ID | 20241106142248.305219-1-vfazio@xes-inc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [libgpiod] bindings: python: generate CPython 3.13 wheels | expand |
On Wed, Nov 6, 2024 at 3:32 PM Vincent Fazio <vfazio@xes-inc.com> wrote: > > Support for CPython 3.13 was added to cibuildwheel in 2.21.3 and > advertised by build in 1.2.2.post1. > > Update the dependencies used by generate_pypi_artifacts.sh so CPython > 3.13 wheels are now generated. > > Closes: https://github.com/brgl/libgpiod/issues/106 > Signed-off-by: Vincent Fazio <vfazio@xes-inc.com> > --- > bindings/python/generate_pypi_artifacts.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/bindings/python/generate_pypi_artifacts.sh b/bindings/python/generate_pypi_artifacts.sh > index c2fb79f..d5dbd31 100755 > --- a/bindings/python/generate_pypi_artifacts.sh > +++ b/bindings/python/generate_pypi_artifacts.sh > @@ -108,8 +108,7 @@ python3 -m "${venv_module}" .venv > venv_python="${temp_dir}/.venv/bin/python" > > # Install build dependencies > -# cibuildwheel 2.18.1 pins the toolchain containers to 2024-05-13-0983f6f > -${venv_python} -m pip install build==1.2.1 cibuildwheel==2.18.1 > +${venv_python} -m pip install build==1.2.2.post1 cibuildwheel==2.21.3 > > LIBGPIOD_VERSION=${src_version} ${venv_python} -m build --sdist --outdir ./dist "${source_dir}" > sdist=$(find ./dist -name '*.tar.gz') > -- > 2.34.1 > > Did I get that right on github - this should wait until the typing and other reworks are in place? Bart
On Tue, Nov 12, 2024 at 6:46 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > Did I get that right on github - this should wait until the typing and > other reworks are in place? I think we can wait to _generate_ wheels after the typing rework is done, but I don't think there's any real reason to delay accepting this patch if the content looks ok to you -Vincent
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Wed, 06 Nov 2024 08:22:48 -0600, Vincent Fazio wrote: > Support for CPython 3.13 was added to cibuildwheel in 2.21.3 and > advertised by build in 1.2.2.post1. > > Update the dependencies used by generate_pypi_artifacts.sh so CPython > 3.13 wheels are now generated. > > > [...] Applied, thanks! [1/1] bindings: python: generate CPython 3.13 wheels commit: e376cb63349c7f78ac97d7c2208b5330a7351a9e Best regards,
On Tue, Nov 12, 2024 at 1:53 PM Vincent Fazio <vfazio@gmail.com> wrote: > > On Tue, Nov 12, 2024 at 6:46 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > > Did I get that right on github - this should wait until the typing and > > other reworks are in place? > > I think we can wait to _generate_ wheels after the typing rework is done, but I > don't think there's any real reason to delay accepting this patch if the > content looks ok to you > Fair enough, applied. Bart
diff --git a/bindings/python/generate_pypi_artifacts.sh b/bindings/python/generate_pypi_artifacts.sh index c2fb79f..d5dbd31 100755 --- a/bindings/python/generate_pypi_artifacts.sh +++ b/bindings/python/generate_pypi_artifacts.sh @@ -108,8 +108,7 @@ python3 -m "${venv_module}" .venv venv_python="${temp_dir}/.venv/bin/python" # Install build dependencies -# cibuildwheel 2.18.1 pins the toolchain containers to 2024-05-13-0983f6f -${venv_python} -m pip install build==1.2.1 cibuildwheel==2.18.1 +${venv_python} -m pip install build==1.2.2.post1 cibuildwheel==2.21.3 LIBGPIOD_VERSION=${src_version} ${venv_python} -m build --sdist --outdir ./dist "${source_dir}" sdist=$(find ./dist -name '*.tar.gz')
Support for CPython 3.13 was added to cibuildwheel in 2.21.3 and advertised by build in 1.2.2.post1. Update the dependencies used by generate_pypi_artifacts.sh so CPython 3.13 wheels are now generated. Closes: https://github.com/brgl/libgpiod/issues/106 Signed-off-by: Vincent Fazio <vfazio@xes-inc.com> --- bindings/python/generate_pypi_artifacts.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)