diff mbox series

[08/51] gpio: Switch to __pm_runtime_put_autosuspend()

Message ID 20241004094112.113487-1-sakari.ailus@linux.intel.com
State New
Headers show
Series treewide: Switch to __pm_runtime_put_autosuspend() | expand

Commit Message

Sakari Ailus Oct. 4, 2024, 9:41 a.m. UTC
pm_runtime_put_autosuspend() will soon be changed to include a call to
pm_runtime_mark_last_busy(). This patch switches the current users to
__pm_runtime_put_autosuspend() which will continue to have the
functionality of old pm_runtime_put_autosuspend().

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/gpio/gpio-arizona.c | 10 +++++-----
 drivers/gpio/gpio-mxc.c     |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Bartosz Golaszewski Oct. 4, 2024, 9:55 a.m. UTC | #1
On Fri, Oct 4, 2024 at 11:41 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> pm_runtime_put_autosuspend() will soon be changed to include a call to
> pm_runtime_mark_last_busy(). This patch switches the current users to
> __pm_runtime_put_autosuspend() which will continue to have the
> functionality of old pm_runtime_put_autosuspend().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---

Sakari,

You didn't Cc me on the cover letter, please do it next time whenever
you post such a big series.

I got the cover letter from lore but it doesn't explain how this will
be merged, are there prerequisites earlier in the series? Or are the
patches independent? If the latter, why not send them separately
targeting individual subsystems?

Bart
Sakari Ailus Oct. 4, 2024, 10:08 a.m. UTC | #2
Hi Bart,

On Fri, Oct 04, 2024 at 11:55:01AM +0200, Bartosz Golaszewski wrote:
> On Fri, Oct 4, 2024 at 11:41 AM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > pm_runtime_put_autosuspend() will soon be changed to include a call to
> > pm_runtime_mark_last_busy(). This patch switches the current users to
> > __pm_runtime_put_autosuspend() which will continue to have the
> > functionality of old pm_runtime_put_autosuspend().
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> 
> Sakari,
> 
> You didn't Cc me on the cover letter, please do it next time whenever
> you post such a big series.

I thought of that but it would have included 120 more recipients. That
wouldn't make it through to most lists.

> 
> I got the cover letter from lore but it doesn't explain how this will
> be merged, are there prerequisites earlier in the series? Or are the
> patches independent? If the latter, why not send them separately
> targeting individual subsystems?

This patch can be merged independently and my intention was the tree
maintainers could pick them.
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c
index c15fda99120a..692983da7949 100644
--- a/drivers/gpio/gpio-arizona.c
+++ b/drivers/gpio/gpio-arizona.c
@@ -40,7 +40,7 @@  static int arizona_gpio_direction_in(struct gpio_chip *chip, unsigned offset)
 
 	if (change && persistent) {
 		pm_runtime_mark_last_busy(chip->parent);
-		pm_runtime_put_autosuspend(chip->parent);
+		__pm_runtime_put_autosuspend(chip->parent);
 	}
 
 	return 0;
@@ -63,7 +63,7 @@  static int arizona_gpio_get(struct gpio_chip *chip, unsigned offset)
 		ret = pm_runtime_get_sync(chip->parent);
 		if (ret < 0) {
 			dev_err(chip->parent, "Failed to resume: %d\n", ret);
-			pm_runtime_put_autosuspend(chip->parent);
+			__pm_runtime_put_autosuspend(chip->parent);
 			return ret;
 		}
 
@@ -72,18 +72,18 @@  static int arizona_gpio_get(struct gpio_chip *chip, unsigned offset)
 		if (ret < 0) {
 			dev_err(chip->parent, "Failed to drop cache: %d\n",
 				ret);
-			pm_runtime_put_autosuspend(chip->parent);
+			__pm_runtime_put_autosuspend(chip->parent);
 			return ret;
 		}
 
 		ret = regmap_read(arizona->regmap, reg, &val);
 		if (ret < 0) {
-			pm_runtime_put_autosuspend(chip->parent);
+			__pm_runtime_put_autosuspend(chip->parent);
 			return ret;
 		}
 
 		pm_runtime_mark_last_busy(chip->parent);
-		pm_runtime_put_autosuspend(chip->parent);
+		__pm_runtime_put_autosuspend(chip->parent);
 	}
 
 	if (val & ARIZONA_GPN_LVL)
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index 4cb455b2bdee..ea7e7d28aa19 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -520,7 +520,7 @@  static int mxc_gpio_probe(struct platform_device *pdev)
 	list_add_tail(&port->node, &mxc_gpio_ports);
 
 	platform_set_drvdata(pdev, port);
-	pm_runtime_put_autosuspend(&pdev->dev);
+	__pm_runtime_put_autosuspend(&pdev->dev);
 
 	return 0;