| Message ID | 20240329105634.712457-12-andy.shevchenko@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | aw9523: number of cleanups | expand |
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on linusw-pinctrl/for-next linus/master v6.9-rc2 next-20240402]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/pinctrl-aw9523-Destroy-mutex-on-remove/20240329-185957
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20240329105634.712457-12-andy.shevchenko%40gmail.com
patch subject: [PATCH v2 11/11] pinctrl: aw9523: Remove redundant dependency to OF
config: i386-randconfig-054-20240401 (https://download.01.org/0day-ci/archive/20240402/202404021642.1I0w7URO-lkp@intel.com/config)
compiler: gcc-12 (Ubuntu 12.3.0-9ubuntu2) 12.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240402/202404021642.1I0w7URO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404021642.1I0w7URO-lkp@intel.com/
All errors (new ones prefixed by >>):
ld: drivers/pinctrl/pinctrl-aw9523.o: in function `pinconf_generic_dt_node_to_map_pin':
include/linux/pinctrl/pinconf-generic.h:216:(.text+0x891): undefined reference to `pinconf_generic_dt_node_to_map'
>> ld: drivers/pinctrl/pinctrl-aw9523.o:(.rodata+0x4f4): undefined reference to `pinconf_generic_dt_free_map'
On Fri, Mar 29, 2024 at 11:56 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > Driver does not dependent on OF, remove it. > While here, add missing mod_devicetable.h. > > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> Oh the kbuild complains about this one because the driver uses some DT-only helpers. How typical. I kept patches 1-10 and dropped this one. Yours, Linus Walleij
On Thu, Apr 4, 2024 at 2:20 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Mar 29, 2024 at 11:56 AM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > Driver does not dependent on OF, remove it. > > While here, add missing mod_devicetable.h. > > > > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Oh the kbuild complains about this one because the driver uses some > DT-only helpers. How typical. I kept patches 1-10 and dropped this > one. Thanks, you beat me to it, I was wanting to ask you to do exactly this.
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index d45657aa986ae..c413109b1173b 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -129,7 +129,7 @@ config PINCTRL_AXP209 config PINCTRL_AW9523 tristate "Awinic AW9523/AW9523B I2C GPIO expander pinctrl driver" - depends on OF && I2C + depends on I2C select PINMUX select PINCONF select GENERIC_PINCONF diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9523.c index b5e1c467625ba..1d0ce78115da7 100644 --- a/drivers/pinctrl/pinctrl-aw9523.c +++ b/drivers/pinctrl/pinctrl-aw9523.c @@ -12,6 +12,7 @@ #include <linux/init.h> #include <linux/interrupt.h> #include <linux/irq.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> #include <linux/mutex.h> #include <linux/property.h>
Driver does not dependent on OF, remove it. While here, add missing mod_devicetable.h. Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/pinctrl/Kconfig | 2 +- drivers/pinctrl/pinctrl-aw9523.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-)