From patchwork Tue Jul 12 14:19:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 647411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rpkfY6jdCz9s6r for ; Wed, 13 Jul 2016 00:21:25 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b=SkfCowEe; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711AbcGLOVY (ORCPT ); Tue, 12 Jul 2016 10:21:24 -0400 Received: from m12-14.163.com ([220.181.12.14]:40131 "EHLO m12-14.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116AbcGLOVW (ORCPT ); Tue, 12 Jul 2016 10:21:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=giBWB v+2sHopcNo+zRY5TPkoyaDb+UMiNmrjX4KbzwM=; b=SkfCowEe2VI1Ez+RA9gKC DQ60Sjq7CC7HMvr9F0jkp8/TEZZZMMGVT+khNSR5+sLhxFka4EL24xujIpTg+7gh 1Wfp8Bq76V9xEj+YM+FPLJdeIva6XfhcYlEpw7Zalb61ilenMjXrogocYOAmW8bd Ge3RInjRDI2U8PdSum1yT0= Received: from localhost.localdomain.localdomain (unknown [180.102.101.186]) by smtp10 (Coremail) with SMTP id DsCowAB3BKKL_IRXJ7W6AQ--.27449S2; Tue, 12 Jul 2016 22:19:57 +0800 (CST) From: weiyj_lk@163.com To: Ray Jui , Scott Branden , Jon Mason , Linus Walleij Cc: Wei Yongjun , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH -next] pinctrl: ns2: remove redundant dev_err call in ns2_pinmux_probe() Date: Tue, 12 Jul 2016 14:19:45 +0000 Message-Id: <1468333185-8047-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: DsCowAB3BKKL_IRXJ7W6AQ--.27449S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxJF17JryrZrW8AF4xtw45Awb_yoW8Xw18pF s3tFsa9Fn8GF43G34rtw4kuF13C3WI9w43G3yjgr93Zas8JryDJw4FgFW5Crs5CFWvkw45 tr13XryDZFy8WFUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jvVbkUUUUU= X-Originating-IP: [180.102.101.186] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbiJQ2k1lUMAunnngAAsR Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Acked-by: Ray Jui --- drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c index 7e5f7b7..ca81789 100644 --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c @@ -1044,10 +1044,8 @@ static int ns2_pinmux_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); pinctrl->base0 = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pinctrl->base0)) { - dev_err(&pdev->dev, "unable to map I/O space\n"); + if (IS_ERR(pinctrl->base0)) return PTR_ERR(pinctrl->base0); - } res = platform_get_resource(pdev, IORESOURCE_MEM, 1); pinctrl->base1 = devm_ioremap_nocache(&pdev->dev, res->start, @@ -1059,10 +1057,8 @@ static int ns2_pinmux_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 2); pinctrl->pinconf_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pinctrl->pinconf_base)) { - dev_err(&pdev->dev, "unable to map I/O space\n"); + if (IS_ERR(pinctrl->pinconf_base)) return PTR_ERR(pinctrl->pinconf_base); - } ret = ns2_mux_log_init(pinctrl); if (ret) {