From patchwork Wed Jul 6 12:17:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 645246 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rl0CZ56Xxz9sBl for ; Wed, 6 Jul 2016 22:18:34 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b=mBEKHU/O; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753939AbcGFMSd (ORCPT ); Wed, 6 Jul 2016 08:18:33 -0400 Received: from m12-16.163.com ([220.181.12.16]:54734 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753932AbcGFMSc (ORCPT ); Wed, 6 Jul 2016 08:18:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=IrJHw bP/vxH6wXJJSfhVo9Y8wTZq0kUxJAjeRAfgClU=; b=mBEKHU/OIosLGbmYq9hhX vCBl59Yj8Ex5tk6t+EFWTm5wATeBx9lytlkM5sOjdL3mCT3VC2YDC3F45/pc9WPp lzKdUto4Y8s8jgPHXSOYVzEMsGSjxmrkCL4AzgHgfetNa8lfAFxW5UOl9DQZQvna U0ULAGRTZrr97TBYg2GEA8= Received: from localhost.localdomain.localdomain (unknown [49.77.207.185]) by smtp12 (Coremail) with SMTP id EMCowAAXH1fl9nxXb4eIAw--.40986S2; Wed, 06 Jul 2016 20:17:42 +0800 (CST) From: weiyj_lk@163.com To: Linus Walleij , Yendapally Reddy Dhananjaya Reddy Cc: Wei Yongjun , linux-gpio@vger.kernel.org Subject: [PATCH -next] pinctrl: ns2: fix return value check in ns2_pinmux_probe() Date: Wed, 6 Jul 2016 12:17:41 +0000 Message-Id: <1467807461-31096-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: EMCowAAXH1fl9nxXb4eIAw--.40986S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4kXryUtw4UGF47XFyxZrb_yoWDGrgEkF yDGrykCryDGFnFqrWjkrW5ZFySyF4DXF4FgrnYqa43G34UJw15tr95CryDW3ykWrs7tFWU Jr1jqw1fAr17AjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnBOJ5UUUUU== X-Originating-IP: [49.77.207.185] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbivwae1lWBS0QfzgAAs7 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Wei Yongjun In case of error, the function pinctrl_register() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun --- drivers/pinctrl/bcm/pinctrl-ns2-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c index 3fefd14..7e5f7b7 100644 --- a/drivers/pinctrl/bcm/pinctrl-ns2-mux.c +++ b/drivers/pinctrl/bcm/pinctrl-ns2-mux.c @@ -1089,9 +1089,9 @@ static int ns2_pinmux_probe(struct platform_device *pdev) pinctrl->pctl = pinctrl_register(&ns2_pinctrl_desc, &pdev->dev, pinctrl); - if (!pinctrl->pctl) { + if (IS_ERR(pinctrl->pctl)) { dev_err(&pdev->dev, "unable to register IOMUX pinctrl\n"); - return -EINVAL; + return PTR_ERR(pinctrl->pctl); } return 0;