| Message ID | 1421876028-22799-4-git-send-email-o.schinagl@ultimaker.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl <o.schinagl@ultimaker.com> wrote: > From: Olliver Schinagl <oliver@schinagl.nl> > > In the gpio bindings documents it is requested to use the marco's in > include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led > drivers don't seem to form an exception, so update the example in the > document bindings. > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > Acked-by: Rob Herring <robh@kernel.org> > Acked-by: Linus Walleij <linus.walleij@linaro.org> Bryan: please merge this patch to the LED git tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 2, 2015 at 3:24 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl > <o.schinagl@ultimaker.com> wrote: > >> From: Olliver Schinagl <oliver@schinagl.nl> >> >> In the gpio bindings documents it is requested to use the marco's in >> include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led >> drivers don't seem to form an exception, so update the example in the >> document bindings. >> >> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> >> Acked-by: Rob Herring <robh@kernel.org> >> Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Bryan: please merge this patch to the LED git tree. > Merged, thanks -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/leds/leds-gpio.txt b/Documentation/devicetree/bindings/leds/leds-gpio.txt index f77148f..fea1ebf 100644 --- a/Documentation/devicetree/bindings/leds/leds-gpio.txt +++ b/Documentation/devicetree/bindings/leds/leds-gpio.txt @@ -26,16 +26,18 @@ LED sub-node properties: Examples: +#include <dt-bindings/gpio/gpio.h> + leds { compatible = "gpio-leds"; hdd { label = "IDE Activity"; - gpios = <&mcu_pio 0 1>; /* Active low */ + gpios = <&mcu_pio 0 GPIO_ACTIVE_LOW>; linux,default-trigger = "ide-disk"; }; fault { - gpios = <&mcu_pio 1 0>; + gpios = <&mcu_pio 1 GPIO_ACTIVE_HIGH>; /* Keep LED on if BIOS detected hardware fault */ default-state = "keep"; }; @@ -44,11 +46,11 @@ leds { run-control { compatible = "gpio-leds"; red { - gpios = <&mpc8572 6 0>; + gpios = <&mpc8572 6 GPIO_ACTIVE_HIGH>; default-state = "off"; }; green { - gpios = <&mpc8572 7 0>; + gpios = <&mpc8572 7 GPIO_ACTIVE_HIGH>; default-state = "on"; }; }; @@ -57,7 +59,7 @@ leds { compatible = "gpio-leds"; charger-led { - gpios = <&gpio1 2 0>; + gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; linux,default-trigger = "max8903-charger-charging"; retain-state-suspended; };