mbox series

[0/2] pinctrl: intel: platform: fix error path in device_for_each_child_node()

Message ID 20240926-intel-pinctrl-platform-scoped-v1-0-5ee4c936eea3@gmail.com
Headers show
Series pinctrl: intel: platform: fix error path in device_for_each_child_node() | expand

Message

Javier Carrasco Sept. 26, 2024, 2:11 p.m. UTC
This series fixes an error path where the reference of a child node is
not decremented upon early return. When at it, a trivial comma/semicolon
substitution I found by chance has been added to improve code clarity.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Javier Carrasco (2):
      pinctrl: intel: platform: fix error path in device_for_each_child_node()
      pinctrl: intel: platform: use semicolon instead of comma in ncommunities assignment

 drivers/pinctrl/intel/pinctrl-intel-platform.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
---
base-commit: 92fc9636d1471b7f68bfee70c776f7f77e747b97
change-id: 20240926-intel-pinctrl-platform-scoped-68d000ba3c1d

Best regards,

Comments

Mika Westerberg Sept. 27, 2024, 5 a.m. UTC | #1
On Thu, Sep 26, 2024 at 04:11:01PM +0200, Javier Carrasco wrote:
> This series fixes an error path where the reference of a child node is
> not decremented upon early return. When at it, a trivial comma/semicolon
> substitution I found by chance has been added to improve code clarity.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> Javier Carrasco (2):
>       pinctrl: intel: platform: fix error path in device_for_each_child_node()
>       pinctrl: intel: platform: use semicolon instead of comma in ncommunities assignment

Both,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Andy Shevchenko Sept. 30, 2024, 11:32 a.m. UTC | #2
On Thu, Sep 26, 2024 at 04:11:01PM +0200, Javier Carrasco wrote:
> This series fixes an error path where the reference of a child node is
> not decremented upon early return. When at it, a trivial comma/semicolon
> substitution I found by chance has been added to improve code clarity.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> Javier Carrasco (2):
>       pinctrl: intel: platform: fix error path in device_for_each_child_node()
>       pinctrl: intel: platform: use semicolon instead of comma in ncommunities assignment
> 
>  drivers/pinctrl/intel/pinctrl-intel-platform.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> ---
> base-commit: 92fc9636d1471b7f68bfee70c776f7f77e747b97

Try hard to avoid basing your commits on Linux Next. This is a specific
subsystem and you can just use Intel pinctrl tree for that.

No need to resend this time, I fixed the issue manually.