| Message ID | 20241224202707.1530558-5-shikemeng@huaweicloud.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Minor cleanups to jbd2 | expand |
On Wed 25-12-24 04:27:05, Kemeng Shi wrote: > Commit 2d44292058828 "jbd2: remove CONFIG_JBD2_DEBUG to update t_max_wait" > removed jbd2_journal_enable_debug, just remove stale comment about > jbd2_journal_enable_debug. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Sure. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/jbd2/transaction.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c > index 66513c18ca29..e00b87635512 100644 > --- a/fs/jbd2/transaction.c > +++ b/fs/jbd2/transaction.c > @@ -119,7 +119,6 @@ static void jbd2_get_transaction(journal_t *journal, > * t_max_wait is carefully updated here with use of atomic compare exchange. > * Note that there could be multiplre threads trying to do this simultaneously > * hence using cmpxchg to avoid any use of locks in this case. > - * With this t_max_wait can be updated w/o enabling jbd2_journal_enable_debug. > */ > static inline void update_t_max_wait(transaction_t *transaction, > unsigned long ts) > -- > 2.30.0 >
On 2024/12/25 4:27, Kemeng Shi wrote: > Commit 2d44292058828 "jbd2: remove CONFIG_JBD2_DEBUG to update t_max_wait" > removed jbd2_journal_enable_debug, just remove stale comment about > jbd2_journal_enable_debug. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > fs/jbd2/transaction.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c > index 66513c18ca29..e00b87635512 100644 > --- a/fs/jbd2/transaction.c > +++ b/fs/jbd2/transaction.c > @@ -119,7 +119,6 @@ static void jbd2_get_transaction(journal_t *journal, > * t_max_wait is carefully updated here with use of atomic compare exchange. > * Note that there could be multiplre threads trying to do this simultaneously > * hence using cmpxchg to avoid any use of locks in this case. > - * With this t_max_wait can be updated w/o enabling jbd2_journal_enable_debug. > */ > static inline void update_t_max_wait(transaction_t *transaction, > unsigned long ts) Hi, Kemeng, It seems that the first sentence in this comment should be removed together, as it also appears staled. "Update transaction's maximum wait time, if debugging is enabled." Thanks, Yi.
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index 66513c18ca29..e00b87635512 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c @@ -119,7 +119,6 @@ static void jbd2_get_transaction(journal_t *journal, * t_max_wait is carefully updated here with use of atomic compare exchange. * Note that there could be multiplre threads trying to do this simultaneously * hence using cmpxchg to avoid any use of locks in this case. - * With this t_max_wait can be updated w/o enabling jbd2_journal_enable_debug. */ static inline void update_t_max_wait(transaction_t *transaction, unsigned long ts)
Commit 2d44292058828 "jbd2: remove CONFIG_JBD2_DEBUG to update t_max_wait" removed jbd2_journal_enable_debug, just remove stale comment about jbd2_journal_enable_debug. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- fs/jbd2/transaction.c | 1 - 1 file changed, 1 deletion(-)