From patchwork Mon Nov 4 23:32:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thorsten Blum X-Patchwork-Id: 2006580 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=sjXOMbjP; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org (client-ip=2404:9400:2221:ea00::3; helo=mail.ozlabs.org; envelope-from=srs0=6hqu=r7=vger.kernel.org=linux-ext4+bounces-4949-patchwork-incoming=ozlabs.org@ozlabs.org; receiver=patchwork.ozlabs.org) Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xj77f4gg5z1xxb for ; Tue, 5 Nov 2024 10:33:18 +1100 (AEDT) Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4Xj77b41nqz4w2K for ; Tue, 5 Nov 2024 10:33:15 +1100 (AEDT) Received: by gandalf.ozlabs.org (Postfix) id 4Xj77b3zSbz4wbp; Tue, 5 Nov 2024 10:33:15 +1100 (AEDT) Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: gandalf.ozlabs.org; arc=pass smtp.remote-ip=147.75.199.223 arc.chain=subspace.kernel.org ARC-Seal: i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1730763190; cv=pass; b=ldcDukjBwM4c8MXDgbK4y6qCDdRuCjZ6+s8rbzbbOrAGm5Mymxi8oB2ooAMuk5g9yTYZ15n6WpywcObaQGZc91Il2SUTmXjCkHmXFIOXDbdkNflWF2FQu6cnVq3yMgNvWkPjMjju3yk3x5D8u/zk6mIeSixjETcIpVVG2IydyQzufwRmk+dF2VIblk35K/oL5T1NmKx1L0xJZD60WRpbK7NLMIAYwkWpTFY4/42NjatmtMAfHpBiK4fehAupbqA3UZGVYlrw5M6KD7qSOHPYhLmipcdOa/uAl70suEdFXMRs9KfYT9IeKA6G/e3PL/iWfGTpQ+KI0i7NWQ5K+GDcYw== ARC-Message-Signature: i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1730763190; c=relaxed/relaxed; bh=a/kh6MtV+hVG1cOKRS4IyBRlKmLHbveTOAvSOev07Ow=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V71pV7MugjK7pkfJDD2sqj011/Qcg3/0kK4javtMH8U4xjVwcV78set7Ieqp1gWDB18dmcntQSOlhmU6WpBFYTH0f4KYIxpl8/Me0y3GI/rTf9sQPsVeoAdaLUPurGbngevRNLNXl2VE9coPYZZuttBcYgnkYWWJXrj2Srvc1B2dNTvFGy/iM35vKGSMxGjTLjObw5xcFaDUbC8pFlrSCo7aq3UvCDqtIBH9F2qJHPk951pIBeLMxtve0tqphKZ03HGPSjrzqol7nr1p1I2akrqZQMHkj0GMtYIcn80cqAfLF2IlL+MGWGGD6E4iiiXa+5XJhSUijEIQFbhZiZL82A== ARC-Authentication-Results: i=2; gandalf.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=sjXOMbjP; dkim-atps=neutral; spf=pass (client-ip=147.75.199.223; helo=ny.mirrors.kernel.org; envelope-from=linux-ext4+bounces-4949-patchwork-incoming=ozlabs.org@vger.kernel.org; receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org Authentication-Results: gandalf.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: gandalf.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=sjXOMbjP; dkim-atps=neutral Authentication-Results: gandalf.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.199.223; helo=ny.mirrors.kernel.org; envelope-from=linux-ext4+bounces-4949-patchwork-incoming=ozlabs.org@vger.kernel.org; receiver=ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by gandalf.ozlabs.org (Postfix) with ESMTPS id 4Xj77S32qhz4w2K for ; Tue, 5 Nov 2024 10:33:08 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id ACAFA1C21F53 for ; Mon, 4 Nov 2024 23:33:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1785F1E5723; Mon, 4 Nov 2024 23:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="sjXOMbjP" X-Original-To: linux-ext4@vger.kernel.org Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88CE81FE101 for ; Mon, 4 Nov 2024 23:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730763172; cv=none; b=G9u9yfgkcJsHzRuEp4Nx0tq3CJOh4Ep2zqp9cCJMnwODaObLoaxgjLaBmMwWRo6aOlu+z1AypqM9jyx8gfucIxN5hZky2zsaDm2zNcmkgzb5AwwG/LoXNGe5THvLYpOAaU+kwk9qgSm/TdkqiOm/kR247bmGgmxexulhnRir2Bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730763172; c=relaxed/simple; bh=9463fSkV7FqBg+ae6ErrihpOEctWELQJ3N8F+ouU/p0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=H36DGtpfE8b2htlBYv56huTdbOE+Rr0I9IbcMdC/T7GsCRV8fV3VCCb10SjtM4OIdOkh12p79L09emjKCXAmyPL7IS5NTWSDFya02p8ToqmieIwHfliMS2GPDQ1mnVyy5QVyvJtIl/keF0tv1UgyLff6+NI1mjn7oJniwBOlBUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=sjXOMbjP; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730763165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=a/kh6MtV+hVG1cOKRS4IyBRlKmLHbveTOAvSOev07Ow=; b=sjXOMbjPXgACjwacXYWPccp9XqS4qKDNg2s5+VxgmC98Y+SvY/6dYlbTPqsEW0VaPRk9Sr rK1acSrMWjDWNTqRE1x+kyZ81q0fLfmk+MSuOVZDeeR9L7pBHMvUmp0/qeukRpKo1RNolp ZdNo2bXGygicj80U0mqezJAx3Vf+SS0= From: Thorsten Blum To: "Theodore Ts'o" , Andreas Dilger Cc: Thorsten Blum , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] ext4: Use str_yes_no() helper function Date: Tue, 5 Nov 2024 00:32:05 +0100 Message-ID: <20241104233204.7771-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.9 required=5.0 tests=ARC_SIGNED,ARC_VALID, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on gandalf.ozlabs.org Remove hard-coded strings by using the str_yes_no() helper function. Signed-off-by: Thorsten Blum Reviewed-by: Jan Kara --- fs/ext4/mballoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index d73e38323879..4d8e82cb90fd 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -5711,7 +5711,7 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac) (unsigned long)ac->ac_b_ex.fe_logical, (int)ac->ac_criteria); mb_debug(sb, "%u found", ac->ac_found); - mb_debug(sb, "used pa: %s, ", ac->ac_pa ? "yes" : "no"); + mb_debug(sb, "used pa: %s, ", str_yes_no(ac->ac_pa)); if (ac->ac_pa) mb_debug(sb, "pa_type %s\n", ac->ac_pa->pa_type == MB_GROUP_PA ? "group pa" : "inode pa"); @@ -6056,7 +6056,7 @@ static bool ext4_mb_discard_preallocations_should_retry(struct super_block *sb, } out_dbg: - mb_debug(sb, "freed %d, retry ? %s\n", freed, ret ? "yes" : "no"); + mb_debug(sb, "freed %d, retry ? %s\n", freed, str_yes_no(ret)); return ret; }