| Message ID | 20241104233204.7771-2-thorsten.blum@linux.dev |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND] ext4: Use str_yes_no() helper function | expand |
On Tue 05-11-24 00:32:05, Thorsten Blum wrote: > Remove hard-coded strings by using the str_yes_no() helper function. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> OK. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ext4/mballoc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index d73e38323879..4d8e82cb90fd 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -5711,7 +5711,7 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac) > (unsigned long)ac->ac_b_ex.fe_logical, > (int)ac->ac_criteria); > mb_debug(sb, "%u found", ac->ac_found); > - mb_debug(sb, "used pa: %s, ", ac->ac_pa ? "yes" : "no"); > + mb_debug(sb, "used pa: %s, ", str_yes_no(ac->ac_pa)); > if (ac->ac_pa) > mb_debug(sb, "pa_type %s\n", ac->ac_pa->pa_type == MB_GROUP_PA ? > "group pa" : "inode pa"); > @@ -6056,7 +6056,7 @@ static bool ext4_mb_discard_preallocations_should_retry(struct super_block *sb, > } > > out_dbg: > - mb_debug(sb, "freed %d, retry ? %s\n", freed, ret ? "yes" : "no"); > + mb_debug(sb, "freed %d, retry ? %s\n", freed, str_yes_no(ret)); > return ret; > } > > -- > 2.47.0 > >
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index d73e38323879..4d8e82cb90fd 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -5711,7 +5711,7 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac) (unsigned long)ac->ac_b_ex.fe_logical, (int)ac->ac_criteria); mb_debug(sb, "%u found", ac->ac_found); - mb_debug(sb, "used pa: %s, ", ac->ac_pa ? "yes" : "no"); + mb_debug(sb, "used pa: %s, ", str_yes_no(ac->ac_pa)); if (ac->ac_pa) mb_debug(sb, "pa_type %s\n", ac->ac_pa->pa_type == MB_GROUP_PA ? "group pa" : "inode pa"); @@ -6056,7 +6056,7 @@ static bool ext4_mb_discard_preallocations_should_retry(struct super_block *sb, } out_dbg: - mb_debug(sb, "freed %d, retry ? %s\n", freed, ret ? "yes" : "no"); + mb_debug(sb, "freed %d, retry ? %s\n", freed, str_yes_no(ret)); return ret; }
Remove hard-coded strings by using the str_yes_no() helper function. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- fs/ext4/mballoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)