| Message ID | 20240929185053.10554-2-pali@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | cifs: Improve support for native SMB symlinks | expand |
I lean against minor renames in rc2, better to focus on the bug fixes in your patch (the renaming also makes it a bit harder to backport fixes, so often better after all the fixes in, if important rename) On Sun, Sep 29, 2024 at 1:51 PM Pali Rohár <pali@kernel.org> wrote: > > This function creates a new reparse point, so put "create" into its name. > > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > fs/smb/client/reparse.c | 6 +++--- > fs/smb/client/smb2inode.c | 2 +- > fs/smb/client/smb2proto.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c > index a23ea2f78c09..507e17244ed3 100644 > --- a/fs/smb/client/reparse.c > +++ b/fs/smb/client/reparse.c > @@ -68,7 +68,7 @@ int smb2_create_reparse_symlink(const unsigned int xid, struct inode *inode, > convert_delimiter(sym, '/'); > iov.iov_base = buf; > iov.iov_len = len; > - new = smb2_get_reparse_inode(&data, inode->i_sb, xid, > + new = smb2_create_reparse_inode(&data, inode->i_sb, xid, > tcon, full_path, &iov, NULL); > if (!IS_ERR(new)) > d_instantiate(dentry, new); > @@ -136,7 +136,7 @@ static int mknod_nfs(unsigned int xid, struct inode *inode, > .reparse = { .tag = IO_REPARSE_TAG_NFS, .nfs = p, }, > }; > > - new = smb2_get_reparse_inode(&data, inode->i_sb, xid, > + new = smb2_create_reparse_inode(&data, inode->i_sb, xid, > tcon, full_path, &iov, NULL); > if (!IS_ERR(new)) > d_instantiate(dentry, new); > @@ -282,7 +282,7 @@ static int mknod_wsl(unsigned int xid, struct inode *inode, > memcpy(data.wsl.eas, &cc->ea, len); > data.wsl.eas_len = len; > > - new = smb2_get_reparse_inode(&data, inode->i_sb, > + new = smb2_create_reparse_inode(&data, inode->i_sb, > xid, tcon, full_path, > &reparse_iov, &xattr_iov); > if (!IS_ERR(new)) > diff --git a/fs/smb/client/smb2inode.c b/fs/smb/client/smb2inode.c > index 6e69a3b98be3..0fc73035d6dc 100644 > --- a/fs/smb/client/smb2inode.c > +++ b/fs/smb/client/smb2inode.c > @@ -1193,7 +1193,7 @@ smb2_set_file_info(struct inode *inode, const char *full_path, > return rc; > } > > -struct inode *smb2_get_reparse_inode(struct cifs_open_info_data *data, > +struct inode *smb2_create_reparse_inode(struct cifs_open_info_data *data, > struct super_block *sb, > const unsigned int xid, > struct cifs_tcon *tcon, > diff --git a/fs/smb/client/smb2proto.h b/fs/smb/client/smb2proto.h > index b208232b12a2..4ac30d29d5a1 100644 > --- a/fs/smb/client/smb2proto.h > +++ b/fs/smb/client/smb2proto.h > @@ -56,7 +56,7 @@ extern int smb3_handle_read_data(struct TCP_Server_Info *server, > extern int smb2_query_reparse_tag(const unsigned int xid, struct cifs_tcon *tcon, > struct cifs_sb_info *cifs_sb, const char *path, > __u32 *reparse_tag); > -struct inode *smb2_get_reparse_inode(struct cifs_open_info_data *data, > +struct inode *smb2_create_reparse_inode(struct cifs_open_info_data *data, > struct super_block *sb, > const unsigned int xid, > struct cifs_tcon *tcon, > -- > 2.20.1 > >
That is fine. You can also postpone changes in this patch series for next major version if it is needed to more testing. And if you think that this rename change cause issues, you can drop it. It is not functional change at all. On Sunday 29 September 2024 16:16:44 Steve French wrote: > I lean against minor renames in rc2, better to focus on the bug fixes > in your patch (the renaming also makes it a bit harder to backport > fixes, so often better after all the fixes in, if important rename) > > On Sun, Sep 29, 2024 at 1:51 PM Pali Rohár <pali@kernel.org> wrote: > > > > This function creates a new reparse point, so put "create" into its name. > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > --- > > fs/smb/client/reparse.c | 6 +++--- > > fs/smb/client/smb2inode.c | 2 +- > > fs/smb/client/smb2proto.h | 2 +- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c > > index a23ea2f78c09..507e17244ed3 100644 > > --- a/fs/smb/client/reparse.c > > +++ b/fs/smb/client/reparse.c > > @@ -68,7 +68,7 @@ int smb2_create_reparse_symlink(const unsigned int xid, struct inode *inode, > > convert_delimiter(sym, '/'); > > iov.iov_base = buf; > > iov.iov_len = len; > > - new = smb2_get_reparse_inode(&data, inode->i_sb, xid, > > + new = smb2_create_reparse_inode(&data, inode->i_sb, xid, > > tcon, full_path, &iov, NULL); > > if (!IS_ERR(new)) > > d_instantiate(dentry, new); > > @@ -136,7 +136,7 @@ static int mknod_nfs(unsigned int xid, struct inode *inode, > > .reparse = { .tag = IO_REPARSE_TAG_NFS, .nfs = p, }, > > }; > > > > - new = smb2_get_reparse_inode(&data, inode->i_sb, xid, > > + new = smb2_create_reparse_inode(&data, inode->i_sb, xid, > > tcon, full_path, &iov, NULL); > > if (!IS_ERR(new)) > > d_instantiate(dentry, new); > > @@ -282,7 +282,7 @@ static int mknod_wsl(unsigned int xid, struct inode *inode, > > memcpy(data.wsl.eas, &cc->ea, len); > > data.wsl.eas_len = len; > > > > - new = smb2_get_reparse_inode(&data, inode->i_sb, > > + new = smb2_create_reparse_inode(&data, inode->i_sb, > > xid, tcon, full_path, > > &reparse_iov, &xattr_iov); > > if (!IS_ERR(new)) > > diff --git a/fs/smb/client/smb2inode.c b/fs/smb/client/smb2inode.c > > index 6e69a3b98be3..0fc73035d6dc 100644 > > --- a/fs/smb/client/smb2inode.c > > +++ b/fs/smb/client/smb2inode.c > > @@ -1193,7 +1193,7 @@ smb2_set_file_info(struct inode *inode, const char *full_path, > > return rc; > > } > > > > -struct inode *smb2_get_reparse_inode(struct cifs_open_info_data *data, > > +struct inode *smb2_create_reparse_inode(struct cifs_open_info_data *data, > > struct super_block *sb, > > const unsigned int xid, > > struct cifs_tcon *tcon, > > diff --git a/fs/smb/client/smb2proto.h b/fs/smb/client/smb2proto.h > > index b208232b12a2..4ac30d29d5a1 100644 > > --- a/fs/smb/client/smb2proto.h > > +++ b/fs/smb/client/smb2proto.h > > @@ -56,7 +56,7 @@ extern int smb3_handle_read_data(struct TCP_Server_Info *server, > > extern int smb2_query_reparse_tag(const unsigned int xid, struct cifs_tcon *tcon, > > struct cifs_sb_info *cifs_sb, const char *path, > > __u32 *reparse_tag); > > -struct inode *smb2_get_reparse_inode(struct cifs_open_info_data *data, > > +struct inode *smb2_create_reparse_inode(struct cifs_open_info_data *data, > > struct super_block *sb, > > const unsigned int xid, > > struct cifs_tcon *tcon, > > -- > > 2.20.1 > > > > > > > -- > Thanks, > > Steve
diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c index a23ea2f78c09..507e17244ed3 100644 --- a/fs/smb/client/reparse.c +++ b/fs/smb/client/reparse.c @@ -68,7 +68,7 @@ int smb2_create_reparse_symlink(const unsigned int xid, struct inode *inode, convert_delimiter(sym, '/'); iov.iov_base = buf; iov.iov_len = len; - new = smb2_get_reparse_inode(&data, inode->i_sb, xid, + new = smb2_create_reparse_inode(&data, inode->i_sb, xid, tcon, full_path, &iov, NULL); if (!IS_ERR(new)) d_instantiate(dentry, new); @@ -136,7 +136,7 @@ static int mknod_nfs(unsigned int xid, struct inode *inode, .reparse = { .tag = IO_REPARSE_TAG_NFS, .nfs = p, }, }; - new = smb2_get_reparse_inode(&data, inode->i_sb, xid, + new = smb2_create_reparse_inode(&data, inode->i_sb, xid, tcon, full_path, &iov, NULL); if (!IS_ERR(new)) d_instantiate(dentry, new); @@ -282,7 +282,7 @@ static int mknod_wsl(unsigned int xid, struct inode *inode, memcpy(data.wsl.eas, &cc->ea, len); data.wsl.eas_len = len; - new = smb2_get_reparse_inode(&data, inode->i_sb, + new = smb2_create_reparse_inode(&data, inode->i_sb, xid, tcon, full_path, &reparse_iov, &xattr_iov); if (!IS_ERR(new)) diff --git a/fs/smb/client/smb2inode.c b/fs/smb/client/smb2inode.c index 6e69a3b98be3..0fc73035d6dc 100644 --- a/fs/smb/client/smb2inode.c +++ b/fs/smb/client/smb2inode.c @@ -1193,7 +1193,7 @@ smb2_set_file_info(struct inode *inode, const char *full_path, return rc; } -struct inode *smb2_get_reparse_inode(struct cifs_open_info_data *data, +struct inode *smb2_create_reparse_inode(struct cifs_open_info_data *data, struct super_block *sb, const unsigned int xid, struct cifs_tcon *tcon, diff --git a/fs/smb/client/smb2proto.h b/fs/smb/client/smb2proto.h index b208232b12a2..4ac30d29d5a1 100644 --- a/fs/smb/client/smb2proto.h +++ b/fs/smb/client/smb2proto.h @@ -56,7 +56,7 @@ extern int smb3_handle_read_data(struct TCP_Server_Info *server, extern int smb2_query_reparse_tag(const unsigned int xid, struct cifs_tcon *tcon, struct cifs_sb_info *cifs_sb, const char *path, __u32 *reparse_tag); -struct inode *smb2_get_reparse_inode(struct cifs_open_info_data *data, +struct inode *smb2_create_reparse_inode(struct cifs_open_info_data *data, struct super_block *sb, const unsigned int xid, struct cifs_tcon *tcon,
This function creates a new reparse point, so put "create" into its name. Signed-off-by: Pali Rohár <pali@kernel.org> --- fs/smb/client/reparse.c | 6 +++--- fs/smb/client/smb2inode.c | 2 +- fs/smb/client/smb2proto.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)