Message ID | 20241001082053.3455836-8-Delphine_CC_Chiu@wiwynn.com |
---|---|
State | New |
Headers | show |
Series | Add I2C mux devices for yosemite4 | expand |
On Tue, 2024-10-01 at 16:20 +0800, Delphine CC Chiu wrote: > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > Fix the compatible string for max31790 to match the binding document. > > Fixes: 2b8d94f4b4a4 ("ARM: dts: aspeed: yosemite4: add Facebook Yosemite 4 BMC") Can you please order this change to patch 06/10? That way the fixes tag is meaningful. Otherwise the fix is disrupted by the code motion in 06/10. Andrew
> -----Original Message----- > From: Andrew Jeffery <andrew@codeconstruct.com.au> > Sent: Wednesday, October 2, 2024 9:46 AM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>; > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley > <joel@jms.id.au> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 07/10] ARM: dts: aspeed: yosemite4: correct the > compatible string for max31790 > > [External Sender] > > [External Sender] > > On Tue, 2024-10-01 at 16:20 +0800, Delphine CC Chiu wrote: > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > > > Fix the compatible string for max31790 to match the binding document. > > > > Fixes: 2b8d94f4b4a4 ("ARM: dts: aspeed: yosemite4: add Facebook > > Yosemite 4 BMC") > > Can you please order this change to patch 06/10? That way the fixes tag is > meaningful. Otherwise the fix is disrupted by the code motion in 06/10. > > Andrew Sure, I will order this patch to 06/10 in the next version of patches. Regards, Ricky
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index ecf012c9cbbc..01ee455c41b0 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -1177,10 +1177,8 @@ adc@1f { }; pwm@20{ - compatible = "max31790"; + compatible = "maxim,max31790"; reg = <0x20>; - #address-cells = <1>; - #size-cells = <0>; }; gpio@22{ @@ -1191,10 +1189,8 @@ gpio@22{ }; pwm@23{ - compatible = "max31790"; + compatible = "maxim,max31790"; reg = <0x23>; - #address-cells = <1>; - #size-cells = <0>; }; adc@33 { @@ -1229,10 +1225,8 @@ adc@1f { }; pwm@20{ - compatible = "max31790"; + compatible = "maxim,max31790"; reg = <0x20>; - #address-cells = <1>; - #size-cells = <0>; }; gpio@22{ @@ -1243,10 +1237,8 @@ gpio@22{ }; pwm@23{ - compatible = "max31790"; + compatible = "maxim,max31790"; reg = <0x23>; - #address-cells = <1>; - #size-cells = <0>; }; adc@33 {