diff mbox series

[v1] ARM: dts: aspeed: System1: Updates to BMC board

Message ID 20240604215939.1967329-1-ninad@linux.ibm.com
State New
Headers show
Series [v1] ARM: dts: aspeed: System1: Updates to BMC board | expand

Commit Message

Ninad Palsule June 4, 2024, 9:59 p.m. UTC
- Added new power monitor device max5970
- Changed temperature sensor monitor chip from tmp423 to tmp432

Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Rob Herring (Arm) June 5, 2024, 1:11 p.m. UTC | #1
On Tue, 04 Jun 2024 16:59:39 -0500, Ninad Palsule wrote:
> - Added new power monitor device max5970
> - Changed temperature sensor monitor chip from tmp423 to tmp432
> 
> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20240604215939.1967329-1-ninad@linux.ibm.com:

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: power-monitor@3a: 'regulators' is a required property
	from schema $id: http://devicetree.org/schemas/mfd/maxim,max5970.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: power-monitor@3a: 'vss1-supply' is a required property
	from schema $id: http://devicetree.org/schemas/mfd/maxim,max5970.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: power-monitor@3a: 'vss2-supply' is a required property
	from schema $id: http://devicetree.org/schemas/mfd/maxim,max5970.yaml#
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
index dcbc16308ab50..e09a6b383ba49 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts
@@ -753,6 +753,11 @@  &i2c4 {
 &i2c5 {
 	status = "okay";
 
+	power-monitor@3a {
+		compatible = "maxim,max5970";
+		reg = <0x3a>;
+	};
+
 	regulator@42 {
 		compatible = "infineon,ir38263";
 		reg = <0x42>;
@@ -1138,7 +1143,7 @@  i2c8mux0chn6: i2c@6 {
 			reg = <6>;
 
 			temperature-sensor@4c {
-				compatible = "ti,tmp423";
+				compatible = "ti,tmp432";
 				reg = <0x4c>;
 			};
 		};
@@ -1599,7 +1604,7 @@  i2c15mux0chn6: i2c@6 {
 			reg = <6>;
 
 			temperature-sensor@4c {
-				compatible = "ti,tmp423";
+				compatible = "ti,tmp432";
 				reg = <0x4c>;
 			};
 		};
@@ -1615,7 +1620,7 @@  regulator@40 {
 			};
 
 			temperature-sensor@4c {
-				compatible = "ti,tmp423";
+				compatible = "ti,tmp432";
 				reg = <0x4c>;
 			};
 		};