From patchwork Thu Dec 19 02:34:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 2025419 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TAG/UdCi; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=RnX+kMKU; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4YDF5B1qn0z1yQN for ; Thu, 19 Dec 2024 13:35:10 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q9z30wC4sw2T6Lmoqrcpi7L0AZjXDllSVh4a/7HF+q4=; b=TAG/UdCijvppQP sTdcYX5KPy6FMOUMQNKKOP7QAJNFmEGGP1Fpldk6Xa5b3CweBpXNzbm++4CgJKLk6WSxU/o4++77r hZNbTLCbikyjilnk97JGu4OPYHB16v35Q6r5puswtUUcz9C5TlUYwg256TrVPjZUISejM4n845HKh 5f1lic8HJIDDkEj9+9Hf+n/0mXoacxDdnAFltuigB3dKGT4gcM36pr3x3eG6K57kLy8BmXnPhdaqR U8VQe1l0KmYdMx+zaRd4I2rk/zGlCaNHdcGxMDMxNzWc1YBz5RNtUJ5hA2pU6w0+AV0N4DniIjtnU 6s1FGiUHzo618X6gQoVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tO6NZ-00000000cI0-2Qqo; Thu, 19 Dec 2024 02:35:09 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tO6NX-00000000cFQ-1x86 for linux-snps-arc@lists.infradead.org; Thu, 19 Dec 2024 02:35:08 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-2167141dfa1so2840785ad.1 for ; Wed, 18 Dec 2024 18:35:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734575706; x=1735180506; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6yZ75uwrgzXS/KAS9XiI4pfcH/Aa7U+Upt9QqSiD0i8=; b=RnX+kMKULQ3C3Ce9IP/49uxDracTi8TA+3FmGwnaHLLL5ShwAIYoBitkivtepWiihQ Q7X9pQel/iCyC7P+/dPD1gKRs8Dtuh11qAxVGpYaia8YVJ15WwA7F0GDVxLvU8fhbtgn elcYrq327sJRWC/HJ/HDX3hip9RdEoPA11DEni3v09w2Lmu2iFF/OLdl1kEzXHkF6sev T4hGjsK/HRDM3/QUaAQj9469s5PjvJ4mRqOwCJ93FqYi8puXYU08xCaWXcFZVkWONxX9 JqeVpQAaAObjLE8paadVTJxY7nJaki+n2HiH+M4JNGtxGJuCmFzHgaxnlF7p1W0qFc8Q 8u3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734575706; x=1735180506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6yZ75uwrgzXS/KAS9XiI4pfcH/Aa7U+Upt9QqSiD0i8=; b=OZ4URTj43eVgBHXT376Lz9BitnqdCAhUlaKpbKw9TzZLdSvoKyTuRa0ur8a5IlMZh+ SutCp1YZyLuxLE0QoxPAyXhkhHQTRLTNMx9ivVM+vAisgG2OVZ0+tK67tpYdwiCmqUR6 0MJjEOQsvgF9IKs2GeOrdYdDJ1xDFbkMIGQZNMjPDUHwNucmUSvr5j3e+YqRqOvNMyFS i5juywl7QGeC7pdsOtngaW0hb1HywGEEkWXYybhkZI1PsGgyo2G7H8233r2fPa5aYT0y A4AJEyoO1ka/FugZWiSjX+CLsIBKz9Nd+exrJ1DJY1Eh7nhCLSkTz2NK7+TWv35/o6Sq dZzw== X-Forwarded-Encrypted: i=1; AJvYcCXPEgp3T99idmL6yTIBs1oRopE3vQsCSFH28NdHc8K4irfJymDw3eVlWTt3Eh76mtmyFRzNbHxK/YcpMGPPWA==@lists.infradead.org X-Gm-Message-State: AOJu0Yzgo0rFqNZySKcDRxjSPqYIO6qTlbSiwSjTWx3dL8c+dVjbTcbh 19fi1uKJLAbokI+fhQKhDnx/p1RCc/WqK788hZWgvxLe2l6vkPXtW1QBQHRfjp0= X-Gm-Gg: ASbGncvwkcOGgmCtupCwcxgcZD1NmE3LJB872dUXo3R1sxMmzlwLLzM9jq031f6Vukj 0Wh659W4FwJHcPEtzHG/rSxMzdgvPm0TOYQMDl6SGLwS1GW15mJsWfmXfVIaSWxZYgPZsOfKb3g VuedKCXc/FVcNXlUdmUh1Hsysm2ChyLjgtLHG9RmoqAbspN5yZb8esS+oDYTvcDrDFRR0toQziK gygM7O+cxEzqqRbNLGgeRa1qfocwYnGWtz5GnSm2r8nXQAXiqc4IplKvM01a7ZJmWHrH4rHF8IN LZUFdzU= X-Google-Smtp-Source: AGHT+IHDUXmWYVlYvXYhHIsD36N49JfOorXAToNFZUciCwG5nEYfG9fZ9g2sYrKUGUIeEzsd5pUGJQ== X-Received: by 2002:a17:902:f689:b0:215:2d2c:dd0c with SMTP id d9443c01a7336-219da5e3b97mr23433885ad.14.1734575706180; Wed, 18 Dec 2024 18:35:06 -0800 (PST) Received: from localhost.localdomain ([180.159.118.224]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842b821da83sm142163a12.40.2024.12.18.18.35.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 18 Dec 2024 18:35:05 -0800 (PST) From: Yafang Shao To: akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, pmladek@suse.com, kvalo@kernel.org, bp@alien8.de, andriy.shevchenko@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org, linux-snps-arc@lists.infradead.org, linux-wireless@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, ocfs2-devel@lists.linux.dev, Yafang Shao , Serge Hallyn , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?utf-8?q?Andr=C3=A9_Almeida?= Subject: [PATCH v2 1/5] kernel: Remove get_task_comm() and print task comm directly Date: Thu, 19 Dec 2024 10:34:48 +0800 Message-Id: <20241219023452.69907-2-laoar.shao@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) In-Reply-To: <20241219023452.69907-1-laoar.shao@gmail.com> References: <20241219023452.69907-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241218_183507_506890_2FCFD05E X-CRM114-Status: GOOD ( 13.39 ) X-Spam-Score: -2.1 (--) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Since_task-=3Ecomm_is_guaranteed_to_be?= =?unknown-8bit?q?_NUL-terminated=2C_we_can?= =?unknown-8bit?q?_print_it_directly_without_the_need_to_copy_it_into_a_separ?= =?unknown-8bit?q?ate_buffer=2E_This?= =?unknown-8bit?q?_simplifies_the_code_and_avoids_unnecessary_operations=2E_S?= =?unknown-8bit?q?igned-off-by=3A_Yafang?= =?unknown-8bit?q?_Shao_Cc=3A_Serge_Hallyn_Cc=3A_Thomas_Gleixner_Cc=3A_Ingo_M?= =?unknown-8bit?q?olnar_Cc=3A_Peter_Zijlstra?= =?unknown-8bit?q?_Cc=3A_Darren_Hart_Cc=3A_Davidlohr_Bueso_Cc=3A_=22Andr=C3?= =?unknown-8bit?q?=A9_Almeida=22_---_kernel/capability=2Ec?= =?unknown-8bit?b?IHwgOCBbLi4uXSA=?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=28-2=2E1_points=2C_5=2E0_re?= =?unknown-8bit?q?quired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyNjA3OmY4YjA6NDg2NDoyMDowOjA6MDo2MzYgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_envelope-from_domain?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from_author=27s?= =?unknown-8bit?q?_domain?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_-1=2E9_BAYES=5F00_______________BODY=3A_Bayes_spam_probabi?= =?unknown-8bit?q?lity_is_0_to_1=25?= =?unknown-8bit?q?_=5Bscore=3A_0=2E0000=5D?= =?unknown-8bit?q?_0=2E0_FREEMAIL=5FFROM__________Sender_email_is_commonly_ab?= =?unknown-8bit?q?used_enduser_mail_provider?= =?unknown-8bit?b?IFtsYW9hci5zaGFvKGF0KWdtYWlsLmNvbV0=?= X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copy it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Serge Hallyn Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Darren Hart Cc: Davidlohr Bueso Cc: "André Almeida" --- kernel/capability.c | 8 ++------ kernel/futex/waitwake.c | 3 +-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/kernel/capability.c b/kernel/capability.c index dac4df77e376..e089d2628c29 100644 --- a/kernel/capability.c +++ b/kernel/capability.c @@ -38,10 +38,8 @@ __setup("no_file_caps", file_caps_disable); static void warn_legacy_capability_use(void) { - char name[sizeof(current->comm)]; - pr_info_once("warning: `%s' uses 32-bit capabilities (legacy support in use)\n", - get_task_comm(name, current)); + current->comm); } /* @@ -62,10 +60,8 @@ static void warn_legacy_capability_use(void) static void warn_deprecated_v2(void) { - char name[sizeof(current->comm)]; - pr_info_once("warning: `%s' uses deprecated v2 capabilities in a way that may be insecure\n", - get_task_comm(name, current)); + current->comm); } /* diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c index 3a10375d9521..eb86a7ade06a 100644 --- a/kernel/futex/waitwake.c +++ b/kernel/futex/waitwake.c @@ -210,13 +210,12 @@ static int futex_atomic_op_inuser(unsigned int encoded_op, u32 __user *uaddr) if (encoded_op & (FUTEX_OP_OPARG_SHIFT << 28)) { if (oparg < 0 || oparg > 31) { - char comm[sizeof(current->comm)]; /* * kill this print and return -EINVAL when userspace * is sane again */ pr_info_ratelimited("futex_wake_op: %s tries to shift op by %d; fix this program\n", - get_task_comm(comm, current), oparg); + current->comm, oparg); oparg &= 31; } oparg = 1 << oparg;